Re: parallel-all-tests update

2018-10-14 Thread Jim Apple
dev@impala sets the return address to itself, not the author of the post. You are nowhere near the first person to be bitten by this, which is why I am posting to dev@ and which I hope is some consolation. On Thu, Oct 11, 2018 at 9:21 PM Philip Zeyliger wrote: > -everyone > > I took advantage o

Re: parallel-all-tests update

2018-10-12 Thread Laszlo Gaal
update: pg_hba.conf contains 'ident' only on CentOS (both 6 and 7); on Ubuntu it's 'peer'. On Fri, Oct 12, 2018 at 3:47 PM Laszlo Gaal wrote: > It failed; apparently the setup script failed to change the pgsql access > mode to "trust". > I spun up a centos:6 container and looked around inside: >

Re: parallel-all-tests update

2018-10-12 Thread Laszlo Gaal
It failed; apparently the setup script failed to change the pgsql access mode to "trust". I spun up a centos:6 container and looked around inside: - CentOS is 6.10 - PostgreSQL is 8.4, - pg_hba.conf contains 'ident' for the default authN mode, so this location: http://github.mtv.cloudera.com/philip

Re: parallel-all-tests update

2018-10-11 Thread Philip Zeyliger
-everyone I took advantage of your work on the packer template and wrote http://github.mtv.cloudera.com/philip/Impala/commit/4c9786eb6455a13f442b771e9296f204a692c2c2 . I'll keep poking at it until it works. Right now it's getting as far as most of the C++ build. Annoyingly, it's now at the "slow"

Re: parallel-all-tests update

2018-10-11 Thread Laszlo Gaal
I'd be happy to pitch in; this is aligned with other test infra stuff I'm working on. On Thu, Oct 11, 2018 at 7:34 PM Philip Zeyliger wrote: > I'm working a little bit (in the background) on getting > bin/bootstrap_system.sh to work. I'm somewhat optimistic that I can get it > to work :) > > I f

Re: parallel-all-tests update

2018-10-11 Thread Philip Zeyliger
I'm working a little bit (in the background) on getting bin/bootstrap_system.sh to work. I'm somewhat optimistic that I can get it to work :) I filed https://issues.apache.org/jira/browse/IMPALA-7698. Let me know if you want to help dig in! -- Philip On Thu, Oct 11, 2018 at 10:16 AM Pooja Nilang

Re: parallel-all-tests update

2018-10-11 Thread Pooja Nilangekar
I agree with the approach of running the tests on supported platforms. In the past couple of days, there have been multiple issues (IMPALA-7678 & IMPALA-7690 ) due to python2.6 compatibility issue

Re: parallel-all-tests update

2018-09-27 Thread Philip Zeyliger
I think the approach to catch that is to just run the tests on the relevant platform. (E.g., with test-with-docker or something to make the Jenkins setup less painful.) Looking through some recent commits, I found: 304e02cf6238a3c1e9537337f802bcf7a92df5db "{}".format(1) 9cfa228c2e itertools.count(

Re: parallel-all-tests update

2018-09-27 Thread Tim Armstrong
Is it worth adding some regexes or similar to the gerrit bot to catch itertools.count() usage? Or do we not expect repeated bugs of this form? On Thu, Sep 27, 2018 at 12:59 PM Tim Armstrong wrote: > I also added it to the pre-review tests. Let me know if you see any issues. > > On Thu, Sep 27, 2

Re: parallel-all-tests update

2018-09-27 Thread Tim Armstrong
I also added it to the pre-review tests. Let me know if you see any issues. On Thu, Sep 27, 2018 at 12:33 PM Philip Zeyliger wrote: > Hi folks, > > To address IMPALA-6543, there's a new test in parallel-all-tests that makes > sure that any Python scripts use Python2.6-compatible syntax. Note tha

parallel-all-tests update

2018-09-27 Thread Philip Zeyliger
Hi folks, To address IMPALA-6543, there's a new test in parallel-all-tests that makes sure that any Python scripts use Python2.6-compatible syntax. Note that this will catch the "try/catch/finally" style of bug, but not the "itertools.count(start=1)" kind of bug (python2.7 changed the signature of