[Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/2580/7/fe/src/ma

[Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage

2016-03-30 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new patch set (#10). Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage .. IMPALA-3038: Add multistream gzip/bzip2 test coverage Change-Id: I9b0e1971145dd457e71fc9c00ce7c06fff8dea88 ---

[Impala-CR](cdh5-trunk) IMPALA-2988:Refactor HdfsTableSink::Close() so that it cannot fail

2016-03-30 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/2678 Change subject: IMPALA-2988:Refactor HdfsTableSink::Close() so that it cannot fail .. IMPALA-2988:Refactor HdfsTableSink::Close() so tha

[Impala-CR](cdh5-trunk) IMPALA-3274: Disable Kudu when not using the mini-cluster for testing

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3274: Disable Kudu when not using the mini-cluster for testing .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2673 To unsub

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. Patch Set 9: Code-Review+1 thanks! -- To view, visit http://gerrit.cloudera.org:808

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Fix start-impala-cluster.py with -s 0. .. Fix start-impala-cluster.py with -s 0. Bug: Division by zero. Starting only the statestored and catalogd c

[Impala-CR](cdh5-trunk) IMPALA-3274: Disable Kudu when not using the mini-cluster for testing

2016-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3274: Disable Kudu when not using the mini-cluster for testing .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/2673 To

[Impala-CR](cdh5-trunk) IMPALA-3274: Disable Kudu when not using the mini-cluster for testing

2016-03-30 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2673 Change subject: IMPALA-3274: Disable Kudu when not using the mini-cluster for testing .. IMPALA-3274: Disable Kudu when not using the mini

[Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

2016-03-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem .. Patch Set 11: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/1121/11//COM

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-03-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/2574/10/be/src/util/hdfs-u

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/2384/8/be/src/ex

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Skye Wanderman-Milne (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2384 to look at the new patch set (#9). Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. Patch Set 8: Code-Review+2 (4 comments) Please see if Matt wanted to make another pass be

Re: New link errors. undefined reference to _Ux86_64*

2016-03-30 Thread Skye Wanderman-Milne
It might be useful to run the following: cd $IMPALA_HOME rm CMakeCache.txt cmake . This will print the locations of all the linked libraries. For instance, I get: -- GLog include dir: /opt/Impala-Toolchain/glog-0.3.2-p1/include You can use this to verify which glog you're linking against. On Wed

Re: New link errors. undefined reference to _Ux86_64*

2016-03-30 Thread Tim Armstrong
It looks like you are picking up your system's version of glog rather than one of the versions distributed with Impala. I'm not sure why it would be doing this, but I'd suggest doing a full clean and build first to see if that resolves it. If you are doing a toolchain build, it should be linking

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has uploaded a new patch set (#8). Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option This patch

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2384/7/be/src/ex

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 3: Code-Review+2 I was missing quotes around the environment variable: it failed when the

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Hello Casey Ching, Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2665 to look at the new patch set (#3). Change subject: Allow switching between custom and bootstrapped toolchain ..

[Impala-CR](cdh5-trunk) IMPALA-2399: Memory limit checks for all scanners.

2016-03-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Memory limit checks for all scanners. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2568 To unsubscribe, visit http:/

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Fix start-impala-cluster.py with -s 0. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2666 To unsubscribe, visit http://gerrit.clou

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Alex Behm (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2666 to look at the new patch set (#3). Change subject: Fix start-impala-cluster.py with -s 0. .. Fix start-impala-clu

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Fix start-impala-cluster.py with -s 0. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2666/2/bin/start-impala-cluster.py File bin/start-impala-clus

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix start-impala-cluster.py with -s 0. .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2666/2/bin/start-impala-cluster.py File bi

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Fix start-impala-cluster.py with -s 0. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2666/1/bin/start-impala-cluster.py File bin/start-impala-clus

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: Fix start-impala-cluster.py with -s 0. .. Fix start-impala-cluster.py with -s 0. Bug: Division by zero. Starting only the statestored and catalogd can be useful for d

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Fix start-impala-cluster.py with -s 0. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2666/1/bin/start-impala-cluster.py File bin/start-impala

[Impala-CR](cdh5-trunk) Log EE XUnit test result in IMPALA_HOME/logs/ee_tests/results.

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/2667 Change subject: Log EE XUnit test result in IMPALA_HOME/logs/ee_tests/results. .. Log EE XUnit test result in IMPALA_HOME/logs/ee_tests/resul

[Impala-CR](cdh5-trunk) Fix start-impala-cluster.py with -s 0.

2016-03-30 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/2666 Change subject: Fix start-impala-cluster.py with -s 0. .. Fix start-impala-cluster.py with -s 0. Bug: Division by zero. Fix: Use max(cluster

[Impala-CR](cdh5-trunk) IMPALA-2399: Memory limit checks for all scanners.

2016-03-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2399: Memory limit checks for all scanners. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2568/2/be/src/exec/hdfs-avro-scanner.h File be/

[Impala-CR](cdh5-trunk) IMPALA-2399: Memory limit checks for all scanners.

2016-03-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-2399: Memory limit checks for all scanners. .. IMPALA-2399: Memory limit checks for all scanners. This change replaces all instances of MemPool::Allocate() in

[hs2client-CR] Implemented a framework for the C++ hiveserver2 client.

2016-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Implemented a framework for the C++ hiveserver2 client. .. Patch Set 3: (9 comments) There used to be more .cc files -- should they be here? http://gerrit.clo

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Hello Casey Ching, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2665 to look at the new patch set (#2). Change subject: Allow switching between custom and bootstrapped toolchain

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/2665 To unsu

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2665/1//COMMIT_MSG Commit Message: Li

[Impala-CR](cdh5-trunk) Re-enable Kudu in build using client stubs when needed

2016-03-30 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Re-enable Kudu in build using client stubs when needed .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2585/8/tests/common/impala_test_suite.py Fi

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2665/1//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) IMPALA-2076: Correct execution time for DataStreamSender.

2016-03-30 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-2076: Correct execution time for DataStreamSender. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2578/2/be/src/runtime/client-cache.h File be

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 1: Code-Review+1 ok, makes sense -- To view, visit http://gerrit.cloudera.org:8080/2665

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2384/7/be/src/service/q

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2665/1/CMakeLists.txt File CMakeLists.

[Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

2016-03-30 Thread Bharath Vissapragada (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2580 to look at the new patch set (#7). Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC/sequence files

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Allow switching between custom and bootstrapped toolchain .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2665/1/CMakeLists.txt File CMakeLists

[Impala-CR](cdh5-trunk) IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE

2016-03-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE .. Patch Set 6: (1 comment) Updating the CR as per my discussion with Alex. The

[Impala-CR](cdh5-trunk) Re-enable Kudu in build using client stubs when needed

2016-03-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Re-enable Kudu in build using client stubs when needed .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2585/8/tests/common/impala_test_suite.py File

[Impala-CR](cdh5-trunk) Allow switching between custom and bootstrapped toolchain

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/2665 Change subject: Allow switching between custom and bootstrapped toolchain .. Allow switching between custom and bootstrapped toolchain I

[Impala-CR](cdh5-trunk) IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option

2016-03-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2835: introduce PARQUET_FALLBACK_SCHEMA_RESOLUTION query option .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2384/7/be/src/service/query-

[Impala-CR](cdh5-trunk) Re-enable Kudu in build using client stubs when needed

2016-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Re-enable Kudu in build using client stubs when needed .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2585/8/tests/common/impala_test_suite.py Fi

[Impala-CR](cdh5-trunk) IMPALA-3238: avoid log spam for very large hash tables

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3238: avoid log spam for very large hash tables .. Patch Set 2: Code-Review+2 Verified+1 Rebase, carry +2 and +1 from GVM that failed during archiving. -

[Impala-CR](cdh5-trunk) IMPALA-3238: avoid log spam for very large hash tables

2016-03-30 Thread Tim Armstrong (Code Review)
Hello Internal Jenkins, Todd Lipcon, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2659 to look at the new patch set (#2). Change subject: IMPALA-3238: avoid log spam for very large hash tables ..

[Impala-CR](cdh5-trunk) IMPALA-3238: avoid log spam for very large hash tables

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3238: avoid log spam for very large hash tables .. IMPALA-3238: avoid log spam for very large hash tables Before this change, every time the limi

[Impala-CR](cdh5-trunk) IMPALA-3238: avoid log spam for very large hash tables

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3238: avoid log spam for very large hash tables .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2659 To unsubscribe, visit h

[Impala-CR](cdh5-trunk) IMPALA-3238: avoid log spam for very large hash tables

2016-03-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3238: avoid log spam for very large hash tables .. Patch Set 1: The GVM failed right at the end when archiving logs. All the tests passed. I'm going to m

[Toolchain-CR] fix broken bzip2 executable symlinks and make them relative and relocatable

2016-03-30 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: fix broken bzip2 executable symlinks and make them relative and relocatable .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2525 T

[Impala-CR](cdh5-trunk) IMPALA-3269: Remove authz checks on default table location in CTAS queries

2016-03-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/2664 Change subject: IMPALA-3269: Remove authz checks on default table location in CTAS queries .. IMPALA-3269: Remove authz checks on

[Impala-CR](cdh5-trunk) IMPALA-3072: Allow frame embedding for webserver pages

2016-03-30 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3072: Allow frame embedding for webserver pages .. IMPALA-3072: Allow frame embedding for webserver pages Check that 'X-Frame-Options' HTTP he