[Impala-CR](cdh5-trunk) Kudu: Disable fsync in the mini-cluster

2016-04-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Kudu: Disable fsync in the mini-cluster .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2734/2//COMMIT_MSG Commit Message: Line 12: if Kudu

Re: [Impala-CR](cdh5-trunk) Kudu: Disable fsync in the mini-cluster

2016-04-07 Thread Henry Robinson
Just fyi, corrected a typo in the commit msg with Gerrit (didn't realise you could do that!). On 7 April 2016 at 22:23, Henry Robinson (Code Review) wrote: > Hello Alex Behm, > > I'd like you to reexamine a change. Please visit > > http://gerrit.cloudera.org:8080/2734

[Impala-CR](cdh5-trunk) Kudu: Disable fsync in the mini-cluster

2016-04-07 Thread Henry Robinson (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2734 to look at the new patch set (#2). Change subject: Kudu: Disable fsync in the mini-cluster .. Kudu: Disable fsync in

[Impala-CR](cdh5-trunk) Kudu: Disable fsnyc in the mini-cluster

2016-04-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Kudu: Disable fsnyc in the mini-cluster .. Patch Set 1: Code-Review+2 makes sense to me -- To view, visit http://gerrit.cloudera.org:8080/2734 To unsubscribe,

[Impala-CR](cdh5-trunk) Kudu: Disable fsnyc in the mini-cluster

2016-04-07 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2734 Change subject: Kudu: Disable fsnyc in the mini-cluster .. Kudu: Disable fsnyc in the mini-cluster The Kudu team recommended disabling

Re: maven error while compiling the front end code

2016-04-07 Thread Skye Wanderman-Milne
Thanks for sharing Pradeep. Unfortunately I don't have time to investigate this further right now, but I think this info will be useful for others running a similar setup as you. On Tue, Apr 5, 2016 at 1:45 PM, Pradeep Nayak wrote: > This is what I saw in IMPALAD.info: >

[Impala-CR](cdh5-trunk) Update python impala cluster script for docker compatibility

2016-04-07 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Update python impala cluster script for docker compatibility .. Update python impala cluster script for docker compatibility The python scripts

[Impala-CR](cdh5-trunk) IMPALA-2680: faster memory copy

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2680: faster memory copy .. Patch Set 10: I ran an end-to-end benchmark query does a lot of small memcpys (on non-codegened paths, some of which will be

[Impala-CR](cdh5-trunk) Remove conjuncts_passed arg in various Parquet scanner functions.

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove conjuncts_passed arg in various Parquet scanner functions. .. Patch Set 1: Code-Review+1 This was previously used when runtime filters were evaluated in

[Impala-CR](cdh5-trunk) IMPALA-2805: Order conjunctss based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2805: Order conjunctss based on selectivity and cost .. Patch Set 7: Results for tpcds from Jenkins: Report Generated on 2016-04-07 Cluster

[Impala-CR](cdh5-trunk) Remove conjuncts_passed arg in various Parquet scanner functions.

2016-04-07 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/2732 Change subject: Remove conjuncts_passed arg in various Parquet scanner functions. .. Remove conjuncts_passed arg in various Parquet scanner

[Impala-CR](cdh5-trunk) IMPALA-2805: Order conjunctss based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#7). Change subject: IMPALA-2805: Order conjunctss based on selectivity and cost .. IMPALA-2805: Order conjunctss based on selectivity and cost Added costs to all Exprs,

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 6: Results for tpch_nested from the Jenkins run, updated to a more recent

[Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

2016-04-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem .. Patch Set 12: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

2016-04-07 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem .. Patch Set 12: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-2864: Ensure that client connections are closed after a failed RPC and a failed Open()

2016-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#7). Change subject: IMPALA-2864: Ensure that client connections are closed after a failed RPC and a failed Open() .. IMPALA-2864: Ensure that client connections are closed after a

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems .. Patch Set 11: (7 comments) That sounds good to me. But just FYI, Anuj is on PTO

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems .. Patch Set 10: (1 comment)

[Impala-CR](cdh5-trunk) Update python impala cluster script for docker compatibility

2016-04-07 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Update python impala cluster script for docker compatibility .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/1629 To

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 6: Just one nit - could you change the title to 'Order *conjuncts* based on selectivity

[Impala-CR](cdh5-trunk) Update python impala cluster script for docker compatibility

2016-04-07 Thread Casey Ching (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1629 to look at the new patch set (#2). Change subject: Update python impala cluster script for docker compatibility ..

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 6: Results for tpch from the Jenkins run, updated to a more recent baseline, per

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 6: Results for the targeted-perf test I added from a local run: Report Generated

[Impala-CR](cdh5-trunk) Update python impala cluster script for docker compatibility

2016-04-07 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Update python impala cluster script for docker compatibility .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) Update python impala cluster script for docker compatibility

2016-04-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Update python impala cluster script for docker compatibility .. Patch Set 1: Code-Review+2 worksforme -- To view, visit http://gerrit.cloudera.org:8080/1629

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#6). Change subject: IMPALA-2805: Order filters based on selectivity and cost .. IMPALA-2805: Order filters based on selectivity and cost Added costs to all Exprs, which

[Impala-CR](cdh5-trunk) Update python impala cluster script for docker compatibility

2016-04-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Update python impala cluster script for docker compatibility .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3038: Add multistream gzip/bzip2 test coverage

2016-04-07 Thread Juan Yu (Code Review)
Hello Skye Wanderman-Milne, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2543 to look at the new patch set (#12). Change subject: IMPALA-3038: Add multistream gzip/bzip2 test coverage

[Impala-CR](cdh5-trunk) Remove generated server.xml file

2016-04-07 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Remove generated server.xml file .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2730 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-2805: Order filters based on selectivity and cost .. IMPALA-2805: Order filters based on selectivity and cost Added costs to all Exprs, which estimate the

[Impala-CR](cdh5-trunk) Remove generated server.xml file

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove generated server.xml file .. Patch Set 1: I've deleted this file before. This looks like it got checked in by a Jenkins job, so we should fix that too:

[Impala-CR](cdh5-trunk) Remove generated server.xml file

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/2730 Change subject: Remove generated server.xml file .. Remove generated server.xml file Change-Id:

[Impala-CR](cdh5-trunk) IMPALA-3105: avoid overrunning allocated tuple buffer

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer .. Patch Set 3: Reworked the change so that it's less invasive and changes capacity_ only when the tuple

[Impala-CR](cdh5-trunk) IMPALA-3105: avoid overrunning allocated tuple buffer

2016-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3105: avoid overrunning allocated tuple buffer .. IMPALA-3105: avoid overrunning allocated tuple buffer This change reworks allocation of tuple buffers.

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 4: Performance results:

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-04-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-2805: Order filters based on selectivity and cost .. IMPALA-2805: Order filters based on selectivity and cost Added costs to all Exprs, which

[Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

2016-04-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem .. Patch Set 12: (8 comments)

[Impala-CR](cdh5-trunk) IMPALA-1903: Add support for partitioning by TIMESTAMP

2016-04-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1903: Add support for partitioning by TIMESTAMP .. Patch Set 8: I had to rebase for kudu building reasons. Sorry for the mess, reviewers. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-1903: Add support for partitioning by TIMESTAMP

2016-04-07 Thread Jim Apple (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1621 to look at the new patch set (#8). Change subject: IMPALA-1903: Add support for partitioning by TIMESTAMP

[Impala-CR](cdh5-trunk) IMPALA-2459: Implement next_day date/time UDF

2016-04-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/1943/2/be/src/exprs/expr-test.cc File

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help, change coverage options.

2016-04-07 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#5). Change subject: Add -release switch to buildall.sh help, change coverage options.

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help.

2016-04-07 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#4). Change subject: Add -release switch to buildall.sh help. .. Add

[Impala-CR](cdh5-trunk) Add -release switch to buildall.sh help.

2016-04-07 Thread Lars Volker (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2043 to look at the new patch set (#3). Change subject: Add -release switch to buildall.sh help. .. Add

[Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

2016-04-07 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem .. Patch Set 12: Addressing the TODO in IsDfsPath so that it returns the correct values for

[Impala-CR](cdh5-trunk) IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

2016-04-07 Thread anujphadke (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1121 to look at the new patch set (#12). Change subject: IMPALA-1850 Allow fs.defaultFS to be set to a non-HDFS filesystem

[Impala-CR](cdh5-trunk) IMPALA-1661: Netezza compatibility functions: strings

2016-04-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1661: Netezza compatibility functions: strings .. Patch Set 4: Hi Zuo, have you had time to address Sailesh's comments? Let me know if you need help with

[Impala-CR](cdh5-trunk) Add 10 minute timeout to all end-to-end tests

2016-04-07 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Add 10 minute timeout to all end-to-end tests .. Patch Set 2: > We'd need to be sure to use the upper bound value for all our test > jobs. For example, ASAN and

[Impala-CR](cdh5-trunk) Add 10 minute timeout to all end-to-end tests

2016-04-07 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Add 10 minute timeout to all end-to-end tests .. Patch Set 2: > Casey, I'm thinking that a time based timeout could cause > instability. Basically every test