[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3776: fix 'describe formatted' for Avro tables

2016-06-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. Patch Set 1: I kicked of a private test run on Jenkins and will update here once it's finished. -- To

[Impala-CR](cdh5-2.6.0 5.8.0) IMPALA-3776: fix 'describe formatted' for Avro tables

2016-06-22 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/3466 Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. IMPALA-3776: fix 'describe formatted' for Avro tables For Avro

[Impala-CR](cdh5-trunk) IMPALA-2428: Support multiple-character string as the field delimiter

2016-06-22 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has posted comments on this change. Change subject: IMPALA-2428: Support multiple-character string as the field delimiter .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/3314/4//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-06-22 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/3213/2/be/src/exprs/expr-test.cc File

[Impala-CR](cdh5-trunk) IMPALA-889: Add support for ISO-SQL trim()

2016-06-22 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#3). Change subject: IMPALA-889: Add support for ISO-SQL trim() .. IMPALA-889: Add support for ISO-SQL trim() Add support for an ISO-SQL compliant trim() function. Syntax: select

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3753: Disable create table test for old aggs and joins .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3430/2//COMMIT_MSG

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

2016-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#17). Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. IMPALA-3201: headers and reservation logic for new buffer pool This patch implements the core

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

2016-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 15: (43 comments)

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-22 Thread Taras Bobrovytsky (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3430 to look at the new patch set (#2). Change subject: IMPALA-3753: Disable create table test for old aggs and joins

[Impala-CR](cdh5-trunk) IMPALA-3201: headers and reservation logic for new buffer pool

2016-06-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: headers and reservation logic for new buffer pool .. Patch Set 15: (43 comments) Focussed on the headers. I don't see anything major needing to be

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 14: Code-Review+1 Carry Sailesh's +1 -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3343 to look at the new patch set (#14). Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 4: (3 comments) In this patch, we are not differentiating between the result when

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 13: (1 comment) I added a section in commit message. Is it enough for explain the

[Impala-CR](cdh5-trunk) IMPALA-3729: batch size=1 coverage for avro scanner

2016-06-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3729: batch_size=1 coverage for avro scanner .. Patch Set 2: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. IMPALA-3762: Download Python requirements before they are needed. This is needed for

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 1: Code-Review+2 Verified+1 Carry from https://gerrit.cloudera.org/#/c/3426/ -- To

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3452 Change subject: IMPALA-3762: Download Python requirements before they are needed. .. IMPALA-3762: Download Python requirements before they

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Abandoned Abandoning to make a new submit without a -1 from the fake GVM so I can submit this through

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: Verified+1 I agree this is verified. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: Verified+1 verified in private build -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3220/4/be/src/codegen/llvm-codegen.cc

[Impala-CR](cdh5-trunk) IMPALA-3772: Fix admission control flaky stress test

2016-06-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/3450 Change subject: IMPALA-3772: Fix admission control flaky stress test .. IMPALA-3772: Fix admission control flaky stress test The

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 13: Code-Review+1 (1 comment) I think you missed this the last time: "Could

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new patch set (#13). Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. IMPALA-3575: Add retry to backend connection request and rpc timeout This patch adds a

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 12: (3 comments)

[Impala-CR](cdh5-trunk) IMPALA-3764: fuzz test HDFS scanners

2016-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3764: fuzz test HDFS scanners .. IMPALA-3764: fuzz test HDFS scanners This adds a test that performs some simple fuzz testing of HDFS scanners. It creates

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 12: (3 comments) Could you also just briefly explain in the CR what the

[Impala-CR](cdh5-trunk) IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads

2016-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads .. Patch Set 6: I ran the tests locally. However I couldn't run the exhaustive

[Impala-CR](cdh5-trunk) IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads

2016-06-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads .. Patch Set 6: Code-Review+2 Looks good to me. Please just make sure you've rerun the new

[Impala-CR](cdh5-2.6.0 5.8.0) CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema()

2016-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema() .. Patch Set 2: Core tests passed:

[Impala-CR](cdh5-2.6.0 5.8.0) CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema()

2016-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. Change subject: CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema() .. CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema() In

[Impala-CR](cdh5-2.6.0 5.8.0) CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema()

2016-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3446

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new patch set (#12). Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. IMPALA-3575: Add retry to backend connection request and rpc timeout This patch adds a

[Impala-CR](cdh5-trunk) IMPALA-2428: Support multiple-character string as the field delimiter

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2428: Support multiple-character string as the field delimiter .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/3314/4//COMMIT_MSG Commit

[Impala-CR](cdh5-2.6.0 5.8.0) CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema()

2016-06-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema() .. Patch Set 1: Code-Review+2 Gatekeeper approval for 2.6. -- To view, visit

[Impala-CR](cdh5-2.6.0 5.8.0) CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema()

2016-06-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: CDH-41511: Fix the preconditions check in HdfsTable#setAvroSchema() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3446 To

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 11: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3401 To unsubscribe,

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. IMPALA-3637,IMPALA-3636: refactor codegen constant replacement Merge the disparate codegen

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 5: (3 comments)

[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins

2016-06-22 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3753: Disable create table test for old aggs and joins .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 25: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-1766: Misc. statistical functions. Implemented aggregate corr().

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-1766: Misc. statistical functions. Implemented aggregate corr(). .. Patch Set 1: > > Abdur, are you still interested in working on this? > > Jim, i have

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 5: (3 comments)

[Impala-CR](cdh5-trunk) IMPALA-3575: Add retry to backend connection request and rpc timeout

2016-06-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout .. Patch Set 11: (2 comments)

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: Running a private build and test job now. -- To view, visit

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: GVMs going haywire -- To view, visit http://gerrit.cloudera.org:8080/3426 To

[Impala-CR](cdh5-trunk) IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads

2016-06-22 Thread Bharath Vissapragada (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3313 to look at the new patch set (#6). Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads

[Impala-CR](cdh5-trunk) IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads

2016-06-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads .. Patch Set 5: (3 comments)

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-06-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 3: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3762: Download Python requirements before they are needed.

2016-06-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3762: Download Python requirements before they are needed. .. Patch Set 2: Build failed: http://sandbox.jenkins.cloudera.com/job/mikeb-gvm/34/ --