Re: Location of developers documentation

2016-07-20 Thread Tom White
On Wed, Jul 20, 2016 at 4:56 AM, Dimitris Tsirogiannis wrote: > Hi community, > > We need to move our developer documentation to a proper location. > Currently, it's in Cloudera's internal wiki and in the wiki pages of the > Cloudera Impala git repo ( > https://github.com/cloudera/Impala/wiki/Cont

[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running .. IMPALA-3779: Disable cache pool reader thread when HDFS isn't running When

[Impala-CR](cdh5-trunk) IMPALA-3779: Disable cache pool reader thread when HDFS isn't running

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3779: Disable cache pool reader thread when HDFS isn't running .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3577 To u

[Impala-CR](cdh5-trunk) IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-07-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3662/1/be/src/service/impala-

[Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py

2016-07-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/3687 Change subject: IMPALA-3886: Improve log of pip_download.py .. IMPALA-3886: Improve log of pip_download.py pip_download.py prints the foll

[Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py

2016-07-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3886: Improve log of pip_download.py .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3687/1/infra/python/deps/pip_download.

[Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py

2016-07-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3886: Improve log of pip_download.py .. Patch Set 1: (1 comment) Thanks for the review, uploaded PS2. http://gerrit.cloudera.org:8080/#/c/3687/1/infra/pyt

[Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py

2016-07-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3886: Improve log of pip_download.py .. Patch Set 2: Code-Review+2 +2 from Sailesh. -- To view, visit http://gerrit.cloudera.org:8080/3687 To unsubscribe,

[Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py

2016-07-20 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3687 to look at the new patch set (#2). Change subject: IMPALA-3886: Improve log of pip_download.py .. IMPALA-3886: Imp

Re: Location of developers documentation

2016-07-20 Thread Jim Apple
I think Tom's points are correct. Another option would be plain text or markdown files inside the git repo. Those would be harder to update, but then would have review for developer docs changes, which might be nice. FWIW, right now getting a wiki login requires asking for one on this mailing lis

Re: Location of developers documentation

2016-07-20 Thread Tim Armstrong
I also think the wiki is the best approach. On Wed, Jul 20, 2016 at 8:55 AM, Jim Apple wrote: > I think Tom's points are correct. > > Another option would be plain text or markdown files inside the git > repo. Those would be harder to update, but then would have review for > developer docs chang

[Impala-CR](cdh5-trunk) IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-07-20 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3662/1/be/src/service/impala-

Re: Location of developers documentation

2016-07-20 Thread Marcel Kornacker
A lot of our developer docs are Google docs, which facilitate commenting, and it would be good to keep it that way. Should we link to those docs from the Apache Impala wiki? On Wed, Jul 20, 2016 at 9:06 AM, Tim Armstrong wrote: > I also think the wiki is the best approach. > > On Wed, Jul 20, 20

[Impala-CR](cdh5-trunk) PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/3686 Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. PREVIEW: IMPALA-2550 Introduce query-wide execution context

Request for feedback: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Lars Volker
Hi all, I started drafting a header file for a query-wide QueryExecState class here: https://gerrit.cloudera.org/#/c/3686/2 It's not much and I couldn't figure out how much of the overall changes needed for RPC batching should be included in this change. Most notably we might want to replace Frag

[Impala-CR](cdh5-trunk) IMPALA-3201: HEADER ONLY: buffer pool

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3688 Change subject: IMPALA-3201: HEADER ONLY: buffer pool .. IMPALA-3201: HEADER ONLY: buffer pool Change-Id: Id771dea2eb4c1aa13c30d59e8b184

Re: Request for feedback: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Henry Robinson
Could you say something about the use cases you're trying to address? That'll make it easier to review the design. On 20 July 2016 at 10:08, Lars Volker wrote: > Hi all, > > I started drafting a header file for a query-wide QueryExecState class > here: https://gerrit.cloudera.org/#/c/3686/2 > >

[Impala-CR](cdh5-trunk) IMPALA-3201: HEADER ONLY: buffer pool

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: HEADER ONLY: buffer pool .. Patch Set 1: This is an updated header where was have a new InMemPageHandle abstraction that guarantees that the refere

[Impala-CR](cdh5-trunk) IMPALA-2979: Fix scheduling on remote hosts

2016-07-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2979: Fix scheduling on remote hosts .. Patch Set 27: (8 comments) http://gerrit.cloudera.org:8080/#/c/2200/24/be/src/scheduling/simple-scheduler.cc F

[Impala-CR](cdh5-trunk) IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-07-20 Thread Attila Jeges (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3662 to look at the new patch set (#3). Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys ...

Re: Request for feedback: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Lars Volker
Sure. Currently we duplicate state in fragment instances of a single query, for example each plan fragment executor creates its own descriptor table, which could actually be shared among all fragment instances. For RPC batching (IMPALA-2550) we will transmit the descriptor table only once, and it s

[Impala-CR](cdh5-trunk) PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 2: (2 comments) Thanks for working on this, looking forward to the final result. Some

[Impala-CR](cdh5-trunk) IMPALA-3201: HEADER ONLY: buffer pool

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: HEADER ONLY: buffer pool .. Patch Set 1: One point that I alluded to in the previous comment is that passing an InMemPageHandle allows compile-time

[Impala-CR](cdh5-trunk) IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()

2016-07-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-g

[Impala-CR](cdh5-trunk) IMPALA-3859: Don't log file data on parse errors

2016-07-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3859: Don't log file data on parse errors .. Patch Set 1: (1 comment) Agree removing that logging and only logging filename and offset is the right thing.

[Impala-CR](cdh5-trunk) IMPALA-3804: Push per-split filtering into scanners

2016-07-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3804: Push per-split filtering into scanners .. Patch Set 2: Ping, just in case you missed my comments from July 12. Would be good to get this one squared aw

Re: Request for feedback: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Marcel Kornacker
Regarding FragmentExecState: We could possibly do away with that and migrate whatever pieces of it are still needed into RuntimeState (and possibly rename RuntimeState to make it conform to the naming hierarchy). FragmentExecState is a bit of a misnomer at the moment anyway, because it's really Fr

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3637/2/be/src/exec/kudu-scan-no

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verif

[Impala-CR](cdh5-trunk) IMPALA-3804: Push per-split filtering into scanners

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3804: Push per-split filtering into scanners .. Patch Set 2: Yep, haven't forgotten. Checking my working given Sailesh's observations about how the Parq

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 7: Ping. It would be good to find a way to move forward with this even though there'

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 7: Sorry, let me get back to it later today. -- To view, visit http://gerrit.cloudera.

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: The data loading kept failing as hadoop fs -put ... kept getting killed. -- To view, vi

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 7: No prob, just wanted to make sure it wasn't lost in the shuffle. -- To view, vis

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3637/2/be/src/exec/kudu-scan-node.cc

Upstream switch from github to ASF git

2016-07-20 Thread Jim Apple
Today, Impala's official source is at https://github.com/cloudera/Impala/. As of Monday, July 25, it will be at https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git. Unfortunately, for all of your in-progress patches in gerrit, you will either have to (a) Abandon them and reprocue them

Re: Upstream switch from github to ASF git

2016-07-20 Thread Sailesh Mukil
On Wed, Jul 20, 2016 at 11:54 AM, Jim Apple wrote: > Today, Impala's official source is at > https://github.com/cloudera/Impala/. As of Monday, July 25, it will be > at > https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git. > > Unfortunately, for all of your in-progress patches in gerr

Re: Upstream switch from github to ASF git

2016-07-20 Thread Jim Apple
We have got to fix the second one, since gerrit is what our "First Steps" document said to name the existing gerrit remote, and git is not great at remotes with the same name and different locations. On Wed, Jul 20, 2016 at 12:07 PM, Sailesh Mukil wrote: > On Wed, Jul 20, 2016 at 11:54 AM, Jim Ap

[Impala-CR](cdh5-trunk) IMPALA-2979: Fix scheduling on remote hosts

2016-07-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2979: Fix scheduling on remote hosts .. Patch Set 27: (8 comments) http://gerrit.cloudera.org:8080/#/c/2200/24/be/src/scheduling/simple-scheduler.cc F

[Impala-CR](cdh5-trunk) IMPALA-3764: fuzz test HDFS scanners

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-3764: fuzz test HDFS scanners .. IMPALA-3764: fuzz test HDFS scanners This adds a test that performs some simple fuzz testing of HDFS scanners. It creates a

[Impala-CR](cdh5-trunk) IMPALA-3764: fuzz test HDFS scanners

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764: fuzz test HDFS scanners .. Patch Set 5: (22 comments) http://gerrit.cloudera.org:8080/#/c/3448/5/be/src/exec/base-sequence-scanner.cc File be/src/e

[Impala-CR](cdh5-trunk) IMPALA-3159: impala-shell does not accept wildcard or SAN certificates

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN certificates .. Patch Set 8: Code-Review+2 Still lgtm. Anything else holding this up? -- To view, v

[Impala-CR](cdh5-trunk) IMPALA-3764: fuzz test HDFS scanners

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3764: fuzz test HDFS scanners .. IMPALA-3764: fuzz test HDFS scanners This adds a test that performs some simple fuzz testing of HDFS scanners. It creates a

[Impala-CR](cdh5-trunk) IMPALA-3764: fuzz test HDFS scanners

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764: fuzz test HDFS scanners .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3448/6/tests/query_test/test_scanners_fuzz.py File tests/qu

[Impala-CR](cdh5-trunk) IMPALA-3764: fuzz test HDFS scanners

2016-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3764: fuzz test HDFS scanners .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3448/6/tests/query_test/test_scanners_fuzz.py File tests/qu

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verif

[Impala-CR](cdh5-trunk) PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/3686/2/be/src/runtime/query-exec-

[Impala-CR](cdh5-trunk) IMPALA-3886: Improve log of pip download.py

2016-07-20 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3886: Improve log of pip_download.py .. Patch Set 2: Code-Review+2 This is great! -- To view, visit http://gerrit.cloudera.org:8080/3687 To unsubscr

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. Patch Set 2: (1 comment) I spent a while coming up with something that is OK for factoring th

[Impala-CR](cdh5-trunk) Adjust ASF push script names to match our repo setup.

2016-07-20 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/3702 Change subject: Adjust ASF push script names to match our repo setup. .. Adjust ASF push script names to match our repo setup. Our gerrit re

[Impala-CR](cdh5-trunk) IMPALA-2700: ASCII NUL characters are doubled on insert into text tables

2016-07-20 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/3703 Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into text tables .. IMPALA-2700: ASCII NUL characters are doubled o

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.

[Impala-CR](cdh5-trunk) IMPALA-3875: Set thrift socket timeout before any connection

2016-07-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new change for review. http://gerrit.cloudera.org:8080/3707 Change subject: IMPALA-3875: Set thrift socket timeout before any connection .. IMPALA-3875: Set thrift socket timeout before any connection

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verif

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: GVM preemptively aborted due to hitting IMPALA-3470 -- To view, visit http://gerrit.clo

[Impala-CR](cdh5-trunk) IMPALA-3875: Set thrift socket timeout before any connection

2016-07-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3875: Set thrift socket timeout before any connection .. Patch Set 1: this is client side.. will look at server side as well -- To view, visit http://gerrit

Re: Location of developers documentation

2016-07-20 Thread Henry Robinson
Seems reasonable, but I propose we scope that only to design documents (which require revisions and comments). FWIW, Kudu includes building-from-source instructions on their website (which I think is nicely done): http://kudu.apache.org/docs/installation.html#_build_from_source I'm happy with mos

Re: Location of developers documentation

2016-07-20 Thread Marcel Kornacker
How about we scope that to everything that needs revisions/comments? On Wed, Jul 20, 2016 at 3:23 PM, Henry Robinson wrote: > Seems reasonable, but I propose we scope that only to design documents > (which require revisions and comments). > > FWIW, Kudu includes building-from-source instructions

Re: Location of developers documentation

2016-07-20 Thread Jim Apple
I think that's overkill. There are few documents that don't need comments (I really tried to come up with one. Something written in Linear A?) I also don't think Google docs are really ideal for a shared, long-lived document managed by a diverse community. 1. The revision history tooling is weak.

[Impala-CR](cdh5-trunk) IMPALA-3875: Set thrift socket timeout before any connection

2016-07-20 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3875: Set thrift socket timeout before any connection .. Patch Set 1: I think we should add timeout for server transport here, http://github.mtv.cloudera.com

Re: Location of developers documentation

2016-07-20 Thread Jim Apple
Oh, and, FWIW, I think Google docs are reasonable for design proposals, because I expect those to be somewhat short-lived: once the proposal is accepted, the design may very well stray from it based on unforeseen implementation constraints, and we probably don't expect contributors who do the imple

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-20 Thread Matthew Jacobs (Code Review)
Hello David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3637 to look at the new patch set (#3). Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads ...

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. Patch Set 3: Ok, so I tried to refactor the exit/cleanup logic to be a bit more sane. The ext

[Impala-CR](cdh5-trunk) IMPALA-3857: KuduScanNode race on returning "optional" threads

2016-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: KuduScanNode race on returning "optional" threads .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3637/2/be/src/exec/kudu-scan-nod

[Impala-CR](cdh5-trunk) IMPALA-1683: Allow REFRESH on a single partition

2016-07-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-1683: Allow REFRESH on a single partition .. Patch Set 8: (1 comment) Carrying forward David's +1 http://gerrit.cloudera.org:8080/#/c/3385/8/fe/src/mai

[Impala-CR](cdh5-trunk) IMPALA-1683: Allow REFRESH on a single partition

2016-07-20 Thread Bikramjeet Vig (Code Review)
Hello David Knupp, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3385 to look at the new patch set (#9). Change subject: IMPALA-1683: Allow REFRESH on a single partition ..

[Impala-CR](cdh5-trunk) Adjust ASF push script names to match our repo setup.

2016-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Adjust ASF push script names to match our repo setup. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3702/1/bin/push_to_asf.py File bin/push_t

Re: Location of developers documentation

2016-07-20 Thread Marcel Kornacker
I meant this really for documents where we expect a good amount of discussion. Design docs and proposals are certainly in that category. Is there anything in that category that you would like to exclude? On Wed, Jul 20, 2016 at 3:35 PM, Jim Apple wrote: > I think that's overkill. There are few d

Re: Location of developers documentation

2016-07-20 Thread Henry Robinson
Google docs only work in my opinion if the following are true: 1. People who want to read and comment on them can do so without requesting permission 2. Ownership is not tied to one person, so that if someone stops contributing to Impala, the rest of the contributors can still make changes to the

[Impala-CR](cdh5-trunk) PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3686/2/be/src/runtime/query-exe

Re: Location of developers documentation

2016-07-20 Thread Marcel Kornacker
As far as I know, you can give edit rights to anyone with the link. On Wed, Jul 20, 2016 at 4:30 PM, Henry Robinson wrote: > Google docs only work in my opinion if the following are true: > > 1. People who want to read and comment on them can do so without requesting > permission > 2. Ownership i

[Impala-CR](cdh5-trunk) PREVIEW: IMPALA-2550 Introduce query-wide execution context.

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3686/2/be/src/service/fragment-mgr

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.cc Fi

Re: Location of developers documentation

2016-07-20 Thread Jim Apple
I think it is reasonable for contributors to use Google Docs for coordinating short-lived, heavily commented documents. However, I don't think Dimitris was referring to those sort of things. On Wed, Jul 20, 2016 at 4:18 PM, Marcel Kornacker wrote: > I meant this really for documents where we exp

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.c

[Impala-CR](cdh5-trunk) IMPALA-3336: qgen: do not randomly generate query options (workaround)

2016-07-20 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/3712 Change subject: IMPALA-3336: qgen: do not randomly generate query options (workaround) .. IMPALA-3336: qgen: do not randomly generate qu

[Impala-CR](cdh5-trunk) IMPALA-3892: qgen: always run Impala with -convert legacy hive parquet utc timestamps=true

2016-07-20 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/3713 Change subject: IMPALA-3892: qgen: always run Impala with -convert_legacy_hive_parquet_utc_timestamps=true .. IMPALA-3892: qgen: always

[Impala-CR](cdh5-trunk) IMPALA-3892: qgen: always run Impala with -convert legacy hive parquet utc timestamps=true

2016-07-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3892: qgen: always run Impala with -convert_legacy_hive_parquet_utc_timestamps=true .. Patch Set 1: I've been using this patch locally for months. -- T

[Impala-CR](cdh5-trunk) IMPALA-3336: qgen: do not randomly generate query options (workaround)

2016-07-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3336: qgen: do not randomly generate query options (workaround) .. Patch Set 1: I tested that disabling this a while back allows the query generator to r

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3401/7/be/src/codegen/constant-repl

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Kathy Sun (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3664 to look at the new patch set (#5). Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. IMPALA-3

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Kathy Sun (Code Review)
Kathy Sun has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3664/4/be/src/service/impala-http-handler.cc Fil

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3401/6/be/src/codegen/constant-repl

[Impala-CR](cdh5-trunk) IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()

2016-07-20 Thread Michael Ho (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3630 to look at the new patch set (#5). Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() .

[Impala-CR](cdh5-trunk) IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG Commit Message: PS

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. IMPALA-3674: Lazy materialization of LLVM module bitcode. Previously, each fragment usin

[Impala-CR](cdh5-trunk) IMPALA-3674: Lazy materialization of LLVM module bitcode.

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3220 To unsubscribe,

[Impala-CR](cdh5-trunk) Enable TPC-H workload for Kudu tables

2016-07-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables .. Patch Set 5: (3 comments) Why add tpch-kudu-q*.test? The queries should be identical to the already existing TPC-H qu

[Impala-CR](cdh5-trunk) Enable TPC-H workload for Kudu tables

2016-07-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3633/5/testdata/workloads/tpch/queries/tpch-kudu-q1.test

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-07-20 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#33). Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. Using SSSE3/AVX2 int

[Impala-CR](cdh5-trunk) IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2.

2016-07-20 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. .. Patch Set 32: (9 comments) http://gerrit.cloudera.org:8080/#/c/3081/32/be/src/benchmarks

[Impala-CR](cdh5-trunk) IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close()

2016-07-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() .. Patch Set 5: Code-Review+2 http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3754

Re: Location of developers documentation

2016-07-20 Thread Dimitris Tsirogiannis
By developer documentation I meant anything that is currently under the "For Developers" section in the wiki ( https://github.com/cloudera/Impala/wiki). Dimitris On Wed, Jul 20, 2016 at 4:40 PM, Jim Apple wrote: > I think it is reasonable for contributors to use Google Docs for > coordinating s

Re: Location of developers documentation

2016-07-20 Thread Jim Apple
With my Cloudera hat on, I noticed that I can't share docs with the whole world from my cloudera.com Google account. It's possible others are in the same boat and will need to make special Google accounts just to comment on docs even when contributing under the umbrella of their employer. However,

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3664 To unsubscribe, visit h

[Impala-CR](cdh5-trunk) IMPALA-3716: Add Memory Tab in query's Details page

2016-07-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3716: Add Memory Tab in query's Details page .. IMPALA-3716: Add Memory Tab in query's Details page Add a QueryMemoryHandler and register it t

Re: Issues with tests in Release-mode Impala build

2016-07-20 Thread Valencia Serrao
Hi Tim, Thank you for the insight on the issues. 1. BE test -issue: benchmark-test hangs As you suggested, I increased the "batch_size" value to upto 12500, however, the sw.ElapsedTime() does not increase inside the while and again gets caught up in an infinite loop. The optimization lev

[Impala-CR](cdh5-trunk) IMPALA-3611: track unused Disk IO buffer memory

2016-07-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3611: track unused Disk IO buffer memory .. Patch Set 9: (9 comments) http://gerrit.cloudera.org:8080/#/c/3246/9/be/src/runtime/disk-io-mgr.cc File be/src/ru

  1   2   >