[Impala-CR](cdh5-trunk) IMPALA-1702: Check all referenced tables, including those without associated TupleDescriptors, for duplicated table IDs.

Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Check all referenced tables, including those without associated TupleDescriptors, for duplicated table IDs. .. Patch Set 6: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-1702: Check all referenced tables, including those without associated TupleDescriptors, for duplicated table IDs.

Alex Behm has restored this change. Change subject: IMPALA-1702: Check all referenced tables, including those without associated TupleDescriptors, for duplicated table IDs. .. Restored I think we should get this patch in for

[Impala-ASF-CR] Bump Impala version to 2.8

Harrison Sheinblatt has submitted this change and it was merged. Change subject: Bump Impala version to 2.8 .. Bump Impala version to 2.8 Change-Id: I5b147dee9bb7fcb159e98a008c01659a4cb7473b Reviewed-on:

[Impala-ASF-CR] Bump Impala version to 2.8

Alex Behm has posted comments on this change. Change subject: Bump Impala version to 2.8 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4170 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

Alex Behm has posted comments on this change. Change subject: IMPALA-1654: Partition expr in DDL operations. .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Internal Jenkins has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4161 To

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. IMPALA-4020: Handle external conflicting changes to HMS gracefully Currently

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

Amos Bird has posted comments on this change. Change subject: IMPALA-1654: Partition expr in DDL operations. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

Amos Bird has uploaded a new patch set (#3). Change subject: IMPALA-1654: Partition expr in DDL operations. .. IMPALA-1654: Partition expr in DDL operations. This commit handles partition related DDL in a more general way. We

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/4/tests/metadata/test_ddl.py File

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Kathy Sun has uploaded a new patch set (#17). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

Re: Why not use shared_ptr or other ref counting to handle RowBatch's auxilliary memory?

Thanks for the explanation. It now makes a lot sense to me. This may deverve being added to the document so that new comers like me would understand the reason behind the scene. Tim Armstrong writes: > There are various reasons - mainly we want more control over memory usage > and accounting

[Impala-ASF-CR] Bump Impala version to 2.8

Internal Jenkins has posted comments on this change. Change subject: Bump Impala version to 2.8 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4170 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Internal Jenkins has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4066 To

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 16: This patch add a SystemTableScanner and its subclass MetricScanner to

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

Kathy Sun has uploaded a new patch set (#16). Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. IMPALA-4024: Add "system" database and expose Impala metrics as a table This is to expose

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/4/tests/metadata/test_ddl.py File

[Impala-ASF-CR] IMPALA-1654: Partition expr in DDL operations.

Alex Behm has posted comments on this change. Change subject: IMPALA-1654: Partition expr in DDL operations. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool .. Patch Set 8: (25 comments)

[Impala-ASF-CR] IMPALA-3201: reservation implementation for new buffer pool

Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-3201: reservation implementation for new buffer pool .. IMPALA-3201: reservation implementation for new buffer pool This patch implements the reservation

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: (1 comment) > This is a bug, but not worth holding up the build for. This is

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: > > (12 comments) > > > > Mostly style comments, but one question about

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: This is a bug, but not worth holding up the build for. This is an edge

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Dan Hecht has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: > (12 comments) > > Mostly style comments, but one question about disabling

Re: scoped_ptr -> unique_ptr?

On 31 August 2016 at 11:55, Marcel Kornacker wrote: > Generally, we want to move away from implicitly-managed memory (d'tor > frees) to explicitly, centrally managed memory (in MemPools, and > d'tors become no-ops). > Can you clarify this a bit - particularly how a d'tor

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

Henry Robinson has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 2: (1 comment) Were you able to reproduce the test failure? Any evidence that this fixes the

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

Henry Robinson has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 4: (15 comments) Refactoring looks sensible. Does the stress test run compute

Re: [DISCUSS] Branching for a release soon?

That might be the place for release candidates. I added KEYS to https://dist.apache.org/repos/dist/release/incubator/impala/KEYS now, following http://incubator.apache.org/guides/releasemanagement.html On Wed, Aug 31, 2016 at 4:37 PM, Jim Apple wrote: > Thanks, Tom! > > I

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

Michael Brown has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4155/4/tests/metadata/test_ddl.py File

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

Alex Behm has uploaded a new patch set (#5). Change subject: IMPALA-3905: Add single-threaded scan node. .. IMPALA-3905: Add single-threaded scan node. Adds a new single-threaded scan node HdfsScanNodeMt that materializes

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

Alex Behm has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4113/3/be/src/exec/hdfs-scan-node-mt.cc File

Re: [DISCUSS] Branching for a release soon?

Thanks, Tom! I have added my key to https://dist.apache.org/repos/dist/dev/incubator/impala/KEYS. Committers who are interested in acting as release managers at some point might be interested in getting keys, joining the apache web of trust, putting the keys on home.apache.org, etc. The

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

Juan Yu has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 2: Code-Review+1 Carry Sailesh's +1 -- To view, visit http://gerrit.cloudera.org:8080/4080 To

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4080 to look at the new patch set (#2). Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. IMPALA-3912:

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

Juan Yu has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4080/1/be/src/service/fragment-mgr.cc File

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. .. Patch Set 4: Michael I found a few more bugs by running this test in a loop on exhaustive. Needed some

[Impala-ASF-CR] IMPALA-3491: Use unique database fixture in test ddl.py.

Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4155 to look at the new patch set (#4). Change subject: IMPALA-3491: Use unique database fixture in test_ddl.py. ..

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4161 To

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: (12 comments) Mostly style comments, but one question about disabling

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 12: PS11->12: ran the patch through clang-format and added a clang-format option for

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

Michael Brown has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is to split out

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

Alex Behm has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 1: (15 comments) Had a pass to get an understanding of the various issues. Most

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4080/1/be/src/service/fragment-mgr.cc

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 13: Code-Review+2 Rebase. Carry +2. -- To view, visit

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4080 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

Alex Behm has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4188 To unsubscribe,

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4188/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3567: move ExecOption profile helpers to RuntimeProfile

Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4188 to look at the new patch set (#2). Change subject: IMPALA-3567: move ExecOption profile helpers to RuntimeProfile ..

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Alex Behm has posted comments on this change. Change subject: Move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: Code-Review+1 (1 comment) Changes make sense to me.

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. IMPALA-4049: fix empty batch handling NLJ build side Memory from the build side of a nested

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Internal Jenkins has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: Move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: I meant https://gerrit.cloudera.org/3873 sorry -- To view, visit

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has posted comments on this change. Change subject: Move ExecOption profile helpers to RuntimeProfile .. Patch Set 1: This is a prerequisite for making some of the requested changes to

[Impala-ASF-CR] Move ExecOption profile helpers to RuntimeProfile

Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4188 Change subject: Move ExecOption profile helpers to RuntimeProfile .. Move ExecOption profile helpers to RuntimeProfile This is

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4066 to look at the new patch set (#12). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: Code-Review+2 (6 comments) Carry +2

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

Tim Armstrong has abandoned this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4181 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Patch Set 2: Michael Ho pointed out that I was wrong in assuming that the RowDescriptors

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

Michael Ho has posted comments on this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

Lars Volker has posted comments on this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Patch Set 2: Code-Review+1 Thanks for creating the Jira. -- To view, visit

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Sailesh Mukil has uploaded a new patch set (#11). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before this patch,

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 10: (5 comments) looks good, but i'd still like to see the filter swapping

Re: scoped_ptr -> unique_ptr?

Generally, we want to move away from implicitly-managed memory (d'tor frees) to explicitly, centrally managed memory (in MemPools, and d'tors become no-ops). With that in mind, I would limit the amount of effort spent on changing from one implicitly-managed model to another. That said, I'm in

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Bharath Vissapragada has uploaded a new patch set (#6). Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. IMPALA-4020: Handle external conflicting changes to HMS gracefully Currently Catalog

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

Michael Brown has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4187/1/infra/deploy/deploy.py

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. IMPALA-4020: Handle external conflicting changes to HMS gracefully Currently Catalog

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4113/3/be/src/exec/hdfs-scan-node-mt.cc File

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. Patch Set 4: (3 comments)

Re: scoped_ptr -> unique_ptr?

I don't feel that strongly about it but, but I think scoped_ptr/unique_ptr is a useful distinction to document that the pointer isn't movable. I think it contains info both ways: if it's a unique_ptr it means we intend to (sometimes) transfer it, but if it's a scoped_ptr its lifetime is strictly

Re: scoped_ptr -> unique_ptr?

I'm convinced. +1 to moving to ::std::unique_ptr. On Wed, Aug 31, 2016 at 11:22 AM, Henry Robinson wrote: > On 31 August 2016 at 11:16, Jim Apple wrote: > >> Why should we reduce our boost dependency? >> > > Boost will sometimes break subtly (or

Re: scoped_ptr -> unique_ptr?

On 31 August 2016 at 11:16, Jim Apple wrote: > Why should we reduce our boost dependency? > Boost will sometimes break subtly (or unsubtly by changing APIs) between versions, is often not as well tested as stdlib implementations and does not have a standard. If there are

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Dan Hecht has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe, visit

Re: scoped_ptr -> unique_ptr?

Why should we reduce our boost dependency? Do you think there are places where scoped_ptr is used now where you would want to keep it indefinitely if it were part of the standard and not part of boost? On Wed, Aug 31, 2016 at 10:47 AM, Henry Robinson wrote: > We use

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Bharath Vissapragada has uploaded a new patch set (#4). Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. IMPALA-4020: Handle external conflicting changes to HMS gracefully Currently Catalog

[Impala-ASF-CR] IMPALA-4020: Handle external conflicting changes to HMS gracefully

Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4020: Handle external conflicting changes to HMS gracefully .. IMPALA-4020: Handle external conflicting changes to HMS gracefully Currently Catalog

scoped_ptr -> unique_ptr?

We use boost::scoped_ptr everywhere to handle scope-owned heap-allocated objects. C++11 has std::unique_ptr for this. I'd like to get a decision on whether we should start standardising on unique_ptr. This is particularly relevant for new code - should I call it out in code review? The most

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 9: (13 comments)

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

Sailesh Mukil has uploaded a new patch set (#10). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before this patch,

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: Code-Review-2 Started GVO early. -2 to prevent accidental merge. -- To view, visit

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4182 To unsubscribe,

Re: Why not use shared_ptr or other ref counting to handle RowBatch's auxilliary memory?

There are various reasons - mainly we want more control over memory usage and accounting than shared_ptr allows. Generally we avoid shared_ptr in Impala since it makes it harder to reason about when resources are released. E.g. we typically want to know/control exactly when memory is freed up.

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 1: (3 comments) Thanks for the patch! Could you add a test to webserver-test.cc

[Impala-ASF-CR] IMPALA-4049: fix empty batch handling NLJ build side

Tim Armstrong has posted comments on this change. Change subject: IMPALA-4049: fix empty batch handling NLJ build side .. Patch Set 2: (1 comment) It seems like it would be very difficult to trigger without a subplan, but

  1   2   >