[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-03-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2598/1/fe/src/main/java/com/cloudera

[Impala-CR](cdh5-trunk) IMPALA-2805: Order filters based on selectivity and cost

2016-03-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2805: Order filters based on selectivity and cost .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2598/1/fe/src/main/java/com/cloudera/

[Impala-CR](cdh5-trunk) IMPALA-2680: faster memory copy

2016-04-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2680: faster memory copy .. Patch Set 10: @Tim, Can you try using this query https://github.com/cloudera/Impala/blob/cdh5-trunk/testdata/workloads/tar

[Impala-CR](cdh5-trunk) IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism

2016-04-12 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded a new change for review. http://gerrit.cloudera.org:8080/2769 Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism .. IMPALA-1928 : Impala ODBC bad performance with Ke

[Impala-CR](cdh5-trunk) PREVIEW: Basic column-wise slot materialization in Parquet scanner.

2016-04-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: PREVIEW: Basic column-wise slot materialization in Parquet scanner. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/2/be/src/exec/hdfs-p

[Impala-CR](cdh5-trunk) IMPALA-2736: Basic column-wise slot materialization in Parquet scanner.

2016-04-22 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/5/be/src/util/rl

[Impala-CR](cdh5-trunk) IMPALA-3286: Software prefetching for hash table build.

2016-05-01 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3286: Software prefetching for hash table build. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2896/2/be/src/exec/partitioned-hash-jo

[Impala-CR](cdh5-trunk) IMPALA-3452: S3: Disable Impala staging for INSERTs via flag for speedup

2016-05-02 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3452: S3: Disable Impala staging for INSERTs via flag for speedup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2905/1/be/src/exec/h

[Impala-CR](cdh5-trunk) IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism

2016-05-05 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2769/1/be/src/rpc/thrift-cl

[Impala-CR](cdh5-trunk) Add code review feedback

2016-05-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded a new change for review. http://gerrit.cloudera.org:8080/2995 Change subject: Add code review feedback .. Add code review feedback Change-Id: Iad23205f29b3ac13ecfcdbb4b77567f0dea2652b --- M be/src

[Impala-CR](cdh5-trunk) IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism

2016-05-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has uploaded a new patch set (#2). Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism .. IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism On the client side, the w

[Impala-CR](cdh5-trunk) Add code review feedback

2016-05-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has abandoned this change. Change subject: Add code review feedback .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/2995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Mes

[Impala-CR](cdh5-trunk) IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism

2016-05-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/2769/1//COMMIT_MSG Commit

[Impala-CR](cdh5-trunk) Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf

2016-05-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-CR](cdh5-trunk) Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf

2016-05-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf .. Patch Set 1: -Code-Review Just noticed that this query is not valid as

[Impala-CR](cdh5-trunk) Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf

2016-05-10 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf .. Patch Set 1: Also why are the predicates which are part of the join not

[Impala-CR](cdh5-trunk) IMPALA-3480: Add query options for min/max filter sizes

2016-05-11 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3480: Add query options for min/max filter sizes .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2966/4/be/src/runtime/runtime-filter.h

[Impala-CR](cdh5-trunk) IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism

2016-05-12 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2769/2/be/src/rpc/thrift-cl

[Impala-CR](cdh5-trunk) Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf

2016-05-12 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Renamed conjunct_ordering.test to primitive_conjunct_ordering.test in targeted-perf .. Patch Set 1: Query is not valid because the order in the plan doesn't c

[Impala-CR](cdh5-trunk) IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2

2016-05-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has abandoned this change. Change subject: IMPALA-2809: improve ByteSwap with builtin function or SSE or AVX2 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/1813 To unsubscribe, visit http://ge

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-14 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h Fil

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h Fil

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-15 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h Fil

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h Fil

[Impala-CR](cdh5-trunk) Use AVX2 operations to speedup Bloom filters by 10-100%.

2016-06-18 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h Fi

[Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-05 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3566/1//COMMIT_MSG Comm

[Impala-CR](cdh5-trunk) IMPALA-3735: Add per-fragment information to debug webpage

2016-07-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3735: Add per-fragment information to debug webpage .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3323/4/be/src/service/fragment-mgr.

[Impala-CR](cdh5-trunk) IMPALA-3766: Applying LZ4 compression on buffers before spilling

2016-07-06 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3766: Applying LZ4 compression on buffers before spilling .. Patch Set 2: Can you please attach the before and after profiles to IMPALA-3766. -- To

[Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. Patch Set 1: -Verified -- To view, visit http://gerrit.cloudera.org:8080/3566 To uns

[Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. Patch Set 1: Code-Review+1 Verified+1 -- To view, visit http://gerrit.cloudera.org:8

[Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-08 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. Patch Set 1: -Code-Review Verified+1 -- To view, visit http://gerrit.cloudera.org:80

[Impala-CR](cdh5-trunk) IMPALA-3817: Ensure filter hash function is the same on all hardware.

2016-07-12 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3817: Ensure filter hash function is the same on all hardware. .. Patch Set 1: -Verified -- To view, visit http://gerrit.cloudera.org:8080/3566 To uns

[Impala-CR](cdh5-trunk) IMPALA-2328 Parquet scan should use min/max stats

2016-07-12 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2328 Parquet scan should use min/max stats .. Patch Set 1: I tried the patch and hitting some exceptions #0 0x7f8bbb197cc9 in __GI_raise (sig=sig

[Impala-CR](cdh5-trunk) Enable TPC-H workload for Kudu tables

2016-07-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables .. Patch Set 5: (3 comments) Why add tpch-kudu-q*.test? The queries should be identical to the already existing TPC-H qu

[Impala-CR](cdh5-trunk) Enable TPC-H workload for Kudu tables

2016-07-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3633/5/testdata/workloads/tpch/queries/tpch-kudu-q1.test

[Impala-ASF-CR] IMPALA-2932: Extend DistributedPlanner to account for hash table build cost

2016-08-24 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-2932: Extend DistributedPlanner to account for hash table build cost .. Patch Set 3: I kicked off a TPC-H/DS run -- To view, visit http://gerrit.clou