[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2341 To unsubscribe, visit http:/

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Huaisi Xu has submitted this change and it was merged. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() Some TimestampValue converting functions assu

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/2341 To unsubscribe,

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Hello Juan Yu, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2341 to look at the new patch set (#3). Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() ..

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2341/2/be/src/runtime/timestamp-value.h File b

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. Patch Set 2: Code-Review+2 (1 comment) I think we don't need to backport the new API ToUnixTimeInUTC() http:

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Hello Juan Yu, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2341 to look at the new patch set (#2). Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() ..

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. Patch Set 1: I think I made those necessary changes. IMPALA-2190 introduced some new functionalities. you t

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-29 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() .. Patch Set 1: Looks like this change depends on some other commits (IMPALA-2190 and maybe more), could you con

[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime()

2016-02-28 Thread Huaisi Xu (Code Review)
Hello Juan Yu, Internal Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/2341 to review the following change. Change subject: IMPALA-2914: Fix DCHECK Check failed: HasDateOrTime() ..