Re: NGP: Prototyping

2007-11-23 Thread Thomas Mueller
Hi, > > Just curious, did you run some tests, is it faster than using > > RandomAccessFile.read? > > I'm planning to... It would be really nice to map the entire journal > file (or the part that already exists when a repository is started) > into memory for direct access. In theory this should red

DbDataStore implementation

2007-11-23 Thread Esteban Franqueiro
Hi Thomas. I've been reviewing the new DbDataStore and have a few comments about it. * doesn't synchronizing the addRecord() method, and using only one connection defeat one of the purposes of the data store of allowing maximum concurrency? * making the SQL strings private and not initializing

[jira] Commented: (JCR-73) Improve Javadoc documentation

2007-11-23 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545109 ] Esteban Franqueiro commented on JCR-73: --- The sentence "The commit may haven implicitly in case the Content Reposito

[jira] Commented: (JCR-73) Improve Javadoc documentation

2007-11-23 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545108 ] Esteban Franqueiro commented on JCR-73: --- http://jackrabbit.apache.org/doc/arch/operate/startup.html says the defaul

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545070 ] Esteban Franqueiro commented on JCR-1232: - To cope with the existing code, shouldn't be public interface ItemId

[jira] Updated: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated JCR-1232: Attachment: nodeId.patch What about this: public interface ItemId { boolean denotesNode(); }

[jira] Updated: (JCR-1213) UUIDDocId cache does not work properly because of weakReferences in combination with new instance for combined indexreader

2007-11-23 Thread Ard Schrijvers (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ard Schrijvers updated JCR-1213: Attachment: JCR-1213.patch This is a patch solving the WeakReferences and improving the ChildAxisQuer

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Stefan Guggisberg (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545042 ] Stefan Guggisberg commented on JCR-1232: while i do share tom's concerns regarding code duplication in general

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Esteban Franqueiro (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545041 ] Esteban Franqueiro commented on JCR-1232: - If getUUID() is used by applications, then I would say a behavior li

[jira] Commented: (JCR-1166) JCR2SPI does not provide actual size on RangeIterator.getSize()

2007-11-23 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545021 ] angela commented on JCR-1166: - noe... you get the size immediately. but it may not be totally accurate if nodes are remove

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545015 ] Thomas Mueller commented on JCR-1232: - > public class UUIDNodeId extends UUID implements NodeId { ... } Cool! (Or

[jira] Commented: (JCR-1198) Issue while loading list of classes at that path itself.

2007-11-23 Thread Christophe Lombart (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544991 ] Christophe Lombart commented on JCR-1198: - Concerning the Query object, it has to manage the node name to make

[jira] Commented: (JCR-1198) Issue while loading list of classes at that path itself.

2007-11-23 Thread Kaizer (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544986 ] Kaizer commented on JCR-1198: - I had changed the getObjects method to check if the parent path is "/" and if so, set it to

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544984 ] Jukka Zitting commented on JCR-1232: Thomas: > Create a interface UUID a interface I like the idea, but it would

Re: NGP: Prototyping

2007-11-23 Thread Jukka Zitting
Hi, On Nov 23, 2007 10:23 AM, Thomas Mueller <[EMAIL PROTECTED]> wrote: > In any case, I wouldn't architect Jackrabbit around memory mapped > files. I guess you're right, thanks for the background. I was hoping to offload paging features (when to load a part of the file to memory and when to dis

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544975 ] Marcel Reutegger commented on JCR-1232: --- +1 > Merge UUID to NodeId > > > Ke

[jira] Resolved: (JCR-1225) ReadOnlyIndexReaders are re-created on every access

2007-11-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-1225. --- Resolution: Fixed Fix Version/s: 1.4 ReadOnlyIndexReader instances are now cached in Abs

[jira] Commented: (JCR-1166) JCR2SPI does not provide actual size on RangeIterator.getSize()

2007-11-23 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545012 ] Julian Reschke commented on JCR-1166: - But that would still require to completely iterate through what the SPI imp

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544990 ] Thomas Mueller commented on JCR-1232: - > public UUID getUUID() { return new UUID(msb, lsb); } That would be a sol

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544980 ] Thomas Mueller commented on JCR-1232: - The name 'UUID' is currently used by some central components (for example p

[jira] Commented: (JCR-1213) UUIDDocId cache does not work properly because of weakReferences in combination with new instance for combined indexreader

2007-11-23 Thread Ard Schrijvers (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544983 ] Ard Schrijvers commented on JCR-1213: - Minor thing: why in DocId.UUIDDocId getDocumentNumber the synchronized met

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544985 ] Jukka Zitting commented on JCR-1232: If needed, we could keep the getUUID() method around as a deprecated one for

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Stefan Guggisberg (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544988 ] Stefan Guggisberg commented on JCR-1232: nice! +1 for jukka's patch > Merge UUID to NodeId > -

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544996 ] Jukka Zitting commented on JCR-1232: > Sorry, I really prefer having only one copy of the UUID code. It doesn't >

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545009 ] Jukka Zitting commented on JCR-1232: Hmm, a nice alternative: We should in fact be making NodeId an interface and

[jira] Commented: (JCR-1213) UUIDDocId cache does not work properly because of weakReferences in combination with new instance for combined indexreader

2007-11-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545016 ] Marcel Reutegger commented on JCR-1213: --- Because getDocumentNumber() may be called from multiple concurrent threa

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545020 ] Marcel Reutegger commented on JCR-1232: --- > public class UUIDNodeId extends UUID implements NodeId { ... } I don

[jira] Commented: (JCR-1213) UUIDDocId cache does not work properly because of weakReferences in combination with new instance for combined indexreader

2007-11-23 Thread Ard Schrijvers (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545025 ] Ard Schrijvers commented on JCR-1213: - Aaaah yes, you are right. ATM I have a working test version, that seems to

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545031 ] Thomas Mueller commented on JCR-1232: - In my view duplicating source code is worse than adding an interface, but N

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545081 ] Thomas Mueller commented on JCR-1232: - > ItemId extends Serializable Yes, sorry, I forgot that. Also I didn't test

[jira] Commented: (JCR-1232) Merge UUID to NodeId

2007-11-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545067 ] Thomas Mueller commented on JCR-1232: - sorry I named my patch the same as you did. Mine is the shorter one. > Merg