[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-14 Thread Ard Schrijvers (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551845 ] Ard Schrijvers commented on JCR-1271: - Okay. Do you know/experience if you changes regarding synchronized make thi

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551841 ] Marcel Reutegger commented on JCR-1271: --- This will turn ItemStateReferenceMap into a synchonized map, which is no

[jira] Updated: (JCR-1273) Unnecessary parsing of Name value

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1273: -- Attachment: JCR-1273.patch Proposed change. > Unnecessary parsing of Name value > --

[jira] Commented: (JCR-1273) Unnecessary parsing of Name value

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551836 ] Marcel Reutegger commented on JCR-1273: --- In the long run I think we should move the Value stuff to spi-commons as

[jira] Created: (JCR-1273) Unnecessary parsing of Name value

2007-12-14 Thread Marcel Reutegger (JIRA)
Unnecessary parsing of Name value - Key: JCR-1273 URL: https://issues.apache.org/jira/browse/JCR-1273 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-core, jackrabbit-jcr-commons

[jira] Commented: (JCR-1271) NullPointerException when iterating over properties

2007-12-14 Thread Ard Schrijvers (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551834 ] Ard Schrijvers commented on JCR-1271: - Wouldn't be enough to replace public ItemStateReferenceMap() { supe

[jira] Resolved: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

2007-12-14 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved JCR-832. -- Resolution: Fixed Fix Version/s: 1.4 committed proposed patch @ revision 604211. > BundleD

[jira] Updated: (JCR-1271) NullPointerException when iterating over properties

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1271: -- Attachment: JCR-1271.patch Revised patch. Previous version may produce a deadlock. > NullPointer

[jira] Updated: (JCR-1272) Property.getValue() throws RepositoryException with internal error

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1272: -- Attachment: JCR-1272.patch Moved getItemState() to the top of the method. This ensures that the s

[jira] Updated: (JCR-1271) NullPointerException when iterating over properties

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1271: -- Attachment: JCR-1271.patch Proposed fix. > NullPointerException when iterating over properties >

Re: JCR2SPI testNodeIdentity calls Node.isLocked()

2007-12-14 Thread Marcel Reutegger
Angela Schreiber wrote: if i remember correctly we discussed that in the past (there is an issue by julian or by michi) and we decided that RepositoryService.getLockInfo should return 'null' if locking is not supported. the javadoc says: " If the implementation does not support locking at all,

[jira] Created: (JCR-1272) Property.getValue() throws RepositoryException with internal error

2007-12-14 Thread Marcel Reutegger (JIRA)
Property.getValue() throws RepositoryException with internal error -- Key: JCR-1272 URL: https://issues.apache.org/jira/browse/JCR-1272 Project: Jackrabbit Issue Type: Bug

[jira] Created: (JCR-1271) NullPointerException when iterating over properties

2007-12-14 Thread Marcel Reutegger (JIRA)
NullPointerException when iterating over properties --- Key: JCR-1271 URL: https://issues.apache.org/jira/browse/JCR-1271 Project: Jackrabbit Issue Type: Bug Components: jackrabbit-co

Re: JCR2SPI testNodeIdentity calls Node.isLocked()

2007-12-14 Thread Angela Schreiber
Marcel Reutegger wrote: David Rauschenbach wrote: I implemented an SPI that does not support locking. However, the TCK api,NodeTest testNodeIdentity() method calls isLocked(), which invokes getLockInfo on my SPI, from which I throw UnsupportedOperationException(), because I make no attempt to su

[jira] Commented: (JCR-1242) Improve serialization of NodeReferences for BundleDB PMs

2007-12-14 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551782 ] Jukka Zitting commented on JCR-1242: I wouldn't worry too much about external dependencies to such internal classes

[jira] Commented: (JCR-1252) BundleFsPersistenceManager: remove deprecated settings

2007-12-14 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551776 ] Jukka Zitting commented on JCR-1252: Should we keep the setters as no-op methods that just log a warning? There mi

[jira] Updated: (JCR-1254) DatabaseJournal commits twice inside a transaction, causing an error with MySQL

2007-12-14 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1254: --- Fix Version/s: 1.4 Affects Version/s: 1.3 1.3.1 > DatabaseJournal commit

[jira] Updated: (JCR-1213) UUIDDocId cache does not work properly because of weakReferences in combination with new instance for combined indexreader

2007-12-14 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1213: --- Affects Version/s: (was: 1.3.3) > UUIDDocId cache does not work properly because of weakReferences

[jira] Updated: (JCR-1250) When adding a large (100MB) binary to the DbDataStore, it fails with an insufficient memory exception

2007-12-14 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-1250: --- Fix Version/s: 1.4 Affects Version/s: (was: 1.4) > When adding a large (100MB) binary to th

[jira] Resolved: (JCR-1258) Add path encoding to ISO9075

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-1258. --- Resolution: Fixed Added method encodePath(String path). svn revision: 604166 > Add path encod

[jira] Updated: (JCR-1258) Add path encoding to ISO9075

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1258: -- Fix Version/s: 1.4 Summary: Add path encoding to ISO9075 (was: Add path en-/de-coding

Re: JCR2SPI testNodeIdentity calls Node.isLocked()

2007-12-14 Thread Marcel Reutegger
David Rauschenbach wrote: I implemented an SPI that does not support locking. However, the TCK api,NodeTest testNodeIdentity() method calls isLocked(), which invokes getLockInfo on my SPI, from which I throw UnsupportedOperationException(), because I make no attempt to support locking. Am I mis

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

2007-12-14 Thread Stefan Guggisberg (JIRA)
[ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551750 ] Stefan Guggisberg commented on JCR-832: --- yup, +1 for toby's patch > BundleDBPersistenceManager does not free blob

JCR2SPI testNodeIdentity calls Node.isLocked()

2007-12-14 Thread David Rauschenbach
I implemented an SPI that does not support locking. However, the TCK api,NodeTest testNodeIdentity() method calls isLocked(), which invokes getLockInfo on my SPI, from which I throw UnsupportedOperationException(), because I make no attempt to support locking. Am I misunderstanding anything? Or s

[jira] Updated: (JCR-1209) NodeImpl.checkout() calls save() two times

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1209: -- Attachment: JCR-1209.patch I suggest we implement a check for pending changes. For most cases thi

[jira] Updated: (JCR-1209) NodeImpl.checkout() calls save() two times

2007-12-14 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-1209: -- Summary: NodeImpl.checkout() calls save() two times (was: NodeImpl.checkot() calls save() two ti

[jira] Commented: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

2007-12-14 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551742 ] Jukka Zitting commented on JCR-832: --- +1 That looks nice and clean! > BundleDBPersistenceManager does not free blobSto

[jira] Updated: (JCR-832) BundleDBPersistenceManager does not free blobStore resources

2007-12-14 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/JCR-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra updated JCR-832: - Attachment: jcr-832.patch > BundleDBPersistenceManager does not free blobStore resources > -

[jira] Created: (JCR-1270) CompactNodeTypeDefReader does not recognise MIXIN ORDERABLE sequence

2007-12-14 Thread Tobias Bocanegra (JIRA)
CompactNodeTypeDefReader does not recognise MIXIN ORDERABLE sequence Key: JCR-1270 URL: https://issues.apache.org/jira/browse/JCR-1270 Project: Jackrabbit Issue Type: Bug

[jira] Resolved: (JCR-1270) CompactNodeTypeDefReader does not recognise MIXIN ORDERABLE sequence

2007-12-14 Thread Tobias Bocanegra (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Bocanegra resolved JCR-1270. --- Resolution: Fixed changed to correct method. > CompactNodeTypeDefReader does not recognise MIX