Re: svn commit: r1298002 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/StoredNodeAsState.java

2012-03-07 Thread Michael Dürig
On Wed, Mar 7, 2012 at 9:45 PM, Michael Dürig wrote: Regarding equals in the abstract base classes: I'd make the equals methods in the abstract base classes final. No, the current non-final implementation is by design. See the followup patch I attached to OAK-3 for what I'm aiming at here.

Re: Setting up Oak (Was: [RESULT] [VOTE] Codename for the jr3 implementation effort)

2012-03-07 Thread Ate Douma
On 03/07/2012 10:55 PM, Jukka Zitting wrote: Hi, On Wed, Mar 7, 2012 at 10:47 PM, Ate Douma wrote: Right now discussions and replies on oak specific issues and commit messages still end up on the main dev@ so IMO not serving the intent. Correct. I switched the OAK notifications to go to oak-

[jira] [Created] (OAK-4) Runnable jar packaging

2012-03-07 Thread Jukka Zitting (Created) (JIRA)
Runnable jar packaging -- Key: OAK-4 URL: https://issues.apache.org/jira/browse/OAK-4 Project: Jackrabbit Oak Issue Type: New Feature Reporter: Jukka Zitting Fix For: 0.1 We should have a simple

Re: Setting up Oak (Was: [RESULT] [VOTE] Codename for the jr3 implementation effort)

2012-03-07 Thread Jukka Zitting
Hi, On Wed, Mar 7, 2012 at 10:47 PM, Ate Douma wrote: > Right now discussions and replies on oak specific issues and commit messages > still end up on the main dev@ so IMO not serving the intent. Correct. I switched the OAK notifications to go to oak-dev@ just now (didn't want to do so earlier t

Re: Setting up Oak (Was: [RESULT] [VOTE] Codename for the jr3 implementation effort)

2012-03-07 Thread Ate Douma
On 03/07/2012 09:25 AM, Jukka Zitting wrote: Hi, On Tue, Mar 6, 2012 at 1:00 PM, Jukka Zitting wrote: The oak-dev@ mailing list should follow up shortly, see INFRA-4514 [1]. The list is ready now, you can subscribe by sending a message to oak-dev-subscr...@jackrabbit.apache.org. I suggest we

Re: svn commit: r1298002 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/StoredNodeAsState.java

2012-03-07 Thread Jukka Zitting
Hi, On Wed, Mar 7, 2012 at 9:45 PM, Michael Dürig wrote: > Regarding equals in the abstract base classes: I'd make the equals methods > in the abstract base classes final. No, the current non-final implementation is by design. See the followup patch I attached to OAK-3 for what I'm aiming at he

Re: svn commit: r1298002 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/StoredNodeAsState.java

2012-03-07 Thread Michael Dürig
Hi, Regarding equals in the abstract base classes: I'd make the equals methods in the abstract base classes final. Overriding them in a concrete subclass will most likely break symmetry. Furthermore, since these classes are immutable, the result of equals can be cached safely. Michael On 7

Re: svn commit: r1298002 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/store/StoredNodeAsState.java

2012-03-07 Thread Michael Dürig
Hi, Regarding equals in the abstract base classes: I'd make the equals methods in the abstract base classes final. Overriding them in a concrete subclass will most likely break symmetry. Furthermore, since these classes are immutable, the result of equals can be cached safely. Michael On 7

jsop and property / node with same name

2012-03-07 Thread David Buchmann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 hi, while implementing the jackalope php jsop client for the jackrabbit backend, i stumbled over a problem with the json returned when a property and a child node have the same name: the repository is something like this: to create it, i do

[jira] [Updated] (OAK-3) Internal tree model

2012-03-07 Thread Jukka Zitting (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated OAK-3: Attachment: OAK-3.2.patch Attached a new patch that implements diffing and related operations (CommitBuilder, e

[jira] [Created] (JCR-3253) Set omit term freq positions flag on parent field in the index

2012-03-07 Thread Alex Parvulescu (Created) (JIRA)
Set omit term freq positions flag on parent field in the index -- Key: JCR-3253 URL: https://issues.apache.org/jira/browse/JCR-3253 Project: Jackrabbit Content Repository Issue Type

Re: JSOP/davex and transactions not working (compared to "simple webdav")

2012-03-07 Thread Angela Schreiber
hallo chregu ok. looking forward to your comments. angela ps: 'simple webdav' is not referring to version 1 of the jcr-remoting that purely relied on (extended) webdav functionality but to a regular file-folder-based webdav view to a JCR repository... yet something completely differe

[jira] [Commented] (JCR-1616) Spi2Dav / 283 Conflict: Creation of PropertyInfoImpl fails with NPE if the returned ItemInfo points to a Node

2012-03-07 Thread David Buchmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224262#comment-13224262 ] David Buchmann commented on JCR-1616: - additionally, the json returned for a node that h

Re: JSOP/davex and transactions not working (compared to "simple webdav")

2012-03-07 Thread Christian Stocker
Hi Thanks. I will read the JCR specs again about that part, but your explanations helped a lot already. I think we might find a way for our needs with this greetings chregu On 07.03.12 13:05, Angela Schreiber wrote: > hi chregu > > if you mean 'a bunch of transient modifications' when speaking

[jira] [Commented] (JCR-3249) clarify/tune RepositoryService lifecycle

2012-03-07 Thread angela (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/JCR-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224222#comment-13224222 ] angela commented on JCR-3249: - i don't think this is intentional but it would definitely be

Re: JSOP/davex and transactions not working (compared to "simple webdav")

2012-03-07 Thread Angela Schreiber
hi chregu if you mean 'a bunch of transient modifications' when speaking about transactions that everything works as expected: you have 2 possibilities to transport a set of transient JCR modifications to the server: a) LOCK (special lockscope) your requests that reflect your transient modif

Re: JSOP/davex and transactions not working (compared to "simple webdav")

2012-03-07 Thread Christian Stocker
Hi angela If I understand you correctly, we should implement transactions on the client side and only send the jsop diff, when we actually commit the transaction? We send it now on each save(), but that may be wrong then. Could be a solution for our problem :) I guess all the operations which are

[jira] [Updated] (JCR-1616) Spi2Dav / 283 Conflict: Creation of PropertyInfoImpl fails with NPE if the returned ItemInfo points to a Node

2012-03-07 Thread angela (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/JCR-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated JCR-1616: Affects Version/s: 2.0 2.1 2.2 2.3

Re: JSOP/davex removing same-name siblings question

2012-03-07 Thread Christian Stocker
Hi Angela Thanks a lot for the answer. I will make a jira issue about it. It's not a critical thing for us right now, we can circumvent it (and we don't work with same-name-siblings anyway, the problem is just when we want to delete accidental same name siblings to have a clean repo) Greetings c

[jira] [Resolved] (JCR-3251) NullPointerException on property with same name as node

2012-03-07 Thread angela (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/JCR-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved JCR-3251. - Resolution: Duplicate duplicate of JCR-1616 > NullPointerException on property with same name as n

Re: JSOP/davex and transactions not working (compared to "simple webdav")

2012-03-07 Thread Angela Schreiber
hi chregu the transaction type you are referring to aren't transactions s.str. but were the first version of my jcr-remoting to indentify a set of transient modifications that are transported to the server and are 'saved' at the end (or reverted with Session.refresh(false)). at that time we tho

Re: JSOP/davex removing same-name siblings question

2012-03-07 Thread Angela Schreiber
hi chregu the problem is multifolded having one part in jackrabbit-core and a second one in the way sms are reflected over the SPI. as a general summary i would say that having volatile index both in jcr2spi and jackrabbit-core is pretty troublesome. without having a close look at it, i would su

[jira] [Commented] (OAK-3) Internal tree model

2012-03-07 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224207#comment-13224207 ] Jukka Zitting commented on OAK-3: - Patch applied in revision 1297932. Renamed the package to .o

[jira] [Commented] (OAK-3) Internal tree model

2012-03-07 Thread Stefan Guggisberg (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224109#comment-13224109 ] Stefan Guggisberg commented on OAK-3: - +1 for the patch, i agree that .oak.model would be b

Re: Setting up Oak (Was: [RESULT] [VOTE] Codename for the jr3 implementation effort)

2012-03-07 Thread Jukka Zitting
Hi, On Tue, Mar 6, 2012 at 1:00 PM, Jukka Zitting wrote: > The oak-dev@ mailing list should follow up shortly, see INFRA-4514 [1]. The list is ready now, you can subscribe by sending a message to oak-dev-subscr...@jackrabbit.apache.org. I suggest we move discussion about Oak to the new list grad