[GitHub] [jackrabbit-oak] kwin commented on pull request #414: OAK-9621: add tests for mandatory child nodes (both residual and non-residual)

kwin commented on pull request #414: URL: https://github.com/apache/jackrabbit-oak/pull/414#issuecomment-966894344 I would like to add the tests (as I don't think this is covered in the TCK). The behaviour is fine though and fully compliant with JCR 2.0 spec. -- This is an automated mess

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #181: Bugfix/jcrvlt 549

kwin commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r748034932 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #181: Bugfix/jcrvlt 549

tripodsan commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r748024131 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * L

[jira] [Commented] (JCRVLT-549) node cannot be deleted if it's a residual mandatory child node

[ https://issues.apache.org/jira/browse/JCRVLT-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442320#comment-17442320 ] Konrad Windszus commented on JCRVLT-549: Actually JCR 2.0 mandates that mandatory

[jira] [Updated] (JCRVLT-549) node cannot be deleted if it's a residual mandatory child node

[ https://issues.apache.org/jira/browse/JCRVLT-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-549: --- Summary: node cannot be deleted if it's a residual mandatory child node (was: node cannot be

[GitHub] [jackrabbit-oak] mreutegg merged pull request #415: OAK-9562: Missing _bin when node is recreated after revision GC

mreutegg merged pull request #415: URL: https://github.com/apache/jackrabbit-oak/pull/415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #181: Bugfix/jcrvlt 549

kwin commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r747549266 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] [jackrabbit-oak] mreutegg merged pull request #412: OAK-8974: VersionGarbageCollectorIT should use fixtures from Abstract…

mreutegg merged pull request #412: URL: https://github.com/apache/jackrabbit-oak/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #181: Bugfix/jcrvlt 549

kwin commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r747528374 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #181: Bugfix/jcrvlt 549

kwin commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r747528374 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #181: Bugfix/jcrvlt 549

kwin commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r747528374 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #181: Bugfix/jcrvlt 549

kwin commented on a change in pull request #181: URL: https://github.com/apache/jackrabbit-filevault/pull/181#discussion_r747528374 ## File path: vault-core/src/test/java/org/apache/jackrabbit/vault/packaging/integration/MandatoryNodeIT.java ## @@ -0,0 +1,62 @@ +/* + * Licens

[GitHub] [jackrabbit-filevault] kwin commented on pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

kwin commented on pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#issuecomment-966149932 Alternative approach in https://github.com/apache/jackrabbit-filevault/pull/181/files. @reschke Please have a look. -- This is an automated message from the Apache G

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

kwin commented on a change in pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747294385 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java ## @@ -1295,6 +1298,33 @@ public void endE

[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

tripodsan commented on a change in pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747282565 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java ## @@ -1295,6 +1297,37 @@ public void

[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

tripodsan commented on a change in pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747282565 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java ## @@ -1295,6 +1297,37 @@ public void

[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

tripodsan commented on a change in pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747246708 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java ## @@ -1295,6 +1298,33 @@ public void

[GitHub] [jackrabbit-filevault] tripodsan commented on a change in pull request #163: JCRVLT-549 - node cannot be deleted if it's a multi-mandatory child node

tripodsan commented on a change in pull request #163: URL: https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r747280014 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java ## @@ -1295,6 +1298,33 @@ public void

[GitHub] [jackrabbit-oak] tihom88 merged pull request #413: OAK-9610: Rectify failing test

tihom88 merged pull request #413: URL: https://github.com/apache/jackrabbit-oak/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub