[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
nit0906 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r787434446 ## File path: oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java ## @@ -1237,13 +1238,18 @@ private st

[GitHub] [jackrabbit-oak] averma21 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
averma21 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r787430905 ## File path: oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java ## @@ -1237,13 +1238,18 @@ private s

[jira] [Updated] (JCRVLT-591) Detect unclosed packages and archives

2022-01-18 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-591: --- Resolution: Fixed Status: Resolved (was: Patch Available) Fixed in https://github.c

[GitHub] [jackrabbit-filevault] kwin merged pull request #199: JCRVLT-591 track unclosed archives

2022-01-18 Thread GitBox
kwin merged pull request #199: URL: https://github.com/apache/jackrabbit-filevault/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [jackrabbit-oak] FrancoisZhang opened a new pull request #469: OAK-9671 Increase dynamicBoost and dynamicBoostLite full-text test co…

2022-01-18 Thread GitBox
FrancoisZhang opened a new pull request #469: URL: https://github.com/apache/jackrabbit-oak/pull/469 …verage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
nit0906 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r787076069 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(FilterI

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
nit0906 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r787040369 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(FilterI

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
nit0906 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r787040369 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(FilterI

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #468: OAK-9668 Update H2DB dependency (#466)

2022-01-18 Thread GitBox
stefan-egli commented on pull request #468: URL: https://github.com/apache/jackrabbit-oak/pull/468#issuecomment-1015676162 Travis build has failed previously - looks unrelated to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli commented on pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466#issuecomment-1015664252 PS: https://github.com/apache/jackrabbit-oak/pull/468 is the backport of this to 1.22 branch -- This is an automated message from the Apache Git Service. To respond

[GitHub] [jackrabbit-oak] stefan-egli opened a new pull request #468: OAK-9668 Update H2DB dependency (#466)

2022-01-18 Thread GitBox
stefan-egli opened a new pull request #468: URL: https://github.com/apache/jackrabbit-oak/pull/468 * OAK-9668 Update H2DB dependency * OAK-9668: Update H2DB dependency Update dependency to 2.0.206 * OAK-9668 : move cast and binarySearch to DataTypeUtil * OAK-9668:

[GitHub] [jackrabbit-oak] stefan-egli merged pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli merged pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

[GitHub] [jackrabbit-filevault] reschke commented on a change in pull request #202: JCRVLT-596: add OSGi config for default IdConflictPolicy

2022-01-18 Thread GitBox
reschke commented on a change in pull request #202: URL: https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786918756 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java ## @@ -386,6 +386,7 @@ private void ext

[GitHub] [jackrabbit-filevault] reschke commented on a change in pull request #202: JCRVLT-596: add OSGi config for default IdConflictPolicy

2022-01-18 Thread GitBox
reschke commented on a change in pull request #202: URL: https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786918756 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java ## @@ -386,6 +386,7 @@ private void ext

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
thomasmueller commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r786910669 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(F

[GitHub] [jackrabbit-filevault] reschke commented on a change in pull request #202: JCRVLT-596: add OSGi config for default IdConflictPolicy

2022-01-18 Thread GitBox
reschke commented on a change in pull request #202: URL: https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786893514 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java ## @@ -386,6 +386,7 @@ private void ext

[GitHub] [jackrabbit-oak] thomasmueller merged pull request #467: OAK-9670 : log at WARN level for fulltext query without index

2022-01-18 Thread GitBox
thomasmueller merged pull request #467: URL: https://github.com/apache/jackrabbit-oak/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev

[GitHub] [jackrabbit-oak] blackfor commented on a change in pull request #467: OAK-9670 : log at ERROR level for fulltext query without index

2022-01-18 Thread GitBox
blackfor commented on a change in pull request #467: URL: https://github.com/apache/jackrabbit-oak/pull/467#discussion_r786847726 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java ## @@ -1201,7 +1201,13 @@ private SelectorExecutionPlan getBest

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli commented on pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466#issuecomment-1015497866 any other +1? @thomasmueller , @reschke ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #467: OAK-9670 : log at ERROR level for fulltext query without index

2022-01-18 Thread GitBox
thomasmueller commented on a change in pull request #467: URL: https://github.com/apache/jackrabbit-oak/pull/467#discussion_r786845134 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java ## @@ -1201,7 +1201,13 @@ private SelectorExecutionPlan ge

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli commented on pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466#issuecomment-1015491693 oak-store-document that failed in run 5 succeeded in run 6 and 7 - so it does look like a flaky test. the [failure](https://ci-builds.apache.org/job/Jackrabbit/job/oak

[GitHub] [jackrabbit-oak] blackfor opened a new pull request #467: OAK-9670 : log at ERROR level for fulltext query without index

2022-01-18 Thread GitBox
blackfor opened a new pull request #467: URL: https://github.com/apache/jackrabbit-oak/pull/467 Fulltext queries cannot be handled by traversal, so we need to highlight prominently when a fulltext query has been issues but no appropriate index can be found. -- This is an automated messa

[GitHub] [jackrabbit-oak] stefan-egli edited a comment on pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli edited a comment on pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466#issuecomment-1015440224 * [run 6](https://ci-builds.apache.org/blue/organizations/jenkins/Jackrabbit%2Foak-trunk-pr/detail/PR-466/6/pipeline) succeeded - so it could be a potential fla

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli commented on pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466#issuecomment-1015440224 * [run 6](https://ci-builds.apache.org/blue/organizations/jenkins/Jackrabbit%2Foak-trunk-pr/detail/PR-466/6/pipeline) succeeded - so it could be a potential flaky test

[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #202: JCRVLT-596: add OSGi config for default IdConflictPolicy

2022-01-18 Thread GitBox
kwin commented on a change in pull request #202: URL: https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786781457 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java ## @@ -386,6 +386,7 @@ private void extrac

[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #466: OAK-9668 Update H2DB dependency

2022-01-18 Thread GitBox
stefan-egli commented on pull request #466: URL: https://github.com/apache/jackrabbit-oak/pull/466#issuecomment-1015385142 PS: trying to reproduce the test locally but can't so far. rerunning the test now to see if it is flaky -- This is an automated message from the Apache Git Service.

[jira] [Assigned] (JCRVLT-598) need IdConflictPolicy compatible with 3.5.0 behavior

2022-01-18 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned JCRVLT-598: - Assignee: Julian Reschke > need IdConflictPolicy compatible with 3.5.0 behavior > --

[GitHub] [jackrabbit-filevault] reschke commented on a change in pull request #202: JCRVLT-596: add OSGi config for default IdConflictPolicy

2022-01-18 Thread GitBox
reschke commented on a change in pull request #202: URL: https://github.com/apache/jackrabbit-filevault/pull/202#discussion_r786709540 ## File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/PackagingImpl.java ## @@ -106,6 +106,9 @@ public PackagingI

[jira] [Created] (JCRVLT-598) need IdConflictPolicy compatible with 3.5.0 behavior

2022-01-18 Thread Julian Reschke (Jira)
Julian Reschke created JCRVLT-598: - Summary: need IdConflictPolicy compatible with 3.5.0 behavior Key: JCRVLT-598 URL: https://issues.apache.org/jira/browse/JCRVLT-598 Project: Jackrabbit FileVault

[jira] [Commented] (JCRVLT-597) Update commons-io dependency to 2.11.0

2022-01-18 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477714#comment-17477714 ] Konrad Windszus commented on JCRVLT-597: A single OSGi bundle should IMHO not for

[jira] [Commented] (JCRVLT-597) Update commons-io dependency to 2.11.0

2022-01-18 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477710#comment-17477710 ] Julian Reschke commented on JCRVLT-597: --- FWIW, making it incompatible would actuall

[jira] [Comment Edited] (JCRVLT-597) Update commons-io dependency to 2.11.0

2022-01-18 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477707#comment-17477707 ] Konrad Windszus edited comment on JCRVLT-597 at 1/18/22, 9:35 AM: -

[jira] [Commented] (JCRVLT-597) Update commons-io dependency to 2.11.0

2022-01-18 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477707#comment-17477707 ] Konrad Windszus commented on JCRVLT-597: A change of the dependency version in pa

[jira] [Updated] (JCRVLT-597) Update commons-io dependency to 2.11.0

2022-01-18 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCRVLT-597: -- Fix Version/s: 3.5.10 > Update commons-io dependency to 2.11.0 > --

[jira] [Created] (JCRVLT-597) Update commons-io dependency to 2.11.0

2022-01-18 Thread Julian Reschke (Jira)
Julian Reschke created JCRVLT-597: - Summary: Update commons-io dependency to 2.11.0 Key: JCRVLT-597 URL: https://issues.apache.org/jira/browse/JCRVLT-597 Project: Jackrabbit FileVault Issue T

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
nit0906 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r786513708 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(FilterI

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
nit0906 commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r786513708 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(FilterI

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #465: OAK-9662 | Support not equal condition in query from Index

2022-01-18 Thread GitBox
thomasmueller commented on a change in pull request #465: URL: https://github.com/apache/jackrabbit-oak/pull/465#discussion_r786504869 ## File path: oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java ## @@ -125,12 +125,7 @@ public void restrict(F