enapps-enorman commented on pull request #471:
URL: https://github.com/apache/jackrabbit-oak/pull/471#issuecomment-1036601054
> which apparently only stores properties directly below the user node.
This is not true, we do use properties stored under subnodes as well. We
use a custom
enapps-enorman edited a comment on pull request #471:
URL: https://github.com/apache/jackrabbit-oak/pull/471#issuecomment-1036577910
> @enapps-enorman , i have to check the code again regarding the handling in
the subtree because i thought it was different.
Please do check the code,
enapps-enorman commented on pull request #471:
URL: https://github.com/apache/jackrabbit-oak/pull/471#issuecomment-1036577910
> @enapps-enorman , i have to check the code again regarding the handling in
the subtree because i thought it was different.
Please do check the code, becaus
joerghoh commented on pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#issuecomment-1036447040
@mreutegg / @anchela: I don't have enough karma/permissions to merge this
PR, can you do it for me?
--
This is an automated message from the Apache Git Service.
To re
mreutegg commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804802274
##
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/composite/blueGreen/IndexUtils.java
##
@@ -142,7 +142,7 @@ public static void chec
joerghoh commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804790962
##
File path:
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/delegate/SessionDelegateTest.java
##
@@ -68,4 +74,38 @@ public void testRefreshUn
mreutegg commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804780607
##
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/composite/blueGreen/IndexUtils.java
##
@@ -142,7 +142,7 @@ public static void chec
mreutegg commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804778450
##
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/composite/blueGreen/IndexUtils.java
##
@@ -142,7 +142,7 @@ public static void chec
fabriziofortino merged pull request #487:
URL: https://github.com/apache/jackrabbit-oak/pull/487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: d
fabriziofortino commented on a change in pull request #487:
URL: https://github.com/apache/jackrabbit-oak/pull/487#discussion_r804656809
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticSpellcheckIterator.java
##
@@ -1
nit0906 commented on a change in pull request #487:
URL: https://github.com/apache/jackrabbit-oak/pull/487#discussion_r804644778
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticSpellcheckIterator.java
##
@@ -16,6 +16,
nit0906 commented on a change in pull request #487:
URL: https://github.com/apache/jackrabbit-oak/pull/487#discussion_r804645084
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticSuggestIterator.java
##
@@ -16,6 +16,7 @
fabriziofortino commented on a change in pull request #487:
URL: https://github.com/apache/jackrabbit-oak/pull/487#discussion_r804626312
##
File path:
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexMBean.java
##
@@ -26,19 +25,18 @@
import o
[
https://issues.apache.org/jira/browse/JCRVLT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-606:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Fixed in
https://github.c
kwin merged pull request #205:
URL: https://github.com/apache/jackrabbit-filevault/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
joerghoh commented on pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#issuecomment-1036082822
@mreutegg I added additional test coverage and changed the exception as
indicated.
--
This is an automated message from the Apache Git Service.
To respond to the messag
joerghoh commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804543811
##
File path:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/composite/blueGreen/IndexUtils.java
##
@@ -142,7 +142,7 @@ public static void chec
[
https://issues.apache.org/jira/browse/JCRVLT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-606:
---
Status: Patch Available (was: In Progress)
> Potential NPE in PackageManager.rewrap()
>
[
https://issues.apache.org/jira/browse/JCRSITE-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed JCRSITE-50.
> Broken link to ezmlm documentation
> --
>
> Key: JCRSITE-50
>
AngelaFabregues commented on a change in pull request #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r804476525
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java
##
@@ -108,11 +121,25
AngelaFabregues commented on a change in pull request #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r804476525
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java
##
@@ -108,11 +121,25
AngelaFabregues commented on a change in pull request #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r804476525
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java
##
@@ -108,11 +121,25
fabriziofortino merged pull request #489:
URL: https://github.com/apache/jackrabbit-oak/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: d
joerghoh commented on a change in pull request #485:
URL: https://github.com/apache/jackrabbit-oak/pull/485#discussion_r804460757
##
File path:
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/delegate/SessionDelegate.java
##
@@ -212,6 +213,8 @@ public void refreshAtNextAcc
anchela commented on pull request #471:
URL: https://github.com/apache/jackrabbit-oak/pull/471#issuecomment-1035984133
@enapps-enorman , one more comment regarding
> I'm not sure it would be practical to try to automatically add a mixin
type during the setProperty calls, as there cou
thomasmueller commented on a change in pull request #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r804435058
##
File path:
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java
##
@@ -90,15 +95,23 @@ p
enapps-enorman edited a comment on pull request #471:
URL: https://github.com/apache/jackrabbit-oak/pull/471#issuecomment-1035421352
> i have to check the code again regarding the handling in the subtree
because i thought it was different. my point is that properties somewhere in
the subtr
[
https://issues.apache.org/jira/browse/JCRVLT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned JCRVLT-606:
--
Assignee: Konrad Windszus
> Potential NPE in PackageManager.rewrap()
> ---
[
https://issues.apache.org/jira/browse/JCRVLT-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-606:
---
Description:
In case the given {{VaultPackage}} returns {{null}} for its {{getFile()}}
metho
29 matches
Mail list logo
