fabriziofortino commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r150551
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65 +181,
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504557325
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Ap
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504533722
##
oak-run/src/main/groovy/org/apache/jackrabbit/oak/console/GroovyConsole.groovy:
##
@@ -124,6 +124,7 @@ class GroovyConsole {
new CheckpointC
stefan-egli commented on PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1966884398
ah, you right away merged it, ok :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rishabhdaim merged PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
[
https://issues.apache.org/jira/browse/JCR-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771815#comment-17771815
]
Julian Reschke edited comment on JCR-4973 at 2/27/24 3:30 PM:
--
fabriziofortino merged PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
stefan-egli commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1966670655
It's generally speaking a bit difficult to review as the code doesn't
compile at this point (therefore eg you can't debug through it, to understand
it better). As I understand
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504318420
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504315202
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504314717
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504309300
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleanerTest.java:
##
@@ -0,0 +1,549 @@
+package org.apache
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504304416
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -460,6 +494,97 @@ private void sweep(RevisionsOptions options, Closer clo
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504293588
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504290603
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1053,6 +1053,28 @@ private void collectUn
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504288687
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504283327
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -82,6 +97,7 @@ public class RevisionsCommand implements Command {
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504280658
##
oak-run/src/main/groovy/org/apache/jackrabbit/oak/console/GroovyConsole.groovy:
##
@@ -124,6 +124,7 @@ class GroovyConsole {
new Checkpoi
stefan-egli commented on PR #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326#issuecomment-1966567441
thx for merging @mbaedke !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
stefan-egli commented on PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1966558849
@rishabhdaim , thx for the review, applied all comments, please revisit, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/JCR-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821240#comment-17821240
]
Julian Reschke commented on JCR-5028:
-
trunk:
[27f19580e|https://github.com/apache/jac
[
https://issues.apache.org/jira/browse/JCR-4972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved JCR-4972.
-
Fix Version/s: 2.21.26
Resolution: Fixed
> Remove RMI support
> --
>
>
[
https://issues.apache.org/jira/browse/JCR-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved JCR-5028.
-
Fix Version/s: 2.21.26
Resolution: Fixed
> jackrabbit-jcr-rmi: remove
>
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1504238312
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
testDe
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1504230368
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1255,28 +1305,40 @@ public void removeGar
stefan-egli commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1504229448
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1255,28 +1305,40 @@ public void removeGar
fabriziofortino commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1504204826
##
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java:
##
@@ -436,4 +437,12 @@ public static IndexingMod
fabriziofortino commented on code in PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1504202939
##
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java:
##
@@ -52,8 +53,12 @@ class ElasticInd
[
https://issues.apache.org/jira/browse/JCR-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821220#comment-17821220
]
Julian Reschke commented on JCR-5027:
-
trunk:
[87351a8f9|https://github.com/apache/jac
[
https://issues.apache.org/jira/browse/JCR-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved JCR-5027.
-
Fix Version/s: 2.21.26
Resolution: Fixed
> jackrabbit-webapp: remove RMI support
>
[
https://issues.apache.org/jira/browse/JCR-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821208#comment-17821208
]
Julian Reschke commented on JCR-5026:
-
trunk:
[aa8dc3f88|https://github.com/apache/jac
[
https://issues.apache.org/jira/browse/JCR-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved JCR-5026.
-
Fix Version/s: 2.21.26
Resolution: Fixed
> standalone: remove remote repository support (RMI
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504104485
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -127,6 +127,7 @@ public class DocumentNodeSto
reschke merged PR #1330:
URL: https://github.com/apache/jackrabbit-oak/pull/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504079086
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +357,42 @@ private void applyToDocumentStore(RevisionVec
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504075464
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##
@@ -2111,6 +2115,11 @@ public T getIfCached
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504075464
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java:
##
@@ -2111,6 +2115,11 @@ public T getIfCached
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504075099
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java:
##
@@ -571,4 +571,16 @@ default List findAndUpdate(final
@No
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504073020
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStore.java:
##
@@ -571,4 +571,16 @@ default List findAndUpdate(final
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504068496
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +357,42 @@ private void applyToDocumentStore(Revisio
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504048284
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -318,6 +319,16 @@ public Feature getDocSt
reschke opened a new pull request, #1330:
URL: https://github.com/apache/jackrabbit-oak/pull/1330
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mbaedke merged PR #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
t-rana opened a new pull request, #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329
Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure
authentication via:
clientId - Id of the Service Principal object / App registered with the
Active Directory.
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503852893
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
testDe
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503852893
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
testDe
rishabhdaim commented on code in PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#discussion_r1503845105
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
@@ -1182,6 +1201,362 @@ public void
testDe
47 matches
Mail list logo
