reschke commented on code in PR #1317: URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1504079086
########## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java: ########## @@ -354,7 +357,42 @@ private void applyToDocumentStore(RevisionVector baseBranchRevision) boolean commitRootHasChanges = operations.containsKey(commitRootPath); for (UpdateOp op : operations.values()) { NodeDocument.setCommitRoot(op, revision, commitRootDepth); + + // special case for :childOrder updates + if (store.isCommitCleanupFeatureEnabled()) { + final Branch localBranch = getBranch(); + if (localBranch != null) { + final TreeSet<Revision> commits = new TreeSet<>(localBranch.getCommits()); Review Comment: I believe the feature toggle needs to be on the DocumentNodeStore, not the DocumentStore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org