rishabhdaim merged PR #1422:
URL: https://github.com/apache/jackrabbit-oak/pull/1422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
mbaedke opened a new pull request, #1423:
URL: https://github.com/apache/jackrabbit-oak/pull/1423
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
rishabhdaim commented on code in PR #1422:
URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567245847
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1216,34 +1220,27 @@ private boolean isDel
rishabhdaim commented on code in PR #1422:
URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567244664
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1216,34 +1220,27 @@ private boolean isDel
rishabhdaim merged PR #1417:
URL: https://github.com/apache/jackrabbit-oak/pull/1417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
rishabhdaim commented on code in PR #1422:
URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567242893
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1216,34 +1220,27 @@ private boolean isDel
stefan-egli commented on code in PR #1417:
URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567211982
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1993,17 +1996,18 @@ private boolean verif
stefan-egli commented on code in PR #1422:
URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567100681
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCSupport.java:
##
@@ -226,6 +236,46 @@ public Optional getOldestModifi
rishabhdaim commented on PR #1417:
URL: https://github.com/apache/jackrabbit-oak/pull/1417#issuecomment-2058726467
Let me make some changes as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stefan-egli merged PR #1421:
URL: https://github.com/apache/jackrabbit-oak/pull/1421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
rishabhdaim commented on code in PR #1417:
URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567064532
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -96,7 +96,8 @@ public class RevisionsCommand implements Command {
pr
rishabhdaim merged PR #1419:
URL: https://github.com/apache/jackrabbit-oak/pull/1419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
rishabhdaim closed pull request #1418: OAK-10763 : fixed the skipping of orphan
nodes in case parent is not …
URL: https://github.com/apache/jackrabbit-oak/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stefan-egli commented on code in PR #1417:
URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567002054
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -96,7 +96,8 @@ public class RevisionsCommand implements Command {
pr
stefan-egli commented on PR #1418:
URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2058580981
As discussed offline I'd argue that an orphan node should be removed
entirely - if a gc mode prevents that, it should be skipped. That makes
verification stronger and keeps the
stefan-egli commented on code in PR #1419:
URL: https://github.com/apache/jackrabbit-oak/pull/1419#discussion_r1566989140
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -349,28 +357,24 @@ private void printInfo(VersionGarbageCollector gc,
Re
stefan-egli commented on code in PR #1419:
URL: https://github.com/apache/jackrabbit-oak/pull/1419#discussion_r1566992068
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -320,15 +330,13 @@ private VersionGarbageCollector
bootstrapVGC(Revision
stefan-egli commented on code in PR #1419:
URL: https://github.com/apache/jackrabbit-oak/pull/1419#discussion_r1566990954
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -349,28 +357,24 @@ private void printInfo(VersionGarbageCollector gc,
Re
rishabhdaim opened a new pull request, #1422:
URL: https://github.com/apache/jackrabbit-oak/pull/1422
…verfication of orphan nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
19 matches
Mail list logo
