nfsantos merged PR #1478:
URL: https://github.com/apache/jackrabbit-oak/pull/1478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rishabhdaim merged PR #1477:
URL: https://github.com/apache/jackrabbit-oak/pull/1477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
On 22.05.2024 21:50, Julian Reschke wrote:
...
[X] +1 Release this package as Apache Jackrabbit Oak 1.64.0
...where...
[INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
[INFO] OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
[INFO] Java version:
A candidate for the Jackrabbit Oak 1.64.0 release is available at:
https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.64.0/
The release candidate is a zip archive of the sources in:
https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.64.0/
The SHA1 checksum of the
anchela commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2125145788
@jsedding , i didn't know. so thanks for all the explanation that helps
@mbaedke , thanks for the additional info
so, i think we are good and sorry for not being
Hi Steffen,
On Wed, 2024-05-22 at 13:54 +, Steffen Van wrote:
> Hi everyone,
>
> I would like to suggest that we introduce a code formatter in Oak.
> Having a formatter will make the code easier to read and keep the
> whole codebase more maintainable. Especially for new people.
>
> I'm not
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124984455
Final remark here: It's not just Whitespace/EOL if the Javadoc gets
reformatted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124976698
> My Prediction: you will face a lot of resistance :)
I already am ;) Doesn't change the fact that it brings huge advantages.
There is a reason most organizations have a
daniancu opened a new pull request, #1479:
URL: https://github.com/apache/jackrabbit-oak/pull/1479
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124966824
> Maybe it's better to move the discussion to the mailing list
That makes sense. My Prediction: you will face a lot of resistance :)
For (at least) the reasons mentioned,
reschke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124946276
Because 1.22 is our maintenance branch.
Anyway, I don't think we're having a productive discussion here.
--
This is an automated message from the Apache Git Service.
To
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124944785
Maybe it's better to move the discussion to the mailing list:
https://lists.apache.org/thread/0519b0m34m8853zxncmt4cc6omo155k4
--
This is an automated message from the Apache
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124943255
Question:
Why are we regularly backporting in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124936612
> Again, if you want to detect what has changed at all and you compare with
an old revision, it's very annoying.
It's also very annoying working with a codebase with
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124934958
> Do you expect cherry-pick to run smoothly in this situation?
Depending on the amount of changes, it's going to be pretty simple to fix
the conflicts yeah. Just keep the
rishabhdaim commented on code in PR #1477:
URL: https://github.com/apache/jackrabbit-oak/pull/1477#discussion_r1610077563
##
oak-run/src/main/js/oak-mongo.js:
##
@@ -352,12 +352,12 @@ var oak = (function(global){
* @param {string} pattern the pattern to match the nodes to
rishabhdaim commented on code in PR #1477:
URL: https://github.com/apache/jackrabbit-oak/pull/1477#discussion_r1610073932
##
oak-run/src/main/js/oak-mongo.js:
##
@@ -352,12 +352,12 @@ var oak = (function(global){
* @param {string} pattern the pattern to match the nodes to
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124906935
> Then we backport the code with the new formatting applied?
Do you expect cherry-pick to run smoothly in this situation?
--
This is an automated message from the Apache
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124875447
> to me that also sounds like a one time thing. If both revisions have the
same formatting, this should not be a problem?
Again, if you want to detect what has changed at all
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124863273
Then we backport the code with the new formatting applied? The formatting
doesn't change the functionality of the code.
--
This is an automated message from the Apache Git
Hi everyone,
I would like to suggest that we introduce a code formatter in Oak. Having a
formatter will make the code easier to read and keep the whole codebase more
maintainable. Especially for new people.
I'm not picky about which particular formatter we use — whether it's Google's
reschke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124831064
> If both revisions have the same formatting, this should not be a problem?
So do you propose to reformat the current maintenance branch and historic
branches as well? What
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124828538
> when diffing with other branches that may have not been reformatted
Well then you can either ignore the whitespace when you perform a diff, or
you can apply the formatting
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124825995
> If you - for example during debugging - compare between revisions to see
what has changed and git will always tell you that everything did, it's very
annoying.
to me
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609854378
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -225,6 +236,8 @@ static DocumentStoreType
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124724483
> the fact that we don't have one is concerning
May I ask what's so critical about that?
Also, nobody cares about the GitHub blame view. People want to use the
command line
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124697511
Also we are talking git diff, not git blame, right? I guess you can use git
blame in an intermediate step to produce a list of file for the diff, but
really???
--
This is an
stefan-egli commented on code in PR #1477:
URL: https://github.com/apache/jackrabbit-oak/pull/1477#discussion_r1609872160
##
oak-run/src/main/js/oak-mongo.js:
##
@@ -352,12 +352,12 @@ var oak = (function(global){
* @param {string} pattern the pattern to match the nodes to
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609854378
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -225,6 +236,8 @@ static DocumentStoreType
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609851349
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -167,6 +169,8 @@ public class
mbaedke commented on code in PR #1454:
URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609849335
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -324,6 +346,11 @@ public T
reschke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124655346
but that doesn't help in all cases, for instance:
- when diffing with other branches that may have not been reformatted
- when trying to cherrypick changes to maintenance
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124643187
That's why we can put the formatting commits inside .git-blame-ignore-revs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124638076
@steffenvan, If you - for example during debugging - compare between
revisions to see what has changed and git will always tell you that
**everything** did, it's very annoying.
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124630432
@mbaedke how so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mbaedke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124613457
@steffenvan, it messes up diffs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124606686
I can see that deciding on _which_ formatter we should use could warrant a
bit of discussion. But I find it strange that **introducing** one would be
controversial. On the
steffenvan commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124597730
I put this as a draft just to test it and see how the PR would look like :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
reschke commented on PR #1476:
URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124571152
No.
This needs proper discussion in the Jackrabbit PMC and likely a vote because
it'll be controversial.
--
This is an automated message from the Apache Git Service.
To
stefan-egli commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609773530
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +43,59 @@
import
mbaedke commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2124542074
@jsedding , that actually makes sense.
@anchela, do you have specific worries about the diff? To me it looks
perfectly fine.
--
This is an automated message from the Apache
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609710827
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -161,8 +210,9 @@ private PropertyState
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609711000
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -172,8 +222,8 @@ PropertyState
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609710827
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -161,8 +210,9 @@ private PropertyState
rishabhdaim commented on code in PR #1473:
URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609709936
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##
@@ -38,24 +43,59 @@
import
reschke commented on code in PR #1427:
URL: https://github.com/apache/jackrabbit-oak/pull/1427#discussion_r1609655472
##
oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/package-info.java:
##
@@ -14,7 +14,7 @@
* See the License for the
reschke commented on code in PR #1427:
URL: https://github.com/apache/jackrabbit-oak/pull/1427#discussion_r1609608631
##
oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/package-info.java:
##
@@ -14,7 +14,7 @@
* See the License for the
smiroslav merged PR #1427:
URL: https://github.com/apache/jackrabbit-oak/pull/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos opened a new pull request, #1478:
URL: https://github.com/apache/jackrabbit-oak/pull/1478
This PR adds the `Information` section below.
```
...
oak.indexer.pipelined.sortBufferMemoryPercentage: 25
oak.indexer.pipelined.transformThreads: 2
jsedding commented on PR #1371:
URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2124026921
I read the spec on the subject of the `pid` in the `Designate` element and
found that the `pid` attribute is ignored if a `factoryPid` attribute is
present. Both, the
50 matches
Mail list logo
