Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1570656374 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,8 +429,20 @@ public Builder setDelayed(boolean isDelayed) {

[PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
mbaedke opened a new pull request, #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426 …x.IndexPlan done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] OAK-10767: oak-it-osgi unnecessarily deploys commons-collections to t… [jackrabbit-oak]

2024-04-17 Thread via GitHub
mbaedke opened a new pull request, #1425: URL: https://github.com/apache/jackrabbit-oak/pull/1425 …he test environment Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] OAK-10765 : use removeEldestEntry api for linkedhashmap to remove old… [jackrabbit-oak]

2024-04-17 Thread via GitHub
rishabhdaim opened a new pull request, #1424: URL: https://github.com/apache/jackrabbit-oak/pull/1424 … entries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10765 : fetch document with only min required fields to speed up … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim merged PR #1422: URL: https://github.com/apache/jackrabbit-oak/pull/1422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-6773: Convert oak-store-composite to OSGi R7 annotations [jackrabbit-oak]

2024-04-16 Thread via GitHub
mbaedke opened a new pull request, #1423: URL: https://github.com/apache/jackrabbit-oak/pull/1423 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] OAK-10765 : fetch document with only min required fields to speed up … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim commented on code in PR #1422: URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567245847 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1216,34 +1220,27 @@ private boolean

Re: [PR] OAK-10765 : fetch document with only min required fields to speed up … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim commented on code in PR #1422: URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567244664 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1216,34 +1220,27 @@ private boolean

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim merged PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10765 : fetch document with only min required fields to speed up … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim commented on code in PR #1422: URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567242893 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1216,34 +1220,27 @@ private boolean

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567211982 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1993,17 +1996,18 @@ private boolean

Re: [PR] OAK-10765 : fetch document with only min required fields to speed up … [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on code in PR #1422: URL: https://github.com/apache/jackrabbit-oak/pull/1422#discussion_r1567100681 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCSupport.java: ## @@ -226,6 +236,46 @@ public Optional

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim commented on PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#issuecomment-2058726467 Let me make some changes as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] OAK-10763 : non-gap orphans should not be applicable for other GC types [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli merged PR #1421: URL: https://github.com/apache/jackrabbit-oak/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567064532 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -96,7 +96,8 @@ public class RevisionsCommand implements Command {

Re: [PR] OAK-10751 : added compaction support in oak-run [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim merged PR #1419: URL: https://github.com/apache/jackrabbit-oak/pull/1419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim closed pull request #1418: OAK-10763 : fixed the skipping of orphan nodes in case parent is not … URL: https://github.com/apache/jackrabbit-oak/pull/1418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1567002054 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -96,7 +96,8 @@ public class RevisionsCommand implements Command {

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2058580981 As discussed offline I'd argue that an orphan node should be removed entirely - if a gc mode prevents that, it should be skipped. That makes verification stronger and keeps

Re: [PR] OAK-10751 : added compaction support in oak-run [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on code in PR #1419: URL: https://github.com/apache/jackrabbit-oak/pull/1419#discussion_r1566989140 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -349,28 +357,24 @@ private void printInfo(VersionGarbageCollector gc,

Re: [PR] OAK-10751 : added compaction support in oak-run [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on code in PR #1419: URL: https://github.com/apache/jackrabbit-oak/pull/1419#discussion_r1566992068 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -320,15 +330,13 @@ private VersionGarbageCollector

Re: [PR] OAK-10751 : added compaction support in oak-run [jackrabbit-oak]

2024-04-16 Thread via GitHub
stefan-egli commented on code in PR #1419: URL: https://github.com/apache/jackrabbit-oak/pull/1419#discussion_r1566990954 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -349,28 +357,24 @@ private void printInfo(VersionGarbageCollector gc,

[PR] OAK-10765 : fetch document with only min required fields to speed up … [jackrabbit-oak]

2024-04-16 Thread via GitHub
rishabhdaim opened a new pull request, #1422: URL: https://github.com/apache/jackrabbit-oak/pull/1422 …verfication of orphan nodes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] OAK-10764 : speed up gap orphan detection by limiting it to only the direct child of the greatest existing ancestor [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim merged PR #1420: URL: https://github.com/apache/jackrabbit-oak/pull/1420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566254677 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057530328 With https://github.com/apache/jackrabbit-oak/pull/1421 PR, we are skipping the opportunity to clean other types of garbage. If we want to go via

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566221648 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract

Re: [PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on PR #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418#issuecomment-2057474619 also note my alternative PR suggestion at https://github.com/apache/jackrabbit-oak/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566077327 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract

[PR] OAK-10751 : added compaction support in oak-run [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1419: URL: https://github.com/apache/jackrabbit-oak/pull/1419 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] OAK-10763 : fixed the skipping of orphan nodes in case parent is not … [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1418: URL: https://github.com/apache/jackrabbit-oak/pull/1418 …existing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566077327 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract

Re: [PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on code in PR #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417#discussion_r1566049288 ## oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java: ## @@ -50,6 +52,7 @@ * alternatives. */ public abstract

[PR] OAK-10753 : added AUDIT logger for DetailedGC [jackrabbit-oak]

2024-04-15 Thread via GitHub
rishabhdaim opened a new pull request, #1417: URL: https://github.com/apache/jackrabbit-oak/pull/1417 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10761 : start gap test after greatest existing ancestor [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli merged PR #1414: URL: https://github.com/apache/jackrabbit-oak/pull/1414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10761 : start gap test after greatest existing ancestor [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on PR #1414: URL: https://github.com/apache/jackrabbit-oak/pull/1414#issuecomment-2057091565 this test was known to fail in the branch and is thus not related to this PR: ``` [INFO] Running

[PR] OAK-10762: dynamic boosted tags need to specify extra parameters [jackrabbit-oak]

2024-04-15 Thread via GitHub
fabriziofortino opened a new pull request, #1416: URL: https://github.com/apache/jackrabbit-oak/pull/1416 Similar queries leveraging dynamic tags might not produce relevant results in Elasticsearch. This happens because the default minimum term frequency in mlt queries is 2 while usually

[PR] OAK-6761: Convert oak-blob-plugins to OSGi R7 annotations [jackrabbit-oak]

2024-04-15 Thread via GitHub
mbaedke opened a new pull request, #1415: URL: https://github.com/apache/jackrabbit-oak/pull/1415 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] OAK-6762: Convert oak-blob to OSGi R7 annotations [jackrabbit-oak]

2024-04-15 Thread via GitHub
mbaedke opened a new pull request, #1413: URL: https://github.com/apache/jackrabbit-oak/pull/1413 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator [jackrabbit-oak]

2024-04-15 Thread via GitHub
stefan-egli commented on code in PR #1409: URL: https://github.com/apache/jackrabbit-oak/pull/1409#discussion_r1565623561 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -867,6 +880,8 @@ &&

Re: [PR] repro test for issue OAK-10544; currently fails for Oak but passes for… [jackrabbit-filevault]

2024-04-12 Thread via GitHub
reschke commented on PR #330: URL: https://github.com/apache/jackrabbit-filevault/pull/330#issuecomment-2051413314 I just verified that when we test with OA 1.62.0, the test passes (it still fails for oak.min.version). -- This is an automated message from the Apache Git Service. To

[PR] OAK-10759: JavaDoc of o.a.j.o.namepath.PathMapper is inaccurate [jackrabbit-oak]

2024-04-11 Thread via GitHub
mbaedke opened a new pull request, #1412: URL: https://github.com/apache/jackrabbit-oak/pull/1412 Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] OAK-10694: Remove oak-search-mt [jackrabbit-oak]

2024-04-09 Thread via GitHub
reschke merged PR #1410: URL: https://github.com/apache/jackrabbit-oak/pull/1410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10755: commons: deprecate use of slf4j.event.Level in SystemPropertySupplier API (and make it 'internal') [jackrabbit-oak]

2024-04-09 Thread via GitHub
reschke merged PR #1408: URL: https://github.com/apache/jackrabbit-oak/pull/1408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10730 : log a warn for a MongoException previously swallowed [jackrabbit-oak]

2024-04-09 Thread via GitHub
stefan-egli commented on PR #1399: URL: https://github.com/apache/jackrabbit-oak/pull/1399#issuecomment-2045237002 thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] OAK-10705: oak-standalone: update dependencies [jackrabbit-oak]

2024-04-09 Thread via GitHub
mbaedke opened a new pull request, #1411: URL: https://github.com/apache/jackrabbit-oak/pull/1411 Updated dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10730 : log a warn for a MongoException previously swallowed [jackrabbit-oak]

2024-04-09 Thread via GitHub
reschke merged PR #1399: URL: https://github.com/apache/jackrabbit-oak/pull/1399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10694: Remove oak-search-mt [jackrabbit-oak]

2024-04-09 Thread via GitHub
reschke opened a new pull request, #1410: URL: https://github.com/apache/jackrabbit-oak/pull/1410 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10757: DocumentRdbFixture does not support the Feature Toggle FT_… [jackrabbit-oak]

2024-04-09 Thread via GitHub
mbaedke merged PR #1407: URL: https://github.com/apache/jackrabbit-oak/pull/1407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10758: Proposal: Add system property to control noCursorTimeout [jackrabbit-oak]

2024-04-08 Thread via GitHub
Joscorbe opened a new pull request, #1409: URL: https://github.com/apache/jackrabbit-oak/pull/1409 This is just a proposal to solve https://issues.apache.org/jira/browse/OAK-10758 Another proposal PR is coming, that improves exception handling to avoid crashing when this exception

[PR] OAK-10755: commons: deprecate use of slf4j.event.Level in SystemPropertySupplier API (and make it 'internal') [jackrabbit-oak]

2024-04-08 Thread via GitHub
reschke opened a new pull request, #1408: URL: https://github.com/apache/jackrabbit-oak/pull/1408 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] OAK-10757: DocumentRdbFixture does not support the Feature Toggle FT_… [jackrabbit-oak]

2024-04-08 Thread via GitHub
mbaedke opened a new pull request, #1407: URL: https://github.com/apache/jackrabbit-oak/pull/1407 …NOCOCLEANUP_OAK-10660 Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] OAK-10756: OrderableNodesTest.childOrderCleanupFeatureToggleTest fail… [jackrabbit-oak]

2024-04-08 Thread via GitHub
mbaedke merged PR #1406: URL: https://github.com/apache/jackrabbit-oak/pull/1406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10756: OrderableNodesTest.childOrderCleanupFeatureToggleTest fail… [jackrabbit-oak]

2024-04-07 Thread via GitHub
mbaedke opened a new pull request, #1406: URL: https://github.com/apache/jackrabbit-oak/pull/1406 …s with -Dnsfixtures=DOCUMENT_NS Fixed test classes to not reuse an existing whiteboard with a newly created NodeStore. -- This is an automated message from the Apache Git Service. To

Re: [PR] OAK-10754: webapp: update Tomcat dependency to 9.0.87 [jackrabbit-oak]

2024-04-05 Thread via GitHub
reschke merged PR #1405: URL: https://github.com/apache/jackrabbit-oak/pull/1405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10574: webapp: update Tomcat dependency to 9.0.87 [jackrabbit-oak]

2024-04-05 Thread via GitHub
reschke opened a new pull request, #1405: URL: https://github.com/apache/jackrabbit-oak/pull/1405 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-05 Thread via GitHub
rishabhdaim merged PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-05 Thread via GitHub
rishabhdaim commented on PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#issuecomment-2039298688 Created a separate jira for audit logger OAK-10753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] OAK-10752: update Tomcat JDBC dependency to 9.0.87 [jackrabbit-oak]

2024-04-05 Thread via GitHub
reschke merged PR #1403: URL: https://github.com/apache/jackrabbit-oak/pull/1403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli commented on PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#issuecomment-2037865358 (Sorry about the conflict I caused with OAK-10743!) I think we should revisit what we want in the audit log and what in the normal log. Initially thought the audit log

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli commented on code in PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#discussion_r1552193622 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1664,21 +1687,22 @@ public void close()

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli commented on code in PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#discussion_r1552193207 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1613,8 +1636,8 @@ private int

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli commented on code in PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#discussion_r1552190663 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1637,8 +1660,8 @@ private int

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli commented on code in PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#discussion_r1552185203 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1048,8 +1061,9 @@ public void

Re: [PR] OAK-10743 : gap orphan mode introduced - gc modes added, refined and … [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli merged PR #1404: URL: https://github.com/apache/jackrabbit-oak/pull/1404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
rishabhdaim commented on PR #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402#issuecomment-2037793527 Logging into 2 separate log files would be an overkill. We should keep the `error` log in the normal logger. -- This is an automated message from the Apache Git Service. To

[PR] OAK-10743 : gap orphan mode introduced - gc modes added, refined and … [jackrabbit-oak]

2024-04-04 Thread via GitHub
stefan-egli opened a new pull request, #1404: URL: https://github.com/apache/jackrabbit-oak/pull/1404 …renamed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] OAK-10752: update Tomcat JDBC dependency to 9.0.87 [jackrabbit-oak]

2024-04-04 Thread via GitHub
reschke opened a new pull request, #1403: URL: https://github.com/apache/jackrabbit-oak/pull/1403 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] OAK-10741 : added separate logger for detailed gc [jackrabbit-oak]

2024-04-04 Thread via GitHub
rishabhdaim opened a new pull request, #1402: URL: https://github.com/apache/jackrabbit-oak/pull/1402 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10740 : added metrics for orphan nodes deletion [jackrabbit-oak]

2024-04-04 Thread via GitHub
rishabhdaim merged PR #1401: URL: https://github.com/apache/jackrabbit-oak/pull/1401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10740 : added metrics for orphan nodes deletion [jackrabbit-oak]

2024-04-03 Thread via GitHub
rishabhdaim opened a new pull request, #1401: URL: https://github.com/apache/jackrabbit-oak/pull/1401 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
rishabhdaim merged PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
rishabhdaim commented on PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#issuecomment-2034490667 It could be the case, since now we are collecting the stats in dry run mode. Let me update the test cases. -- This is an automated message from the Apache Git Service. To

Re: [PR] OAK-10199 : some code cleanups [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli merged PR #1400: URL: https://github.com/apache/jackrabbit-oak/pull/1400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10199 : some code cleanups [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli opened a new pull request, #1400: URL: https://github.com/apache/jackrabbit-oak/pull/1400 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#issuecomment-2034420196 two tests now fail: `VersionGarbageCollectorIT.testGCDeletedPropsWithDryRunMode`, `VersionGarbageCollectorIT.testDeletedPropsAndUnmergedBCWithCollisionWithDryRunMode`, as

Re: [PR] OAK-10375: remove binary data from logs [jackrabbit-oak]

2024-04-03 Thread via GitHub
fabriziofortino merged PR #1353: URL: https://github.com/apache/jackrabbit-oak/pull/1353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
rishabhdaim commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549579123 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -148,17 +148,17 @@ public class

Re: [PR] OAK-10730 : log a warn for a MongoException previously swallowed [jackrabbit-oak]

2024-04-03 Thread via GitHub
reschke commented on PR #1399: URL: https://github.com/apache/jackrabbit-oak/pull/1399#issuecomment-2034305471 ITs: I was referring just to Oak ITs... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549515657 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -148,17 +148,17 @@ public class

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549510480 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -148,17 +148,17 @@ public class

Re: [PR] OAK-10730 : log a warn for a MongoException previously swallowed [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on PR #1399: URL: https://github.com/apache/jackrabbit-oak/pull/1399#issuecomment-2034271564 There is code that asserts that `ds.create()` returns false - eg

Re: [PR] OAK-10730 : log a warn for a MongoException previously swallowed [jackrabbit-oak]

2024-04-03 Thread via GitHub
reschke commented on code in PR #1399: URL: https://github.com/apache/jackrabbit-oak/pull/1399#discussion_r1549479842 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java: ## @@ -1752,6 +1752,8 @@ public boolean

[PR] OAK-10730 : log a warn for a MongoException previously swallowed [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli opened a new pull request, #1399: URL: https://github.com/apache/jackrabbit-oak/pull/1399 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-04-03 Thread via GitHub
reschke merged PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-04-03 Thread via GitHub
reschke commented on code in PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#discussion_r1549461742 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java: ## @@ -352,7 +352,11 @@ private void

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on code in PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#discussion_r1549457402 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java: ## @@ -352,7 +352,11 @@ private void

Re: [PR] OAK-10733 | Filter out hidden properties while creating FlatFileStore [jackrabbit-oak]

2024-04-03 Thread via GitHub
nit0906 merged PR #1398: URL: https://github.com/apache/jackrabbit-oak/pull/1398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
rishabhdaim commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549322529 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1770,6 +1770,21 @@ public void

Re: [PR] OAK-10375: remove binary data from logs [jackrabbit-oak]

2024-04-03 Thread via GitHub
steffenvan commented on code in PR #1353: URL: https://github.com/apache/jackrabbit-oak/pull/1353#discussion_r1549306734 ## oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextDocumentMaker.java: ## @@ -317,7 +318,9 @@ private boolean

Re: [PR] OAK-10708: error-level log failures to write the journal [jackrabbit-oak]

2024-04-03 Thread via GitHub
reschke commented on PR #1363: URL: https://github.com/apache/jackrabbit-oak/pull/1363#issuecomment-2033993319 Like that? ~~~ if (!success) { LOG.error("Failed to update journal for revision {}", r); LOG.debug("Failed to update

Re: [PR] OAK-10375: remove binary data from logs [jackrabbit-oak]

2024-04-03 Thread via GitHub
fabriziofortino commented on code in PR #1353: URL: https://github.com/apache/jackrabbit-oak/pull/1353#discussion_r1549303728 ## oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextDocumentMaker.java: ## @@ -317,7 +318,9 @@ private boolean

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549228836 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1770,6 +1770,21 @@ public void

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549228836 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -1770,6 +1770,21 @@ public void

Re: [PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-03 Thread via GitHub
stefan-egli commented on code in PR #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397#discussion_r1549226833 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -155,10 +155,10 @@ static enum RDGCType {

Re: [PR] OAK-10733 | Filter out hidden properties while creating FlatFileStore [jackrabbit-oak]

2024-04-03 Thread via GitHub
nit0906 commented on code in PR #1398: URL: https://github.com/apache/jackrabbit-oak/pull/1398#discussion_r1549144950 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/NodeDocumentCodec.java: ## @@ -81,7 +81,12 @@ public

Re: [PR] OAK-10733 | Filter out hidden properties while creating FlatFileStore [jackrabbit-oak]

2024-04-03 Thread via GitHub
nfsantos commented on code in PR #1398: URL: https://github.com/apache/jackrabbit-oak/pull/1398#discussion_r1548987562 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/NodeDocumentCodec.java: ## @@ -81,7 +81,12 @@ public

Re: [PR] OAK-10733 | Filter out hidden properties while creating FlatFileStore [jackrabbit-oak]

2024-04-03 Thread via GitHub
nfsantos commented on code in PR #1398: URL: https://github.com/apache/jackrabbit-oak/pull/1398#discussion_r1548987562 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/NodeDocumentCodec.java: ## @@ -81,7 +81,12 @@ public

[PR] OAK-10733 | Filter out hidden properties while creating FlatFileStore [jackrabbit-oak]

2024-04-02 Thread via GitHub
nit0906 opened a new pull request, #1398: URL: https://github.com/apache/jackrabbit-oak/pull/1398 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] OAK-10736 : collect detailedGC stats for dryRun mode as well [jackrabbit-oak]

2024-04-02 Thread via GitHub
rishabhdaim opened a new pull request, #1397: URL: https://github.com/apache/jackrabbit-oak/pull/1397 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    3   4   5   6   7   8   9   10   11   12   >