[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1011: OAK-10334: Node.addMixin() may overwrite existing mixins

2023-08-25 Thread via GitHub
mreutegg commented on code in PR #1011: URL: https://github.com/apache/jackrabbit-oak/pull/1011#discussion_r1305248336 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java: ## @@ -1015,6 +1015,9 @@ public void checkPreconditions() throws

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1011: OAK-10334: Node.addMixin() may overwrite existing mixins

2023-08-24 Thread via GitHub
mreutegg commented on code in PR #1011: URL: https://github.com/apache/jackrabbit-oak/pull/1011#discussion_r1304259012 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java: ## @@ -1015,6 +1015,9 @@ public void checkPreconditions() throws

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #1011: OAK-10334: Node.addMixin() may overwrite existing mixins

2023-08-22 Thread via GitHub
mreutegg commented on code in PR #1011: URL: https://github.com/apache/jackrabbit-oak/pull/1011#discussion_r1301427100 ## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java: ## @@ -1015,6 +1015,9 @@ public void checkPreconditions() throws