Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-27 Thread via GitHub
fabriziofortino merged PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-27 Thread via GitHub
fabriziofortino commented on code in PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1504204826 ## oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java: ## @@ -436,4 +437,12 @@ public static

Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-27 Thread via GitHub
fabriziofortino commented on code in PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1504202939 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -52,8 +53,12 @@ class

Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-26 Thread via GitHub
nfsantos commented on code in PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503753351 ## oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/FulltextIndexConstants.java: ## @@ -436,4 +437,12 @@ public static IndexingMode

Re: [PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-26 Thread via GitHub
steffenvan commented on code in PR #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327#discussion_r1503743424 ## oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java: ## @@ -52,8 +53,12 @@ class

[PR] OAK-10672: move internal index version in oak-search [jackrabbit-oak]

2024-02-26 Thread via GitHub
fabriziofortino opened a new pull request, #1327: URL: https://github.com/apache/jackrabbit-oak/pull/1327 Some indexes, like elasticsearch have a concept of an internal version (or mapping version) to handle breaking changes. This information is sometimes needed from external tools that do