Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-10 Thread via GitHub
mbaedke merged PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-10 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1596603024 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -361,17 +364,32 @@ default boolean logWarningForPathFilterMismatch() {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-10 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1596602825 ## oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java: ## @@ -555,25 +555,25 @@ private void logAdditionalMessages() { for (SelectorI

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-10 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1596559539 ## oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java: ## @@ -555,25 +555,25 @@ private void logAdditionalMessages() { for (SelectorI

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-03 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1588980951 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,7 +433,33 @@ public Builder setDelayed(boolean isDelayed) {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-03 Thread via GitHub
reschke commented on PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#issuecomment-2092616593 Yes, but we want to be able to discover code components using this.Am 03.05.2024 10:49 schrieb mbaedke ***@***.***>: @mbaedke commented on this pull request. In o

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-03 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1588922821 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -361,17 +364,32 @@ default boolean logWarningForPathFilterMismatch() {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-05-01 Thread via GitHub
rishabhdaim commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1586002212 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -361,17 +364,32 @@ default boolean logWarningForPathFilterMismatch(

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-22 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1574451884 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,8 +430,20 @@ public Builder setDelayed(boolean isDelayed) {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-22 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1574433621 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -361,12 +362,26 @@ default boolean logWarningForPathFilterMismatch() {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-22 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1574321474 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,8 +430,20 @@ public Builder setDelayed(boolean isDelayed) {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-22 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1574321474 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,8 +430,20 @@ public Builder setDelayed(boolean isDelayed) {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-22 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1574314406 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -361,12 +362,26 @@ default boolean logWarningForPathFilterMismatch() {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1570668442 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/package-info.java: ## @@ -18,7 +18,7 @@ /** * This package contains oak query index related

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
mbaedke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1570663077 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,8 +429,20 @@ public Builder setDelayed(boolean isDelayed) {

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1570657817 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/package-info.java: ## @@ -18,7 +18,7 @@ /** * This package contains oak query index related

Re: [PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
reschke commented on code in PR #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426#discussion_r1570656374 ## oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryIndex.java: ## @@ -415,8 +429,20 @@ public Builder setDelayed(boolean isDelayed) {

[PR] OAK-10768: query-spi: deprecate use of slf4j.event.Level in QueryInde… [jackrabbit-oak]

2024-04-18 Thread via GitHub
mbaedke opened a new pull request, #1426: URL: https://github.com/apache/jackrabbit-oak/pull/1426 …x.IndexPlan done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T