[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099012#comment-17099012
]
Julian Reschke commented on JCR-3555:
-
trunk: (2.9.0) [r1463890|http://svn.apache.org/r1463890]
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620693#comment-13620693
]
Jukka Zitting commented on JCR-3555:
Hmm, you're right. Now that I look at the code in
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620706#comment-13620706
]
Lukas Eder commented on JCR-3555:
-
+1 for naming the utility method in(). That makes it very
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620710#comment-13620710
]
Jukka Zitting commented on JCR-3555:
Sounds like we're converging on consensus here.
In
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620727#comment-13620727
]
Michael Dürig commented on JCR-3555:
+1 for IllegalStateException instead of
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620735#comment-13620735
]
Jukka Zitting commented on JCR-3555:
Perhaps something like this:
public class
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620738#comment-13620738
]
Michael Dürig commented on JCR-3555:
Exactly!
Add a static utility to
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620784#comment-13620784
]
Jukka Zitting commented on JCR-3555:
Nice work! Patch applied in revision 1463890.
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620789#comment-13620789
]
Lukas Eder commented on JCR-3555:
-
Thanks. That'll only leave us with the open question of
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619705#comment-13619705
]
Jukka Zitting commented on JCR-3555:
A method like the iterable() you're proposing is a
[
https://issues.apache.org/jira/browse/JCR-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619723#comment-13619723
]
Lukas Eder commented on JCR-3555:
-
I agree that using the term iterable can be misleading.
11 matches
Mail list logo