[GitHub] jena issue #409: JENA-1534: Test for filter-only variables in EXISTS.

2018-04-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/409 Learning a bit more of Jena internals (weather is really bad here in the antipodes :-) ). So picked this PR to review, so that I could learn more about Jena internals. Had a look at the

[jira] [Commented] (JENA-1534) Variables in EXISTS must be considered for the join strategy

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457267#comment-16457267 ] ASF GitHub Bot commented on JENA-1534: -- Github user kinow commented on the issue:

[jira] [Commented] (JENA-1535) riot argument "--syntax" should be used as syntax, not as a hint.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457186#comment-16457186 ] ASF GitHub Bot commented on JENA-1535: -- Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #410: JENA-1535: Parse a specified language if given --syn...

2018-04-27 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/410#discussion_r184823377 --- Diff: jena-cmds/src/main/java/riotcmd/CmdLangParse.java --- @@ -218,8 +218,14 @@ public ParseRecord parseFile(String filename) { RDFParserBuilder

[jira] [Commented] (JENA-1535) riot argument "--syntax" should be used as syntax, not as a hint.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457177#comment-16457177 ] ASF GitHub Bot commented on JENA-1535: -- Github user kinow commented on a diff in the pull request:

[GitHub] jena pull request #410: JENA-1535: Parse a specified language if given --syn...

2018-04-27 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/410#discussion_r184821458 --- Diff: jena-cmds/src/main/java/riotcmd/CmdLangParse.java --- @@ -218,8 +218,14 @@ public ParseRecord parseFile(String filename) {

[GitHub] jena pull request #410: JENA-1535: Parse a specified language if given --syn...

2018-04-27 Thread afs
GitHub user afs opened a pull request: https://github.com/apache/jena/pull/410 JENA-1535: Parse a specified language if given --syntax. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena riot-syntax Alternatively you can

[jira] [Commented] (JENA-1535) riot argument "--syntax" should be used as syntax, not as a hint.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457175#comment-16457175 ] ASF GitHub Bot commented on JENA-1535: -- GitHub user afs opened a pull request:

[jira] [Created] (JENA-1535) riot argument "--syntax" should be used as syntax, not as a hint.

2018-04-27 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-1535: --- Summary: riot argument "--syntax" should be used as syntax, not as a hint. Key: JENA-1535 URL: https://issues.apache.org/jira/browse/JENA-1535 Project: Apache Jena

[jira] [Commented] (JENA-1534) Variables in EXISTS must be considered for the join strategy

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456867#comment-16456867 ] ASF GitHub Bot commented on JENA-1534: -- GitHub user afs opened a pull request:

[GitHub] jena pull request #409: JENA-1534: Test for filter-only variables in EXISTS.

2018-04-27 Thread afs
GitHub user afs opened a pull request: https://github.com/apache/jena/pull/409 JENA-1534: Test for filter-only variables in EXISTS. Tighten the classifer, assumes proper use of (sequence) Relates to JENA-1167, JENA-1280. You can merge this pull request into a Git repository by

[jira] [Created] (JENA-1534) Variables in EXISTS must be considered for the join strategy

2018-04-27 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-1534: --- Summary: Variables in EXISTS must be considered for the join strategy Key: JENA-1534 URL: https://issues.apache.org/jira/browse/JENA-1534 Project: Apache Jena

Re: new branch for JPMS?

2018-04-27 Thread Andy Seaborne
Such a repacking is a "Jena 4" and if we're doing Jena4 the community will which so consider other changes as well. In order to experiment with JPMS, it does not need a branch in the codebase - you can clone and develop in a separate github repository now. There is no barrier. There are

Re: new branch for JPMS?

2018-04-27 Thread Christopher Johnson
Hi, JPMS is certainly a major change. I believe that it offers enormous value to a codebase with strong encapsulation and as such it is similar to OSGI. The benefits of OSGI are well known, though the implementations are fraught with complexity. Comparatively, JPMS is relatively simple.

Re: new branch for JPMS?

2018-04-27 Thread Rob Vesse
I am in the same boat, this sounds like it would quickly become a maintenance headache. We don't have the time or people to maintain more than one branch, particularly if that branch would be a significant refactor of the code I am afraid that JPMS is going to kill Java open source efforts in

Re: new branch for JPMS?

2018-04-27 Thread ajs6f
I'm not sure how this new branch is supposed to work. If it "just contains modules compliant with the JPMS and that is tested for JDK9+" but the current (Maven) modules don't have a one-to-one correspondence with usable JPMS modules, where are the "modules" for this new branch coming from? Are

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456243#comment-16456243 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on the issue:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456244#comment-16456244 ] ASF GitHub Bot commented on JENA-632: - Github user asfgit closed the pull request at:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456242#comment-16456242 ] ASF subversion and git services commented on JENA-632: -- Commit

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 Branch created: [JENA-632-before-merge](https://github.com/kinow/jena/tree/JENA-632-before-merge). Won't delete it this year, in case we need to revisit. Followed that by: ``` $

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/114 ---

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456215#comment-16456215 ] ASF GitHub Bot commented on JENA-632: - Github user afs commented on the issue:

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/114 That works for me. ---

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456212#comment-16456212 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on the issue:

[GitHub] jena issue #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/114 :tada: should I proceed with the merging? If so, I will squash the 18 commits into a single one before, as said before, but with a backup branch just-in-case. And then start working on the documentation

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456194#comment-16456194 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184646447 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456187#comment-16456187 ] ASF GitHub Bot commented on JENA-632: - Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184644548 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456169#comment-16456169 ] ASF GitHub Bot commented on JENA-632: - Github user kinow commented on a diff in the pull request:

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184639752 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456139#comment-16456139 ] ASF GitHub Bot commented on JENA-632: - Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-632) Generate JSON from SPARQL directly.

2018-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456138#comment-16456138 ] ASF GitHub Bot commented on JENA-632: - Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184631546 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)

[GitHub] jena pull request #114: JENA-632: Generate JSON from SPARQL directly

2018-04-27 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/114#discussion_r184631233 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/serializer/QuerySerializer.java --- @@ -142,7 +144,19 @@ public void visitAskResultForm(Query query)