[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514250#comment-16514250 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on the issue:

[GitHub] jena issue #436: JENA-1556 implementation

2018-06-15 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/436 @kinow I think the configuration and results reflect the `text:searchFor` functionality; however, in the analyzer defn for the tag `jp`: text:analyzer [ a

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-06-15 Thread Maxime Lefrançois
Some comments: > > Add use of the standard Java Service Provider API to load things > automatically found in the classpath: > > > > - In TypeMapper --> a method that uses the Service Provider API to find > more Datatypes > > Should this be a method, or rather additional behavior for

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513857#comment-16513857 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on a diff in the pull request:

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195745831 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/QueryMultilingualAnalyzer.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-06-15 Thread ajs6f
See comments in-line... ajs6f > On Jun 15, 2018, at 9:49 AM, Maxime Lefrançois > wrote: > > Dear all, > > Regarding our contribution proposal to enable extensions to override SPARQL > operators in Jena > > We finally got the agreement from our institution to contribute to the Apache >

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513848#comment-16513848 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on a diff in the pull request:

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195743299 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/DefineAnalyzersAssembler.java --- @@ -39,7 +44,46 @@ text:analyzer [

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513844#comment-16513844 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on a diff in the pull request:

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195742866 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/QueryMultilingualAnalyzer.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the

Re: Contribution proposal for Jena: support of a datatype for quantity values

2018-06-15 Thread Maxime Lefrançois
Dear all, Regarding our contribution proposal to enable extensions to override SPARQL operators in Jena We finally got the agreement from our institution to contribute to the Apache foundation. Question 1: what is the procedure to upload the form? About the how, I would like to discuss first

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513829#comment-16513829 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on a diff in the pull request:

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195738825 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -549,56 +567,81 @@ private String frags2string(TextFragment[] frags,

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513822#comment-16513822 ] ASF GitHub Bot commented on JENA-1556: -- Github user xristy commented on a diff in the pull request:

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195736987 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -316,6 +326,13 @@ protected Document doc(Entity entity) {

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513774#comment-16513774 ] ASF GitHub Bot commented on JENA-1556: -- Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513775#comment-16513775 ] ASF GitHub Bot commented on JENA-1556: -- Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513777#comment-16513777 ] ASF GitHub Bot commented on JENA-1556: -- Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513773#comment-16513773 ] ASF GitHub Bot commented on JENA-1556: -- Github user kinow commented on a diff in the pull request:

[jira] [Commented] (JENA-1556) text:query multilingual enhancements

2018-06-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513776#comment-16513776 ] ASF GitHub Bot commented on JENA-1556: -- Github user kinow commented on a diff in the pull request:

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195659829 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/QueryMultilingualAnalyzer.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195659628 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/QueryMultilingualAnalyzer.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195658758 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -316,6 +326,13 @@ protected Document doc(Entity entity) {

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195660039 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/DefineAnalyzersAssembler.java --- @@ -39,7 +44,46 @@ text:analyzer [ .

[GitHub] jena pull request #436: JENA-1556 implementation

2018-06-15 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/jena/pull/436#discussion_r195659038 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -549,56 +567,81 @@ private String frags2string(TextFragment[] frags,