[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634772#comment-16634772 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue:

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Thanks @afs I looked at the build and built locally using the following parameters ``` mvn clean verify -Pdev ``` ... it results in SUCCESSFUL build. ---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634754#comment-16634754 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221785452 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - -

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634579#comment-16634579 ] ASF GitHub Bot commented on JENA-1609: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221745287 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - -

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634578#comment-16634578 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221744935 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - -

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634561#comment-16634561 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on the issue:

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 See https://builds.apache.org/view/H-L/view/Jena/job/Jena_JDK11/ which builds with -Pdev and has been running for a while. It does not build jena-jdbc or jena-elephas both of which are need looking at.

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634554#comment-16634554 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221738972 --- Diff: jena-arq/pom.xml --- @@ -216,6 +216,7 @@ Licenced under the Apache License, Version 2.0 +

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634542#comment-16634542 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue:

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Thats good to know @acoburn thanks for chiming in. ---

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread acoburn
Github user acoburn commented on the issue: https://github.com/apache/jena/pull/474 It is possibly worth noting here that these changes also make it possible to build Jena on JDK 11. ---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634518#comment-16634518 ] ASF GitHub Bot commented on JENA-1609: -- Github user acoburn commented on the issue:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221726413 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - -

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634511#comment-16634511 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on a diff in the pull request:

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634512#comment-16634512 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue:

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Thanks for comments @ajs6f ---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634508#comment-16634508 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221725604 --- Diff: jena-elephas/jena-elephas-mapreduce/src/main/java/org/apache/jena/hadoop/rdf/mapreduce/filter/AbstractNodeTupleFilterMapper.java --- @@ -28,9 +28,7

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634503#comment-16634503 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221725050 --- Diff: jena-arq/pom.xml --- @@ -216,6 +216,7 @@ Licenced under the Apache License, Version 2.0 +

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634468#comment-16634468 ] ASF GitHub Bot commented on JENA-1609: -- Github user ajs6f commented on a diff in the pull request:

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634469#comment-16634469 ] ASF GitHub Bot commented on JENA-1609: -- Github user ajs6f commented on a diff in the pull request:

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634467#comment-16634467 ] ASF GitHub Bot commented on JENA-1609: -- Github user ajs6f commented on a diff in the pull request:

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634466#comment-16634466 ] ASF GitHub Bot commented on JENA-1609: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221716224 --- Diff: jena-jdbc/jena-jdbc-core/pom.xml --- @@ -39,17 +39,28 @@ 3.10.0-SNAPSHOT - - -

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221715600 --- Diff: jena-arq/pom.xml --- @@ -216,6 +216,7 @@ Licenced under the Apache License, Version 2.0 +

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221716057 --- Diff: jena-elephas/jena-elephas-mapreduce/src/main/java/org/apache/jena/hadoop/rdf/mapreduce/filter/AbstractNodeTupleFilterMapper.java --- @@ -28,9 +28,7

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/474#discussion_r221715434 --- Diff: .gitignore --- @@ -14,7 +14,10 @@ buildNumber.properties .project .settings .recommenders -.metadata +.metadat --- End diff

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634457#comment-16634457 ] ASF GitHub Bot commented on JENA-1609: -- GitHub user lewismc opened a pull request:

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/jena/pull/474 JENA-1609 Jena master does not build under JDK10 This PR addresses https://issues.apache.org/jira/browse/JENA-1609 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread Lewis John McGibbney (JIRA)
Lewis John McGibbney created JENA-1609: -- Summary: Jena master does not build under JDK10 Key: JENA-1609 URL: https://issues.apache.org/jira/browse/JENA-1609 Project: Apache Jena Issue

[jira] [Commented] (JENA-1601) Make ClosableIterator extend AutoCloseable

2018-10-01 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634346#comment-16634346 ] Andy Seaborne commented on JENA-1601: - SDB is (I believe) little used these days. If anyone wants to

Re: [VOTE] Apache Jena 3.9.0 RC1

2018-10-01 Thread ajs6f
> On 29/09/18 10:22, Andy Seaborne wrote: > >> Please vote to approve this release: +1 Approve the release Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00) Java version: 1.8.0_65, vendor: Oracle Corporation OS name: "mac os x", version: "10.13.6", arch:

Re: of isomorphism and AdhocDatatypes

2018-10-01 Thread Andy Seaborne
On 01/10/18 07:52, Claude Warren wrote: I resolved it by following the Don't Do That pattern and not loading the datatype twice. Event with hashCode and equals on the datatype it does not match as the datatype equality is checked with ==. I will find and document the issue here. Good - my

[GitHub] jena pull request #473: Extendable versions of classes for printing result s...

2018-10-01 Thread hartig
GitHub user hartig opened a pull request: https://github.com/apache/jena/pull/473 Extendable versions of classes for printing result sets This PR modifies the classes `CSVOutput` and `TSVOutput` to make it possible to extend them and override their behavior in subclasses. I want to

Re: of isomorphism and AdhocDatatypes

2018-10-01 Thread Claude Warren
I resolved it by following the Don't Do That pattern and not loading the datatype twice. Event with hashCode and equals on the datatype it does not match as the datatype equality is checked with ==. I will find and document the issue here. But I am leaning toward the type registry issuing a

[jira] [Commented] (JENA-1601) Make ClosableIterator extend AutoCloseable

2018-10-01 Thread JIRA
[ https://issues.apache.org/jira/browse/JENA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633643#comment-16633643 ] David Schwingenschlögl commented on JENA-1601: -- After consulting my collegue, the issues we