Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
Required reverts done, #313 applied and `ja:MemoryDataset` made the primary
type name for TIM assembler.
---
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/314
Okay, then let's break this thing up, as you describe above. Your number 2
and 3 are uncontroversial. As for number 1, sure, I want that fix too, but this
PR (#314) didn't do just that. It also
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
I'm certainly willing to discuss it, that's what JENA-1445 is about and we
can rename it to be more accurate.
I'm not able to agree to the details at this stage. I have several
outstanding
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/314
1. The two different datasets at TIM and general. The fact that the code
for the general dataset assembler doesn't mention `ja:data` is fine, but
because TIM's assembler does understand `ja:data` and
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
Can we separate the different parts of this and unblock 3.6.0?
Is the following acceptable for 3.6.0:
1. #314 fixed a specific problem - `` and "filename" behave
differently for
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
`ja:data` isn't mentioned in `DatasetAssembler` except to redirect to TIM.
Which two different kinds of dataset?
Would you like to move `public static final Property data = property(
"data" );`
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/314
I'm saying that `ja:data` is now used for loading quads into two different
kinds of datasets, but loading triples into only one. That's confusing at best.
I want to make it clearer by getting rid of the
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
@ajs6f I do not understand your point - it is to abstract talking about
"predicates". Some examples maybe?
How do you deprecate in Turtle assembler files?
`ja:graph` isn't unused by TIM.
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/314
Ouch! I realize I wasn't clear enough at all in my last comment: I was
actually -1 on this. I think the confusion that `ja:data` now has in its
semantics is too much, and I completely disagree with:
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
Merged in order to progress Jena 3.6.0.
---
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/314
@afs What do you think of that? It's clearer, I think, along the lines [you
suggested](https://github.com/apache/jena/pull/314#discussion_r152289270).
---
11 matches
Mail list logo