[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-20 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/385 Workflow doucmentation: https://cwiki.apache.org/confluence/display/JENA/Commit+Workflow+for+Github-ASF ---

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-20 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/385 To be clear, what is here at Github is essentially a read-only mirror. What's at Apache is the real deal. We've talked about reversing that mirroring relationship (so that we could merge PRs here at

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-20 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/385 Hey, @xristy, you want to push instead to the `master` branch at Apache: https://git-wip-us.apache.org/repos/asf/jena.git ---

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-20 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/385 I'm guessing that I'm supposed to perform the pull request but when I try to push to apache/jena master on github my github user, xristy, doesn't have permission for apache/jena.git. What is

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-18 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/385 The parameter types: `int`, `boolean` and `String` may be derived from the `text:paramValue`. See [JENA-1506](https://issues.apache.org/jira/browse/JENA-1506) for details. ---

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-18 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/jena/pull/385 +1 @rvesse comments. And +1 for the great PR @xristy !!! Tested with the WIP `SelectiveFoldingFilter` for JENA-1488, and it worked like a charm! :tada: :tada: :tada: First created a normal

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 @xristy Yes I don't think there is any harm in supporting both the explicit form as well as supporting literal datatypes directly ---

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/385 @rvesse On the matter of the tests, I just updated the ticket on that matter: > There are already a suite of tests associated with TestDatasetWithConfigurableAnalyzer that exercise the new

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread osma
Github user osma commented on the issue: https://github.com/apache/jena/pull/385 Wow, quite a big patch for a "straightforward" change :) Great work @xristy ! +1 to @rvesse's suggestion to simplify by making use of literal data types, if it's possible. Thanks for

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 Btw as you are now a committer you can follow the instructions at https://reference.apache.org/committer/github to get added to the Apache GitHub org so you'll show up as `Member` and not just as

[GitHub] jena issue #385: defined filters and tokenizers for ConfigurableAnalyzer

2018-03-16 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/385 Looks like a really nice extension to the current machinery! I notice there is a unit test for the assembler support but no unit tests for using some of these new features, would it be possible