Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98234539
Confirmed.
Your remark about `ExtendIterator` completely makes sense to me. It's out
there as a public contract. When I suggested on the mailing list changing it to
g
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98231727
OK - to confirm this PR is not "draft" any more but proposed final.
`ExtendedIterator` is different because it is in the `Graph` interface from
`find`. That means it is
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98222682
Ah, history. {grin}
Okay, sounds like we should leave this current PR alone, if you feel that
you can accept it as is.
I'll send another which moves through `
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98221746
History! It's used in jena-sdb and jena-tdb. It originated out of work on
SDB (pre-iterables) and needed to work on general iterators, not (just)
ExtendedIterators. It has not
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98221169
Actually, there's also `org.apache.jena.atlas.iterator.Filter`, which
seems to be superseded by Java 8's `Predicate`. Maybe another PR is due here.
---
If your project is set
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98220608
It looks like `Iter` makes use of some types that also have nice Java 8
replacements. Would a migration from
`org.apache.jena.atlas.iterator.Transform` to `Function` belong in
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98220199
Okay-- thanks for pointing out `Iter`! It's a bit strange, though. It
doesn't seem to be used all that much. For example, `NiceIterator.toSet()`
doesn't use `Iter.toSet(Iterat
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98218286
Looks like a good plan. The last point (manipulations) is possibly
open-ended than the first two.
---
If your project is set up for it, you can reply to this email and have yo
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98217891
FYI: For iterators see `Iter` (in jena-base). Again, pre-java8 but has a
use in applying stream-list functions to iterators, instead of converting
iterator to stream to iterato
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98179500
Totally up to you. It's all clear to me and I don't require to parcel it
out, but that's because I've been knee-deep in it. {grin}
If you think it would make for a clearer
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98178582
Looks good. If it would be helpful to you, we can break this up into
several steps in anyway so as to make it progressive improvement? e.g. even as
specific as as rename `Filte
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/55#issuecomment-98172820
NOT TO BE MERGED YET. This is just a first draft. There is clearly more to
do to use Java 8 syntax to clarify filtered iteration and I just wanted to get
something out to the
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/55
First draft of migrating Filter to Java 8 Predicate
Continued work on JENA-929.
Specifically, we now begin to migrate o.a.j.util.iterator.Filter and
associated machinery to Java 8's new Predicat
13 matches
Mail list logo
