Re: New fields/changed defaults cause earlier test plans to be marked as changed (bug 59173)

2016-03-18 Thread Philippe Mouawad
On Fri, Mar 18, 2016 at 11:02 PM, sebb wrote: > On 18 March 2016 at 21:46, Philippe Mouawad > wrote: > > Hello, > > > > Sebb opened a bug 59173 reporting a problem of "spurious" save message > when > > 4 elements are selected. > > > > > > I fixed 1/4 of these. > > The problem is that fixing the

Re: New fields/changed defaults cause earlier test plans to be marked as changed (bug 59173)

2016-03-18 Thread sebb
On 18 March 2016 at 21:46, Philippe Mouawad wrote: > Hello, > > Sebb opened a bug 59173 reporting a problem of "spurious" save message when > 4 elements are selected. > > > I fixed 1/4 of these. > The problem is that fixing the 3/4 other "issues" is if not impossible not > simple at all: > > 1/ Ac

IllegalAccessError when running ant run_gui

2016-03-18 Thread Felix Schumacher
Hi all, currently I get 2016/03/17 19:04:07 ERROR - jmeter.threads.JMeterThread: Test failed! java.lang.IllegalAccessError: tried to access class org.apache.http.impl.conn.HttpConnPool from class org.apache.http.impl.conn.JMeterPoolingClientConnectionManager at org.apache.http.impl.conn.

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-18 Thread Philippe Mouawad
Ok, I understand. Done On Thu, Mar 17, 2016 at 8:52 PM, sebb wrote: > Yes, every 3rd party jar needs to be mentioned in LICENSE > > It's important that users have confidence that the code is available > under the AL. > If a jar is not mentioned, then it is not obvious whether it is > compatible

buildbot success in on jmeter-trunk

2016-03-18 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/834 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler schedu

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-18 Thread max3163
GitHub user max3163 opened a pull request: https://github.com/apache/jmeter/pull/168 Force JSONPATH to always return list of Object When the JSONPATH expression retrieve only one value, an exeption was thrown ( Unable to cast String type to List type by example) Add the Option.A

Re: New fields/changed defaults cause earlier test plans to be marked as changed (bug 59173)

2016-03-18 Thread sebb
On 18 March 2016 at 22:10, Philippe Mouawad wrote: > On Fri, Mar 18, 2016 at 11:02 PM, sebb wrote: > >> On 18 March 2016 at 21:46, Philippe Mouawad >> wrote: >> > Hello, >> > >> > Sebb opened a bug 59173 reporting a problem of "spurious" save message >> when >> > 4 elements are selected. >> > >>

[GitHub] jmeter pull request: deprecate some methods in JMeterUtils

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] jmeter pull request: deprecate some methods in JMeterUtils

2016-03-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/148#issuecomment-198560249 pong Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/168#issuecomment-197859425 Fixed with commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

Re: Remaining Work before Release of 3.0

2016-03-18 Thread Philippe Mouawad
Hi sebb, I have fixed 1/4 issues reported in 59173 and think other "issues" should be mentioned in changes and not fixed as I think some cannot be without important work without real ROI. Regarding 58832, it's a minor issue without effect as report works and displays fine under ff, chrome, safari

Re: [GitHub] jmeter pull request: java constants naming

2016-03-18 Thread Philippe Mouawad
Hello, Frankly I don't understand this discussion: - LOG (Upper Case) for static is the usual policy that is applied by all of us since few time - The guy named it LOGGER, what's the problem except that it does not suit a particular taste ? : - It is in UPPERCASE - It is me

[GitHub] jmeter pull request: java constants naming

2016-03-18 Thread benbenw
GitHub user benbenw opened a pull request: https://github.com/apache/jmeter/pull/171 java constants naming You can merge this pull request into a Git repository by running: $ git pull https://github.com/benbenw/jmeter javanaming Alternatively you can review and apply these ch

Re: Remaining Work before Release of 3.0

2016-03-18 Thread sebb
There are some regressions/new bugs: Bug 59173 Bug 58832 On 16 March 2016 at 19:16, Philippe Mouawad wrote: > Hi sebb, > With the last commits and comments on the issues you mentioned, > can we consider that remaining work is the following: > - sort the columns of saved columns per english tr

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

buildbot success in on jmeter-trunk

2016-03-18 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/843 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler schedu

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-18 Thread Philippe Mouawad
Done On Thu, Mar 17, 2016 at 4:56 PM, sebb wrote: > This is a new 3rd party jar. > The license needs to be checked for compatibility and if OK must be > documented in LICENSE - and stored locally if it is not AL 2.0 > > > On 17 March 2016 at 12:14, wrote: > > Author: pmouawad > > Date: Thu Mar

buildbot success in on jmeter-trunk

2016-03-18 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/855 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler schedu

Re: [GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

2016-03-18 Thread sebb
On 17 March 2016 at 11:20, Antonio Gomes Rodrigues wrote: > I will fix the unit test asap > > Can you provide the checkstyle configuration to run it in local before > commit the change? It's in SVN. But as already noted it does not catch everything. The best is to follow the layout convention f

Re: IllegalAccessError when running ant run_gui

2016-03-18 Thread Philippe Mouawad
I found the problem. run_gui uses a classpath which is wrong, since the classpath is build by NewDriver I will create a bug to trace the change On Thu, Mar 17, 2016 at 8:44 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > I also get this one before If my plan contains a CookieManager:

[GitHub] jmeter pull request: Force JSONPATH to always return list of Objec...

2016-03-18 Thread pmouawad
Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/168#issuecomment-197558458 Hello Maxime, Could you provide a simple test plan showing the bug you faced ? Thank you --- If your project is set up for it, you can reply to this email and h

Re: Remaining Work before Release of 3.0

2016-03-18 Thread sebb
On 17 March 2016 at 16:59, Philippe Mouawad wrote: > Hi sebb, > I have fixed 1/4 issues reported in 59173 and think other "issues" should > be mentioned in changes and not fixed as I think some cannot be without > important work without real ROI. ? cannot parse. > Regarding 58832, it's a minor i

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

2016-03-18 Thread sebb
This is a new 3rd party jar. The license needs to be checked for compatibility and if OK must be documented in LICENSE - and stored locally if it is not AL 2.0 On 17 March 2016 at 12:14, wrote: > Author: pmouawad > Date: Thu Mar 17 12:14:44 2016 > New Revision: 1735407 > > URL: http://svn.apach

Re: Management of Redirect and rfc7231

2016-03-18 Thread Philippe Mouawad
Ok sebb, but what about the target rfc we want to support ? Thanks On Thu, Mar 17, 2016 at 9:54 PM, sebb wrote: > Ideally JMeter should delegate the redirect decision to the HTTP library. > > However this may not be possible for all libraries. > > On 17 March 2016 at 20:46, Philippe Mouawad > w