Hi all,
I would like to add new enhancements to CSV Data Set with new PR
For this PR, is it ok or I need rework it to be integrated?
Thank
Antonio
2016-03-19 9:30 GMT+01:00 Antonio Gomes Rodrigues :
> Hi all,
>
> Do I need to modify something to allow the PR be accepted?
>
> Thank
> Antonio
>
Hello sebb,
Although this fixes the issue, it seems to me as a violation of the
architecture .
BackendListener should not be aware of a particular implementation of
BackendListenerClient : GraphiteBackendListenerClient
Regards
On Tue, Mar 22, 2016 at 1:54 AM, wrote:
> Author: sebb
> Date: Tue M
Hi Felix,
Do you think it is ok in case of Connection error ?
Thank you
Regards
On Mon, Mar 21, 2016 at 7:17 PM, wrote:
> Author: fschumacher
> Date: Mon Mar 21 18:17:03 2016
> New Revision: 1736072
>
> URL: http://svn.apache.org/viewvc?rev=1736072&view=rev
> Log:
> TCP Sampler: Set connect tim
Am 22. März 2016 20:22:22 MEZ, schrieb Philippe Mouawad
:
>Hi Felix,
>Do you think it is ok in case of Connection error ?
Yes, that is why I put connectEnd there. But feel free to place it somewhere
else. I wouldn't be angry.
Regards,
Felix
>
>Thank you
>Regards
>
>On Mon, Mar 21, 2016 at
In fact I don't know :-)
In case of exception, connectEnd won't be called so for example, if issue
is due to timeout, value will not be equal to timeout.
Should we put it in a try/finally arount getSocket ?
Thanks
On Tue, Mar 22, 2016 at 8:29 PM, Felix Schumacher <
felix.schumac...@internetallee.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
What do we do for other samplers if the connect fails?
Do we document the behaviour?
is the value supposed to be the time to connect even if connect fails?
On 22 March 2016 at 19:32, Philippe Mouawad wrote:
> In fact I don't know :-)
>
> In case of exception, connectEnd won't be called so for e
On 22 March 2016 at 19:12, Philippe Mouawad wrote:
> Hello sebb,
> Although this fixes the issue, it seems to me as a violation of the
> architecture .
> BackendListener should not be aware of a particular implementation of
> BackendListenerClient : GraphiteBackendListenerClient
If you can move t
Am 22.03.2016 um 21:05 schrieb sebb:
What do we do for other samplers if the connect fails?
The only other samplers using connectEnd are those using the
MeasuringConnectionManager. There connectEnd is called in
ManagedClientConnection#open.
Felix
Do we document the behaviour?
is the value
On 22 March 2016 at 20:27, Felix Schumacher
wrote:
> Am 22.03.2016 um 21:05 schrieb sebb:
>>
>> What do we do for other samplers if the connect fails?
>
> The only other samplers using connectEnd are those using the
> MeasuringConnectionManager. There connectEnd is called in
> ManagedClientConnec
10 matches
Mail list logo
