Re: Why docs folder is under SVN control?

On 3 April 2016 at 01:59, Vladimir Sitnikov wrote: > Hi, > > Does it really required to have docs under version control? > It looks like docs is produced out of xdocs, so just one should be sufficient. Have a look at

[GitHub] jmeter pull request: Compress PNGs

GitHub user vlsi opened a pull request: https://github.com/apache/jmeter/pull/177 Compress PNGs `pngquant --force --ext .png *.png` This reduces size of xdocs/images from 12MiB to 6.5MiB You can merge this pull request into a Git repository by running: $ git pull

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

GitHub user vlsi opened a pull request: https://github.com/apache/jmeter/pull/176 Use explicit timeout for TestDNSCacheManager, so test is executed faster `org.apache.jmeter.protocol.http.control.TestDNSCacheManager#testCloneWithCustomResolverAndInvalidNameserver` took 30 seconds

Re: GUI Mode : OOM Protection for View Results Tree or View Results in Table

> or approximate the size in bytes of Nodes / Rows ? This one. I think it should not be that hard to estimate SampleResult size in bytes for common implementations. Same for node in result tree/result table. So we can implement user-facing property like "stop adding more results if existing

Re: GUI Mode : OOM Protection for View Results Tree or View Results in Table

On Sat, Apr 2, 2016 at 11:03 PM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > In general I'm for "log once, then stop adding new results". > So you're for Patch2 right ? > As you might know, I'm for using "occupied heap size" as a trigger point. > There might easily be users with

Re: GUI Mode : OOM Protection for View Results Tree or View Results in Table

In general I'm for "log once, then stop adding new results". As you might know, I'm for using "occupied heap size" as a trigger point. There might easily be users with 10MiB+ responses. Vladimir

Re: GUI Mode : OOM Protection for View Results Tree or View Results in Table

What is the preferred way of commenting on the line-by-line basis? I'm not used to comment on patch files. How do you do that? >+ log.warn(getName()+":applying OUTOFMEMORY PROTECTION, SampleResults are not >added anymore, use NON-GUI mode" >++ " or configure property

Re: GUI Mode : OOM Protection for View Results Tree or View Results in Table

Thanks Felix. What's your opinion on the 2 proposed patches ? @Vladimir, @Milamber same question ? Thanks On Sat, Apr 2, 2016 at 12:29 PM, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Am 01.04.2016 um 21:34 schrieb Philippe Mouawad: > >> Hi Vladimir, >> For now I don't see how

Re: .gitignore and .gitattributes in the SVN repository

On 2 April 2016 at 14:18, Vladimir Sitnikov wrote: > Well, the next question is Please start a new thread or this discussion will get lost. > 1) Whether platform-specific builds are available or not > 2) Which OS should be used to produce "release artifacts" > 3)

Re: .gitignore and .gitattributes in the SVN repository

Well, the next question is 1) Whether platform-specific builds are available or not 2) Which OS should be used to produce "release artifacts" 3) Which kind of line ending should release artifacts use. *.sh/*.bat are clear. What about properties, etc, etc? Vladimir

Re: .gitignore and .gitattributes in the SVN repository

On 2 April 2016 at 14:06, Vladimir Sitnikov wrote: > sebb>Yes. Actually: No Sorry, was looking at the wrong files. I've no idea why the report-template files have those settings. > Those are css, js and txt files. > Why CRLF is expected there? > > What if someone

Re: svn commit: r1737490 - in /jmeter/trunk: src/core/org/apache/jmeter/services/FileServer.java test/src/org/apache/jmeter/config/TestCVSDataSet.java test/src/org/apache/jmeter/services/TestFileServe

Also we normally put a bit more than just the commit ref on the bug report. It's useful to include the log comment and list of files changed. See some other recently updated bugs for examples These details can be found from the svn ref, but it saves looking it up. It's particularly useful when

Re: .gitignore and .gitattributes in the SVN repository

sebb>Yes. Those are css, js and txt files. Why CRLF is expected there? What if someone edits one of those files via OS X or Linux? Default editors would not adhere CRLF. sebb>AFAIK XML files use CRLF on all platforms. That is false. Vladimir

Re: .gitignore and .gitattributes in the SVN repository

On 2 April 2016 at 13:49, Vladimir Sitnikov wrote: > Oops. .gitignore is there. I'll updated accordingly. > > Regarding .gitattributes: current bin/report-template/** files have > CRLF line endings. > Is that expected? Yes. AFAIK XML files use CRLF on all platforms.

Re: Why does LogkitLoggerAdapter implement Serializable?

Anyone? Code was added by Philippe as part of Bugzilla Id: 59240 On 1 April 2016 at 00:29, sebb wrote: > Is there any need to serialise this class? > > If not, it should not implement the interface. > If so, it needs a dummy ctor to allow unit tests to work

Re: svn commit: r1737490 - in /jmeter/trunk: src/core/org/apache/jmeter/services/FileServer.java test/src/org/apache/jmeter/config/TestCVSDataSet.java test/src/org/apache/jmeter/services/TestFileServe

>Ignore my note, I mixed up. That part was indeed not required, so I removed it. Vladimir

Re: .gitignore and .gitattributes in the SVN repository

Am 02.04.2016 um 14:25 schrieb Vladimir Sitnikov: Hi, It looks like .gitignore and .gitattributes are missing. .gitignore is not missing. It is included since r1685876. Regards, Felix Are there objections if I commit those in SVN? It would simplify git experience: git know which files to

Re: .gitignore and .gitattributes in the SVN repository

Oops. .gitignore is there. I'll updated accordingly. Regarding .gitattributes: current bin/report-template/** files have CRLF line endings. Is that expected? I would expect those css & js & txt files to be in a text format. Should I go ahead and convert them somehow? Vladimir

Re: .gitignore and .gitattributes in the SVN repository

Hi, Ok for me, when you will commit can you add in commit message: #resolve #24 As there is an open PR https://github.com/apache/jmeter/pull/24 Regards On Sat, Apr 2, 2016 at 2:25 PM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Hi, > > It looks like .gitignore and .gitattributes

.gitignore and .gitattributes in the SVN repository

Hi, It looks like .gitignore and .gitattributes are missing. Are there objections if I commit those in SVN? It would simplify git experience: git know which files to ignore and which line endings to use. Vladimir

Re: svn commit: r1737490 - in /jmeter/trunk: src/core/org/apache/jmeter/services/FileServer.java test/src/org/apache/jmeter/config/TestCVSDataSet.java test/src/org/apache/jmeter/services/TestFileServe

I didn't follow this PR closely, but it is correct to remove this code: if (fileEntry.exception != null) { Throwable exception = fileEntry.exception; if (exception instanceof RuntimeException) { throw (RuntimeException) exception; }

Re: svn commit: r1735407 - in /jmeter/trunk: build.properties build.xml eclipse.classpath lib/ lib/aareadme.txt res/maven/ApacheJMeter_parent.pom xdocs/changes.xml

On 17 March 2016 at 20:38, sebb wrote: > I see the maintenance issue now. > > The LICENSE file relies on the contents of licenses/bin to document > 3rd party jars. > As such, even jars under the AL need a file. > > It would be easier for the user - and probably easier to

Re: svn commit: r1737490 - in /jmeter/trunk: src/core/org/apache/jmeter/services/FileServer.java test/src/org/apache/jmeter/config/TestCVSDataSet.java test/src/org/apache/jmeter/services/TestFileServe

Philippe> I see this part of code has been dropped at line 290, is Philippe> this regular ?: Can you clarify the question? Vladimir

Re: svn commit: r1737490 - in /jmeter/trunk: src/core/org/apache/jmeter/services/FileServer.java test/src/org/apache/jmeter/config/TestCVSDataSet.java test/src/org/apache/jmeter/services/TestFileServe

On 2 April 2016 at 13:06, Philippe Mouawad wrote: > Hi Vladimir, > Congrats for your first Commit ! Ditto. Please also update the changes.xml file to document the enhancement - thanks! > Just wondering, I see this part of code has been dropped at line 290, is > this

Re: svn commit: r1737490 - in /jmeter/trunk: src/core/org/apache/jmeter/services/FileServer.java test/src/org/apache/jmeter/config/TestCVSDataSet.java test/src/org/apache/jmeter/services/TestFileServe

Hi Vladimir, Congrats for your first Commit ! Just wondering, I see this part of code has been dropped at line 290, is this regular ?: if (fileEntry.exception != null) { Throwable exception = fileEntry.exception; if (exception instanceof RuntimeException) {

[GitHub] jmeter pull request: Move checkstyle to a separate Travis job

GitHub user vlsi opened a pull request: https://github.com/apache/jmeter/pull/175 Move checkstyle to a separate Travis job You can merge this pull request into a Git repository by running: $ git pull https://github.com/vlsi/jmeter travis_upd Alternatively you can review and

[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: GUI Mode : OOM Protection for View Results Tree or View Results in Table

Am 01.04.2016 um 21:34 schrieb Philippe Mouawad: Hi Vladimir, For now I don't see how to "remove oldest sample results" efficiently without a big effort, do you have some ideas ? As Vladimir noted ArrayList is not well suited for removal of elements from the front. There are however

Re: [VOTE] new logo for JMeter 3.0

Am 01.04.2016 um 22:00 schrieb Philippe Mouawad: Hi Felix, I applied the changes I mentioned. Thanks for doing that. Felix Regards Philippe On Thu, Mar 31, 2016 at 9:12 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: Thanks Felix. Regarding the social media links the are located