Am 25. Januar 2017 23:28:48 MEZ schrieb Philippe Mouawad
:
>Hello,
>There was a similar synchro bug in those 3 classes as reported in:
>
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=60648
>
>CopyOnWriteArrayList does not seem to be a good option.
>
>I fixed them with regular Synchronizat
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/257
Thanks for looking at the PR and commenting.
I will take another look at the changes to `org.apache.jmeter.control` and
either revert or justify them.
I'd gladly add more tests if we move to
Hello,
There was a similar synchro bug in those 3 classes as reported in:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=60648
CopyOnWriteArrayList does not seem to be a good option.
I fixed them with regular Synchronization but I wonder if there is not a
better way using Java 8.
But I am
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/257
Hello,
Another question I have.
I see you replace StringBuilder by '+' concat.
Is there a reason for this ?
Reading:
-
http://www.pellegrino.link/2015/08/22/string-concatenation-
+1 to drop them
Antonio
2017-01-25 18:28 GMT+01:00 Milamber :
>
> HTML Link Parser element is probably rarely used and can be deprecated imho
>
> HTTP URL Re-writing element can be useful for testing webapp without
> cookie manager but probably for a very old app of the time when the cookie
> is
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Hello
I'd like to start a thread on this particular item for which an enhancement
exists:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=59847
The aim of this thread is to discuss, throw ideas on how we could implement
this in JMeter.
Oleg K. from HttpComponents project has nicely proposed
+1 to save it by default
Antonio
2017-01-25 20:32 GMT+01:00 Philippe Mouawad :
> Hello,
> Anybody is against switching this ?
>
> Thank you
> Regards
>
Hello,
Anybody is against switching this ?
Thank you
Regards
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/247
Hello,
I reviewed this PR and I have some blocker remarks so I didn't merge it:
- I think code in StandardJMeterEngine and DistributedRunner is duplicated
- I wouldn't put any dependency
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/257
@ham1 , Thanks a lot for your contribution.
Looks globally good for me.
I have just one remark, I wouldn't "optimize" the org.apache.jmeter.control
package classes.
This part of JMeter is
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/253
@max3163 ,
Ok for your proposal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
On Wed, Jan 25, 2017 at 4:05 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:
>
>
> Am 25. Januar 2017 13:31:12 MEZ schrieb Philippe Mouawad <
> philippe.moua...@gmail.com>:
> >On Wed, Jan 25, 2017 at 10:01 AM, Felix Schumacher <
> >felix.schumac...@internetallee.de> wrote:
> >
> >
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/253
When we flush metrics in the teardownTest method, why the start annotations
is not send too ?
For my remark, I just want to put tags as tag and not as field. The user
can put whatever he wa
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/253
@max3163 , I've fixed the missing httpcore-nio.
For the bug, it's because you schedule every 5s, so test ends before and
closes the Sender and just guarantees end is sent.
We could fix it but
HTML Link Parser element is probably rarely used and can be deprecated imho
HTTP URL Re-writing element can be useful for testing webapp without
cookie manager but probably for a very old app of the time when the
cookie is appeared into the browsers... Probably it's can be deprecated too.
O
+1 to drop them, they seems to not align to general purpose of core JMeter
Andrey Pokhilko
On 25.01.2017 19:44, Philippe Mouawad wrote:
> Hello,
>
> What do you think of deprecating HTML Link Parser and HTTP URL Re-writing
> Modifier?
>
>- I am not sure they are widely used
>- Their desig
Hello,
What do you think of deprecating HTML Link Parser and HTTP URL Re-writing
Modifier?
- I am not sure they are widely used
- Their design does not suit well for performance as :
- they require Previous Response, as a consequence, they do not work
in Distributed mode
-
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/253
I made some test on the last nigthly ( by the way, the
apache-jmeter-r1780178.zip miss one librairie => httpcore-nio-4.4.6 )
When the test takes few second ( less than 5 second ) only the " ended
Am 25. Januar 2017 13:32:56 MEZ schrieb pmoua...@apache.org:
>Author: pmouawad
>Date: Wed Jan 25 12:32:56 2017
>New Revision: 1780178
>
>URL: http://svn.apache.org/viewvc?rev=1780178&view=rev
>Log:
>Bug 55652 - JavaSampler silently resets classname if class can not be
>found
>Fix Sonar error in a
Am 25. Januar 2017 13:31:12 MEZ schrieb Philippe Mouawad
:
>On Wed, Jan 25, 2017 at 10:01 AM, Felix Schumacher <
>felix.schumac...@internetallee.de> wrote:
>
>>
>>
>> Am 25. Januar 2017 08:31:32 MEZ schrieb pmoua...@apache.org:
>> >Author: pmouawad
>> >Date: Wed Jan 25 07:31:31 2017
>> >New Revi
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/253
Plse re-consider your last commit on the ANNOTATION side where you put tags
as a field...
Tags is a tag not a field.
---
If your project is set up for it, you can reply to this email and have y
On Wed, Jan 25, 2017 at 10:01 AM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:
>
>
> Am 25. Januar 2017 08:31:32 MEZ schrieb pmoua...@apache.org:
> >Author: pmouawad
> >Date: Wed Jan 25 07:31:31 2017
> >New Revision: 1780141
> >
> >URL: http://svn.apache.org/viewvc?rev=1780141&view
Am 25. Januar 2017 08:31:32 MEZ schrieb pmoua...@apache.org:
>Author: pmouawad
>Date: Wed Jan 25 07:31:31 2017
>New Revision: 1780141
>
>URL: http://svn.apache.org/viewvc?rev=1780141&view=rev
>Log:
>Ignore sonar false positive
>
>Modified:
>jmeter/trunk/src/protocol/java/org/apache/jmeter/protoco
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/256
Hi Philippe,
Thanks to your feedback
I will integrate your modification.
If it's ok for all, I will modify the documentation and merge it
One question, do I need to modify
25 matches
Mail list logo