Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread sebb
On 18 November 2017 at 22:27, Philippe Mouawad wrote: > On Sat, Nov 18, 2017 at 11:19 PM, sebb wrote: > >> On 16 November 2017 at 19:20, Philippe Mouawad >> wrote: >> > Hello, >> > Tidy option AFAIK used to allow using XPath Extractor for HTML. >> > I don't think it's needed anymore since we hav

Re: BUG 61567

2017-11-18 Thread sebb
The code is quite complicated, so I would be very wary of changing it. And it's important not to include jars in the classpath that don't belong. JMeter runs quite happily if the jars are named anything you like so long as they are in the lib/ext directory or they are added to the appropriate path

buildbot failure in on jmeter-trunk

2017-11-18 Thread buildbot
The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/3205 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sched

Re: BUG 61567

2017-11-18 Thread Philippe Mouawad
Hello, Any thoughts on this ? Thanks On Sat, Nov 11, 2017 at 10:41 PM, Philippe Mouawad < p.moua...@ubik-ingenierie.com> wrote: > Hello, > Analyzing bug 61567 , I end up thinking that what we're doing in the below > method is not correct: > >- ClassFinder#getClasspathMatches > > This method d

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread Philippe Mouawad
On Sat, Nov 18, 2017 at 11:19 PM, sebb wrote: > On 16 November 2017 at 19:20, Philippe Mouawad > wrote: > > Hello, > > Tidy option AFAIK used to allow using XPath Extractor for HTML. > > I don't think it's needed anymore since we have CSS/JQuery extractor > which > > is: > > - Up to date > > - P

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread sebb
On 16 November 2017 at 19:20, Philippe Mouawad wrote: > Hello, > Tidy option AFAIK used to allow using XPath Extractor for HTML. > I don't think it's needed anymore since we have CSS/JQuery extractor which > is: > - Up to date > - Powerful > - Performing much better than XPath > > I propose to dro

buildbot success in on jmeter-trunk

2017-11-18 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/3204 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sc

Build failed in Jenkins: JMeter Windows #881

2017-11-18 Thread Apache Jenkins Server
See Changes: [pmouawad] Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles with read, browse, clear This closes #325 Fix persistence and add tests Bugzilla Id: 61544 [fschumacher] set svn:eol-s

[GitHub] jmeter pull request #325: 61544 - Added read, browse and clear as communicat...

2017-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/325 ---

buildbot failure in on jmeter-trunk

2017-11-18 Thread buildbot
The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/3201 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sched

Build failed in Jenkins: JMeter Windows #880

2017-11-18 Thread Apache Jenkins Server
See Changes: [agomes] [Bug 61775] Add a link to help menu to download nighty builds (it open the browser with the correct link) - add missing file -- [...truncated 176.50

[GitHub] jmeter pull request #331: Removed (some more) commented out code

2017-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/331 ---

[GitHub] jmeter pull request #328: Improve wording and formatting of jmeter.propertie...

2017-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/328 ---

[GitHub] jmeter pull request #294: Add expand/collapse all menu in render XML view

2017-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/294 ---

[GitHub] jmeter pull request #329: Expansion of "Add expand/collapse all menu in rend...

2017-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/329 ---

Jenkins build is back to normal : JMeter Windows #878

2017-11-18 Thread Apache Jenkins Server
See

Build failed in Jenkins: JMeter Windows #877

2017-11-18 Thread Apache Jenkins Server
See Changes: [pmouawad] Add new line at end of file [pmouawad] Remove unused import -- [...truncated 176.90 KB...] [jmeter] Starting the test @ Sat Nov 18 12:20:00 UTC

[GitHub] jmeter issue #331: Removed (some more) commented out code

2017-11-18 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/331 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=h1) Report > Merging [#331](https://codecov.io/gh/apache/jmeter/pull/331?src=pr&el=desc) into [trunk](https://codecov.io/gh/

[GitHub] jmeter pull request #331: Removed (some more) commented out code

2017-11-18 Thread ham1
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/331 Removed (some more) commented out code ## Description Removing more commented out code You can merge this pull request into a Git repository by running: $ git pull https://github.com/ham1/jmet

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread Philippe Mouawad
Hi , @Graham, would you propose a PR to: - deprecate the properties in GUI - amend documentation to say it will be dropped in N+2 and what is the correct way If you want to ask on user mailing list, feel free to do so. Even if users use it, they should move out of it, but I am ok with the 2 steps

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread Graham Russell
+0 I agree that CSS should be preferred for HTML and, in general, I'm in favour of removing seldom used/broken bits of functionality which don't warrant the cost of keeping them around, but I don't know enough about it nor how often XPath is currently used by people to say +1 for this yet. Maybe

Build failed in Jenkins: JMeter Windows #876

2017-11-18 Thread Apache Jenkins Server
See Changes: [agomes] [Bug 61775] New: Add a link to help menu to download nighty builds (it open the browser with the correct link) -- [...truncated 177.12 KB...] [jme