RE: Issue 63185

Am 21. Februar 2019 05:05:46 MEZ schrieb Sanjay Chaurasia : >Dear Brain Wolfe, > >I was facing same error on windows environment. Please try this It. > >Set the environment variable as JAVA_TOOL_OPTIONS: >-Dfile.encoding=US-ASCII I think that should be utf-8. >Take check-out from the followi

what??s will happen if httpclient.reset_state_on_thread_group_iteration= true or false

hello i saw this sentence: Since JMeter 5.0, when using default HC4 Implementation, JMeter will reset HTTP state (SSL State + Connections) on each thread group iteration. If you don't want this behaviour, set httpclient.reset_state_on_thread_group_iteration=false . i want to know set httpcl

Re: Migrating build system to Gradle

On Thu, 21 Feb 2019 at 05:33, Vladimir Sitnikov wrote: > > Philippe>If structure changes that can be harderI see. > > sebb>That was one of the major issues when we looked at moving to Maven a > few years back > > I'm sure the history would be fine in case we migrate to Git, and I see no > issues w

Re: Migrate SVN -> Git

On Thu, 21 Feb 2019 at 05:12, Vladimir Sitnikov wrote: > > >What's the level of complexity ? > > It can be done by infra. > The formal vote for the migration should pass. > > > I don't think JMeter needs advanced SVN features (e.g. fine-grained access > control, externals, locks, partial directory

Re: Migrating build system to Gradle

sebb> Whoever wants to switch should show that it can replace the current sebb> Ant build system without causing disruption. sebb> It needs to support all of the existing Ant targets. Ok, I read that as you agree to replace Ant with Gradle. So far the only technical justification (see https://www.

Re: Migrating build system to Gradle

Hi, No experience in Gradle, but ++1 (Binding) to replace ant Antonio Le jeu. 21 févr. 2019 à 10:48, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> a écrit : > sebb> Whoever wants to switch should show that it can replace the current > sebb> Ant build system without causing disruption. > sebb

Re: Migrate SVN -> Git

On Thu, Feb 21, 2019 at 10:39 AM sebb wrote: > On Thu, 21 Feb 2019 at 05:12, Vladimir Sitnikov > wrote: > > > > >What's the level of complexity ? > > > > It can be done by infra. > > The formal vote for the migration should pass. > > > > > > I don't think JMeter needs advanced SVN features (e.g.

RE: Migrate SVN -> Git

Disclaimer - I'm not a direct contributor. But I have: - transitioned from Visual-Source-Safe (Ugh!!!) to SVN; - Mercurial to Git; - TFS to Git; And I have lead («led») 2 teams through Git adoption, one very successfully, one still undergoing with very little success. This is what I want to say

Re: Migrating build system to Gradle

On Thu, 21 Feb 2019 at 09:48, Vladimir Sitnikov wrote: > > sebb> Whoever wants to switch should show that it can replace the current > sebb> Ant build system without causing disruption. > sebb> It needs to support all of the existing Ant targets. > > Ok, I read that as you agree to replace Ant wit

Re: Migrating build system to Gradle

IMO, if Vladimir is willing to do migration to Gradle (of course providing alternative or equivalent to existing tasks), we should not stop him because it is a change that might be impacting. JMeter is not a frozen project and temporary chaos is acceptable and it's life. JMeter lacks easy setup fo

Build failed in Jenkins: JMeter Windows #1304

See Changes: [vladimirsitnikov] Refactor PackageTest to print all errors in a single message fixes #442 -- [...truncated 196.59 KB...] [jmeter] SLF4J: Found binding in

Re: Migrate SVN -> Git

On Thu, 21 Feb 2019 at 09:59, Philippe Mouawad wrote: > > On Thu, Feb 21, 2019 at 10:39 AM sebb wrote: > > > On Thu, 21 Feb 2019 at 05:12, Vladimir Sitnikov > > wrote: > > > > > > >What's the level of complexity ? > > > > > > It can be done by infra. > > > The formal vote for the migration shoul

Re: Migrate SVN -> Git

Philippe> Will this not work: Philippe> https://blog.subgit.com/line-endings-handling-in-svn-git-and-subgit/ What do you mean by "not work"? This works flawlessly: https://github.com/apache/calcite/blob/master/.gitattributes#L15-L21 What it does it says "*.sh files must always be in LF" while "*.

Re: Migrate SVN -> Git

On Thu, Feb 21, 2019 at 11:30 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Philippe> Will this not work: > Philippe> > https://blog.subgit.com/line-endings-handling-in-svn-git-and-subgit/ > > What do you mean by "not work"? > I meant , "I think this will work no ? " > > This wor

Re: Migrating build system to Gradle

On Thu, 21 Feb 2019 at 10:29, Philippe Mouawad wrote: > > IMO, > if Vladimir is willing to do migration to Gradle (of course providing > alternative or equivalent to existing tasks), we should not stop him > because it is a change that might be impacting. > JMeter is not a frozen project and tempo

Re: Migrating build system to Gradle

On Thursday, February 21, 2019, sebb wrote: > On Thu, 21 Feb 2019 at 10:29, Philippe Mouawad > wrote: > > > > IMO, > > if Vladimir is willing to do migration to Gradle (of course providing > > alternative or equivalent to existing tasks), we should not stop him > > because it is a change that mi

Re: Migrating build system to Gradle

++1 from me. Any change to modern is better, contributors will appreciate the good modern tooling. As for plugins, source layout does not affect them, as long as lib+lib/ext are kept for libs and plugins in distribution structure. -- Andrey Pokhilko 21.02.2019 13:00, Antonio Gomes Rodrigues пише

Re: Migrate SVN -> Git

+1, I know from experience how much easier is to work & review with github PRs, compared to SVN, bugzilla and patches Andrey Pokhilko 21.02.2019 0:33, Vladimir Sitnikov пишет: > Hi, > > What do you think of migrating to Git as a primary VCS? > I've seen recent migration of Apache Calcite to Apach

Re: Migrating build system to Gradle

++1 ! > I suggest Gradle since it simplifies day-to-day coding activities like: > 1) loading JMeter project to IDE > 2) building JMeter > 3) testing JMeter > 4) dependency management > 5) other Vladimir please let's do it! -- Artem Fedorov On Thu, Feb 21, 2019 at 5:06 PM Andrey Pokhilko wrote:

Re: Migrating build system to Gradle

On Thu, 21 Feb 2019 at 13:14, Philippe Mouawad wrote: > > On Thursday, February 21, 2019, sebb wrote: > > > On Thu, 21 Feb 2019 at 10:29, Philippe Mouawad > > wrote: > > > > > > IMO, > > > if Vladimir is willing to do migration to Gradle (of course providing > > > alternative or equivalent to ex

Re: Migrating build system to Gradle

On Thu, Feb 21, 2019 at 4:34 PM sebb wrote: > On Thu, 21 Feb 2019 at 13:14, Philippe Mouawad > wrote: > > > > On Thursday, February 21, 2019, sebb wrote: > > > > > On Thu, 21 Feb 2019 at 10:29, Philippe Mouawad > > > wrote: > > > > > > > > IMO, > > > > if Vladimir is willing to do migration to

Re: Issue 63185

ok so I was able to complete the tests using the following commands ant -Ddisable-svnCheck=true -Djava.awt.headless=true -Drmi_force_localhost=true -Dskip.bug52310=true -Dfile.encoding=UTF-8 test ant -Ddisable-svnCheck=true -Djava.awt.headless=true -Drmi_force_localhost=true -Dskip.bug52310=true -D

Re: Migrating build system to Gradle

Am 20.02.19 um 21:31 schrieb Vladimir Sitnikov: Hi, I think it is a good time to migrate build system to Gradle. Can you please express your opinion on that? If you struggle what to say, you might find the below options useful: [ ] ++1: 'Wow! I like this! Let's do it!' [ ] +1: 'Let's do it!

Re: Issue 63185

So now that I was able to pass all the existing JUnit tests. What is the procedure to get the change added for the next release? All I did was add a checkbox to the extended ldap sampler forms and some logic. All it does is if the secure ldap is selected it will change the trust manager used to va

Re: Migrate SVN -> Git

I've studied a couple of recent INFRA tickets, and it looks like creating Git repositories is handled via https://selfserve.apache.org/ So Git->SVN migration boils down to creating an empty repository, pushing code there. Then we should ask Infra to make SVN read-only, and things like that. At th

Re: Issue 63185

Am 21.02.19 um 17:16 schrieb Brian Wolfe: ok so I was able to complete the tests using the following commands ant -Ddisable-svnCheck=true -Djava.awt.headless=true -Drmi_force_localhost=true -Dskip.bug52310=true -Dfile.encoding=UTF-8 test ant -Ddisable-svnCheck=true -Djava.awt.headless=true -Drm

Re: Issue 63185

Am 21.02.19 um 20:04 schrieb Brian Wolfe: So now that I was able to pass all the existing JUnit tests. What is the procedure to get the change added for the next release? Either you do a pull request on github, or file a bugzilla issue and add a diff with your changes to it. Hopefully at l

Re: Issue 63185

Yes both ended with BUILD SUCCESSFUL. both also took around 10 mins to complete. On Thu, Feb 21, 2019 at 2:14 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote: > > Am 21.02.19 um 17:16 schrieb Brian Wolfe: > > ok so I was able to complete the tests using the following commands > > a

Re: Migrating build system to Gradle

Felix> * an easy way to do release tags What do you mean by that? Felix>Currently we have to check for the right version of Felix> ant as we use relatively new features I think we would use Gradle Wrapper (that is a small shell script that automatically downloads a proper Gradle version): https:

Re: Migrating build system to Gradle

Am 21.02.19 um 20:29 schrieb Vladimir Sitnikov: Felix> * an easy way to do release tags What do you mean by that? Something like mvn release plugin http://maven.apache.org/maven-release/maven-release-plugin/ Felix Felix>Currently we have to check for the right version of Felix> ant as

Re: Migrate SVN -> Git

Hi Vladimir, As initially discussed, I thought you would do at least one of the two, the Gradle being prioritary IMO. But it looks like you won't be able to in the end ? Volunteers are welcome in this case, although you looked like having interesting experience in Gradle that would have been very

Re: Migrating build system to Gradle

Felix> Something like mvn release plugin Felix> http://maven.apache.org/maven-release/maven-release-plugin/ Please, friends, never use maven-release-plugin. It works for a trivial single-module project, and it is a great pain for multi-module setup. I learned that the hard way. I think we should

Re: Migrating build system to Gradle

On Thu, 21 Feb 2019 at 20:46, Vladimir Sitnikov wrote: > > Felix> Something like mvn release plugin > Felix> http://maven.apache.org/maven-release/maven-release-plugin/ > > Please, friends, never use maven-release-plugin. Agreed. > It works for a trivial single-module project, and it is a great

Issue 63130 and 63129

Dear Philippe and Felix Please find details of created bugs and PRs respectively and kindly let me know if any further information is required for the same as our team is dedicatedly working on this. Bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=63130 ( PR : https://github.com/apache