Re: Migrate SVN -> Git

2019-05-27 Thread Vladimir Sitnikov
sebb> I meant that the Git repo would lose the SVN history. sebb>I did not look at the git repo any further once I had noted those two sebb>because I thought they were serious enough I've created https://issues.apache.org/jira/browse/INFRA-18499 I'm sure the removal of obsolete files is fine thoug

Re: Migrate SVN -> Git

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 21:59, Vladimir Sitnikov wrote: > > sebb> -1, because that loses all the SVN history. > > I'm afraid you are wrong. Could you please clarify what do you mean? I meant that the Git repo would lose the SVN history. > Note: SVN repository is NEVER killed. It would still be ar

Re: Migrate SVN -> Git

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 22:19, Vladimir Sitnikov wrote: > > I've moved this bit from "Gradle" thread to keep things separated. > > sebb> There is no way to map SVN revisions to Git commits, also the history > sebb> of deletions is lost > > As I said, SVN revisions are present in Git commit messages

Re: Migrate SVN -> Git

2019-05-27 Thread Vladimir Sitnikov
I've moved this bit from "Gradle" thread to keep things separated. sebb> There is no way to map SVN revisions to Git commits, also the history sebb> of deletions is lost As I said, SVN revisions are present in Git commit messages. Why do you think "there is no way to map"? sebb>the history sebb>

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread Vladimir Sitnikov
sebb> The email thread is still young; The mails regarding Gradle were around since February, and the first Gradle prototype was published on February 25 (==months ago). It is not like I suggest to change VCS and build system in a day. I did my best to gather opinions, evaluate corner cases, etc.

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 21:54, Vladimir Sitnikov wrote: > > sebb> Because it is harder to review. > > It looks like as if you are the only one who wants to review. The email thread is still young; I suspect people have not yet considered what is involved. > It is good (you care) and it is sad (no

Re: Migrate SVN -> Git

2019-05-27 Thread Vladimir Sitnikov
sebb> -1, because that loses all the SVN history. I'm afraid you are wrong. Could you please clarify what do you mean? Note: SVN repository is NEVER killed. It would still be around in read-only mode. sebb> AFAICT, there is no way to find historic SVN revisions in the cleaned-up repo SVN revisio

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread Philippe Mouawad
Hi Vladimir, I don't think there is only one willing to review. Just give us some time to review this final PR as it 's a big bunch of code. Thank you also for submitting separate PR fo fixes to bugs you saw while implementing the big one. Regards Regards On Mon, May 27, 2019 at 10:54 PM Vladi

Re: Migrate SVN -> Git

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 21:48, Philippe Mouawad wrote: > > Hi sebb, > > Few questions below. > > Regards > > On Mon, May 27, 2019 at 10:32 PM sebb wrote: > > > On Mon, 27 May 2019 at 21:19, Vladimir Sitnikov > > wrote: > > > > > > Hi, > > > > > > This thread has been idle for a while. > > > > > >

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread Vladimir Sitnikov
sebb> Because it is harder to review. It looks like as if you are the only one who wants to review. It is good (you care) and it is sad (no-one else cares) at the same time :-/ I do not care much the way we get to Git+Gradle, so let's migrate to Git first. Could you please review https://github.

Re: Migrate SVN -> Git

2019-05-27 Thread Philippe Mouawad
Hi sebb, Few questions below. Regards On Mon, May 27, 2019 at 10:32 PM sebb wrote: > On Mon, 27 May 2019 at 21:19, Vladimir Sitnikov > wrote: > > > > Hi, > > > > This thread has been idle for a while. > > > > The results (re move to Gradle) so far are: > > +1 (binding) Philippe Mouawad > > ++

Re: Migrate SVN -> Git

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 21:19, Vladimir Sitnikov wrote: > > Hi, > > This thread has been idle for a while. > > The results (re move to Gradle) so far are: > +1 (binding) Philippe Mouawad > ++1 (binding) Vladimir Sitnikov > +1 (binding) Antonio Gomes Rodrigues > +1 Andrey Pokhilko > +1 Graham Russel

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 20:11, Vladimir Sitnikov wrote: > > sebb> -1 > sebb> I object to combining the move to Git with a move to Gradle. > > Please check https://www.apache.org/foundation/voting.html > asf>To prevent vetos from being used capriciously, they > asf>must be accompanied by a technical

Re: Migrate SVN -> Git

2019-05-27 Thread Vladimir Sitnikov
Vladimir> re move to Gradle This should be "re move to Git". Sorry for confusion. In other words, The results (re move to Git) so far are: +1 (binding) Philippe Mouawad ++1 (binding) Vladimir Sitnikov +1 (binding) Antonio Gomes Rodrigues +1 Andrey Pokhilko +1 Graham Russell +1 (binding) Milamber

Re: Migrate SVN -> Git

2019-05-27 Thread Vladimir Sitnikov
Hi, This thread has been idle for a while. The results (re move to Gradle) so far are: +1 (binding) Philippe Mouawad ++1 (binding) Vladimir Sitnikov +1 (binding) Antonio Gomes Rodrigues +1 Andrey Pokhilko +1 Graham Russell +1 (binding) Milamber No vetos detected. That is there's a consensus to

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread Vladimir Sitnikov
sebb> -1 sebb> I object to combining the move to Git with a move to Gradle. Please check https://www.apache.org/foundation/voting.html asf>To prevent vetos from being used capriciously, they asf>must be accompanied by a technical justification asf>showing why the change is bad (opens a security ex

Re: [VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread sebb
On Mon, 27 May 2019 at 17:00, Vladimir Sitnikov wrote: > > Hi, > > I have developed a Gradle-based build system for JMeter. > Thanks everybody for comments/testing. > > The PR is #448: Migrate build system to Gradle > > > If no-one objects within 14 day

[VOTE] JMeter: migration to Git+Gradle

2019-05-27 Thread Vladimir Sitnikov
Hi, I have developed a Gradle-based build system for JMeter. Thanks everybody for comments/testing. The PR is #448: Migrate build system to Gradle If no-one objects within 14 days I'll assume lazy consensus and commit it. Note: migration to Git would

Build failed in Jenkins: JMeter-trunk #7201

2019-05-27 Thread Apache Jenkins Server
See Changes: [vladimirsitnikov] Use assumeTrue in testTimerBSH so it is properly marked as skipped in case it is skipped [vladimirsitnikov] Enforce Locale.US for tests that verify numeric processing (e.g. 0.42) [