Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-186879979
@d0k1 Thanks for your improvement patch. Committed on jmeter repo, sorry
for long delay for commit.
---
If your project is set up for it, you can reply to this ema
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user d0k1 commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-181558787
@milamberspace Thanks for pointing me a bug. I've fixed it, squashed all
commits into one.
---
If your project is set up for it, you can reply to this email and have your
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-181077864
@d0k1 don't forget to ping me on github after the update of your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/91#discussion_r52122001
--- Diff: src/core/org/apache/jmeter/gui/util/JSyntaxTextArea.java ---
@@ -90,6 +95,9 @@ public JSyntaxTextArea(int rows, int cols, boolean
disableUndo)
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-177597892
@d0k1: You can modify your PR to include the comments above directly on
your local branch, commit, squash your commits into one commit, push with
--force option to
Github user d0k1 commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-176916072
Hi! thanks for comments.
I'll make a bugzilla issue by myself, next time.
Could you tell me what should I do next?
---
If your project is set up for it, you can repl
Github user pmouawad commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-176471792
Hi,
Thanks for PR.
I created https://bz.apache.org/bugzilla/show_bug.cgi?id=58933 for follow
up.
@milamberspace I let you handle this.
@d0k1 , if yo
