Re: [GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

>So does that mean that PRs are mutable? Of course they are. Note: 1) If you access PR via git interface, you have immediate visibility that PR is updated. There's no way to mutate the contents of a commit. Its Id would have to be updated. 2) In github.com UI, commits/comments are ordered by

Re: [GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

On 3 April 2016 at 14:38, vlsi wrote: > Github user vlsi commented on the pull request: > > https://github.com/apache/jmeter/pull/176#issuecomment-204978579 > > > Sorry , I had some hallucination although I checked twice :-) , it is > package protected. > > You

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

Github user vlsi commented on the pull request: https://github.com/apache/jmeter/pull/176#issuecomment-204978579 > Sorry , I had some hallucination although I checked twice :-) , it is package protected. You are fine. I've just updated the PR as you suggested package-private.

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/176#issuecomment-204978544 +1 for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

On 3 April 2016 at 13:48, pmouawad wrote: > Github user pmouawad commented on the pull request: > > https://github.com/apache/jmeter/pull/176#issuecomment-204965711 > > Hi Vladimir, > Exposing public method for testing might introduce issues. > Users can think

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/176#issuecomment-204965711 Hi Vladimir, Exposing public method for testing might introduce issues. Users can think that field is persisted in JMX while it's not. Can't it be

[GitHub] jmeter pull request: Use explicit timeout for TestDNSCacheManager,...

GitHub user vlsi opened a pull request: https://github.com/apache/jmeter/pull/176 Use explicit timeout for TestDNSCacheManager, so test is executed faster `org.apache.jmeter.protocol.http.control.TestDNSCacheManager#testCloneWithCustomResolverAndInvalidNameserver` took 30 seconds