[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/432 ---

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-27 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r236800696 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -137,67 +160,138 @@ private void checkDirtyAndLoad(final ActionEvent a

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-27 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r236801357 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -137,67 +160,138 @@ private void checkDirtyAndLoad(final ActionEvent a

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235119001 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -207,19 +290,35 @@ private void init() { // WARNING: called from ctor s

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235117129 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -137,67 +160,127 @@ private void checkDirtyAndLoad(final ActionEvent a

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235125307 --- Diff: src/core/org/apache/jmeter/gui/action/template/TemplateManager.java --- @@ -149,19 +109,107 @@ public TemplateManager reset() {

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235118443 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -137,67 +160,127 @@ private void checkDirtyAndLoad(final ActionEvent a

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235125815 --- Diff: src/core/org/apache/jmeter/gui/action/template/TemplateManager.java --- @@ -149,19 +109,107 @@ public TemplateManager reset() {

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235127351 --- Diff: src/core/org/apache/jmeter/gui/action/template/TemplateManager.java --- @@ -149,19 +109,107 @@ public TemplateManager reset() {

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235121173 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -207,19 +290,35 @@ private void init() { // WARNING: called from ctor s

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235114098 --- Diff: bin/templates/recording.jmx --- @@ -90,32 +101,32 @@ - .*toolbar\.live\.com.*

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235117924 --- Diff: src/core/org/apache/jmeter/gui/action/SelectTemplatesDialog.java --- @@ -137,67 +160,127 @@ private void checkDirtyAndLoad(final ActionEvent a

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235127891 --- Diff: src/core/org/apache/jmeter/resources/messages.properties --- @@ -1206,6 +1206,7 @@ teardown_on_shutdown=Run tearDown Thread Groups after shutdo

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-20 Thread FSchumacher
Github user FSchumacher commented on a diff in the pull request: https://github.com/apache/jmeter/pull/432#discussion_r235128465 --- Diff: src/core/org/apache/jmeter/util/TemplateUtil.java --- @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] jmeter pull request #432: Bug 62870 / Templates : Add ability to provide par...

2018-11-19 Thread ubikloadpack
GitHub user ubikloadpack opened a pull request: https://github.com/apache/jmeter/pull/432 Bug 62870 / Templates : Add ability to provide parameters ## Description This is the implementation of a feature in enhancement list: "Templates : Add ability to provide parame