Re: BoundaryExtractor#extract method

2017-12-10 Thread Philippe Mouawad
On Sun, Dec 10, 2017 at 1:05 PM, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Hi all, > > a few questions on the extract method. > > Does it have to be public? It seems to be called in > extractMatchingStrings, only. > It wasn't initially. It was made public for RenderAsBoundary

BoundaryExtractor#extract method

2017-12-10 Thread Felix Schumacher
Hi all, a few questions on the extract method. Does it have to be public? It seems to be called in extractMatchingStrings, only. If it stays public, shouldn't it have tests? Is the condition "matchNumber <= 0 || newFound != matchNumber" the correct one? What happens when found is given with