Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

I created a bug to track this: https://bz.apache.org/bugzilla/show_bug.cgi?id=59241 I closed 59173 Regards On Fri, Mar 25, 2016 at 1:42 PM, Antonio Gomes Rodrigues wrote: > Hi Sebb, > > Thanks to your quick answer, now it's more cleare to

Re: JMX size (was svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java)

Ok no problem Thank to your clear answer Cet e-mail a été envoyé depuis un ordinateur protégé par Avast. www.avast.com <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2> 2016-03-25 14:32 GMT+01:00

JMX size (was svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java)

On 25 March 2016 at 12:42, Antonio Gomes Rodrigues wrote: > Hi Sebb, > > Thanks to your quick answer, now it's more cleare to me > > If file size is a problem, I don't think to keep xml format is a good idea I didn't write that size was a problem, merely that not saving defaults means smaller fil

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

Hi Sebb, Thanks to your quick answer, now it's more cleare to me If file size is a problem, I don't think to keep xml format is a good idea Antonio 2016-03-25 13:26 GMT+01:00 sebb : > On 25 March 2016 at 11:12, Antonio Gomes Rodrigues > wrote: > > Hi, > > > > Why not define a new JMX output

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On 25 March 2016 at 11:12, Antonio Gomes Rodrigues wrote: > Hi, > > Why not define a new JMX output to 3.0? > > If the new format save all the value (default or not), is that problem > would be solved and never appear? No, because every time a new property is added, the JMX would change. That is

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

Hi, Why not define a new JMX output to 3.0? If the new format save all the value (default or not), is that problem would be solved and never appear? If yes, why don't have the 2 solutions for 3.0 (Save old format + Save new format) and deprecated old format some release later? Antonio 2016-03-

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On 23 March 2016 at 19:31, Philippe Mouawad wrote: > On Wed, Mar 23, 2016 at 7:41 PM, sebb wrote: > >> On 23 March 2016 at 18:23, Philippe Mouawad >> wrote: >> > On Wed, Mar 23, 2016 at 4:16 PM, sebb wrote: >> > >> >> On 23 March 2016 at 15:02, Philippe Mouawad > > >> >> wrote: >> >> > I guess

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

and anyway, thanks for fixing the 3 other issues that I thought would be tougher to fix On Wednesday, March 23, 2016, Philippe Mouawad wrote: > > > On Wed, Mar 23, 2016 at 7:41 PM, sebb > wrote: > >> On 23 March 2016 at 18:23, Philippe Mouawad > > wrote: >> > On Wed, Mar 23, 2016 at 4:16 PM, se

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On Wed, Mar 23, 2016 at 7:41 PM, sebb wrote: > On 23 March 2016 at 18:23, Philippe Mouawad > wrote: > > On Wed, Mar 23, 2016 at 4:16 PM, sebb wrote: > > > >> On 23 March 2016 at 15:02, Philippe Mouawad > > >> wrote: > >> > I guess the clean way would have been to do something like this (not >

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On 23 March 2016 at 18:23, Philippe Mouawad wrote: > On Wed, Mar 23, 2016 at 4:16 PM, sebb wrote: > >> On 23 March 2016 at 15:02, Philippe Mouawad >> wrote: >> > I guess the clean way would have been to do something like this (not >> > tested) to avoid saving the arguments that are equal to defa

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On Wed, Mar 23, 2016 at 4:16 PM, sebb wrote: > On 23 March 2016 at 15:02, Philippe Mouawad > wrote: > > I guess the clean way would have been to do something like this (not > > tested) to avoid saving the arguments that are equal to default values: > > It's only the NEW argument that needs to be

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On 23 March 2016 at 15:02, Philippe Mouawad wrote: > I guess the clean way would have been to do something like this (not > tested) to avoid saving the arguments that are equal to default values: It's only the NEW argument that needs to be omitted if it is the default. Note that the code already

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

I guess the clean way would have been to do something like this (not tested) to avoid saving the arguments that are equal to default values: public void setArguments(Arguments args) { try { BackendListenerClient client = (BackendListenerClient) Class.forName(getClassname(),

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

On 22 March 2016 at 19:12, Philippe Mouawad wrote: > Hello sebb, > Although this fixes the issue, it seems to me as a violation of the > architecture . > BackendListener should not be aware of a particular implementation of > BackendListenerClient : GraphiteBackendListenerClient If you can move t

Re: svn commit: r1736119 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java

Hello sebb, Although this fixes the issue, it seems to me as a violation of the architecture . BackendListener should not be aware of a particular implementation of BackendListenerClient : GraphiteBackendListenerClient Regards On Tue, Mar 22, 2016 at 1:54 AM, wrote: > Author: sebb > Date: Tue M