Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/81
Cool thanks @thammegowda. One thing to be aware of is that as you increase
JVM memory you effectively take away memory from KenLM. What I've done in the
past is just run a quick
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/81
@thammegowda Are you using a kenlm language model?
---
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/79
JOSHUA-324 renamed LICENSE, removed minification of license in bootstâ¦
â¦rap.min.css
Small patch to make detection of the license easier in this minified file.
I
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/77
Tweaked Dockerfile to contain only jre 1.8 and to use mvn package
Just some small changes here. I found when creating files with the
previous version that is was often using java
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/69#discussion_r8215
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
* of any actual decoding algorithm. Rather
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/68
KenLM JNI optimization
I've cleaned up the code from the previous PR (#65) that had the @kpu's
perf increase. I've removed the code that was specific to the estimate call
as we
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/65
Well in that case I can open a PR without the DirectBuffer changes
included. They're pretty complicated and if they don't improve performance
it's probably better to leave them
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/65
@kpu I partially agree about sentence. The sentence object is meant to be
scoped to a single translation of a sentence. For calls to probRule this helps
disambiguate
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/65
This PR is a first attempt to minimize ngram array copies by utilizing
DirectBuffers.
This is a work in progress but posted so that Matt + Ken can review (and do
some speed
Github user KellenSunderland closed the pull request at:
https://github.com/apache/incubator-joshua/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/42
Wow Max, great update. Many thanks! I total agree on the questionable
finalizes. The code cleanup in general looks great, lots of dead code removed
there.
As mentioned
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/42#discussion_r76822903
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -264,66 +215,65 @@ public static void main(String
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/42#discussion_r76822076
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -188,62 +188,13 @@ public TrieLM(ArpaFile arpaFile
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/48
Hey Matt, exactly right for the summary.
I am actually not sure how often collisions happen, it may be worth
measuring. Collisions causing crashing in this scenario happen
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/47
Fix Travis-CI by adding a step to install ant on OSX
It looks like the download-deps.sh now requires ant to build BerkleyLM? If
so feel free to merge this, it should make sure
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/46
The update merges from master and applies some refactoring.
This PR has the merge from master with the Threading change. On top of
that merge I've got one commit that reduces
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/45
Refactored the threading code in the JoshuaDecoder class.
These commits do some refactoring and reworking of the threading code in
JoshuaDecoder. The principal motivation
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/36
LGTM. Took a quick look at the test fail and also don't see an obvious
reason for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/33
Hey Matt, $JOSHUA/lib is fine with me. Just thought I'd double check that
I shouldn't be giving it another path.
---
If your project is set up for it, you can reply to this email
GitHub user KellenSunderland reopened a pull request:
https://github.com/apache/incubator-joshua/pull/35
Add OSX building to .travis.yml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KellenSunderland/incubator-joshua travis2
Github user KellenSunderland closed the pull request at:
https://github.com/apache/incubator-joshua/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user KellenSunderland reopened a pull request:
https://github.com/apache/incubator-joshua/pull/35
Add OSX building to .travis.yml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KellenSunderland/incubator-joshua travis2
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/34
Enable basic travis build
This should get us started with Travis. I'll open a PR to see if we're at
least passing with a basic config, then add some more build steps later.
You
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/33
Refactored unit tests to all use TestNG, removed no longer applicableâ¦
⦠tests, refactored KenLM in order to make handling upstream errors easier
You can merge this pull
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/commit/3fb809c444c7855255b51080c368071bc508be1f#commitcomment-17819917
So before this change all tests were actually running for me (thanks to the
test runner included). I don't
Github user KellenSunderland commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
Thanks for the merge. Looks like there's two tests still failing. The
build server is complaining about basicVocabTest, and you have issues with the
multithreaded tests. I'll
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/22
This patch enables junit tests. Fixes a bug with FeatureVector
Re-enabled JUnit tests with a newer surefire plugin; fixed some of the
tests; KenLM tests have been temporarily
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011143
Does setting it to error instead of info help?
On May 27, 2016 12:04 AM, "Matt Post" <notificati...@github.com> wrote:
&g
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-220772283
Hey Thamme, thanks for the great PR. Haven't checked the build yet myself
but the commit looks good to me.
---
If your project is set up for it, you
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132137
--- Diff: src/main/java/org/apache/joshua/util/CompareGrammars.java ---
@@ -134,15 +132,15 @@ public static void compareValues(File
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132143
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaDecoder.java ---
@@ -84,12 +79,13 @@ public static void main(String[] args) throws
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132090
--- Diff:
src/main/java/org/apache/joshua/util/encoding/FeatureTypeAnalyzer.java ---
@@ -122,7 +123,7 @@ public void inferTypes(boolean
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64132048
--- Diff:
src/main/java/org/apache/joshua/util/encoding/FeatureTypeAnalyzer.java ---
@@ -122,7 +123,7 @@ public void inferTypes(boolean
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131989
--- Diff: src/main/java/org/apache/joshua/util/CompareGrammars.java ---
@@ -117,11 +115,11 @@ public static void compareValues(File
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131955
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131960
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131952
--- Diff: src/main/java/org/apache/joshua/util/Cache.java ---
@@ -104,20 +104,18 @@ public Cache() {
@Override
public V
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131932
--- Diff: src/main/java/org/apache/joshua/tools/GrammarPackerCli.java ---
@@ -146,7 +147,7 @@ public static void main(String[] args) throws
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131711
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -141,7 +138,7 @@ public TrieLM(ArpaFile arpaFile
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131682
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilterLanguageModel.java
---
@@ -62,7 +63,7
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131583
--- Diff: src/main/java/org/apache/joshua/decoder/ff/lm/ArpaFile.java ---
@@ -180,21 +177,21 @@ public Vocabulary getVocab
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131585
--- Diff: src/main/java/org/apache/joshua/decoder/ff/lm/ArpaFile.java ---
@@ -209,10 +206,10 @@ public int getOrder() throws
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131303
--- Diff: src/main/java/org/apache/joshua/corpus/Vocabulary.java ---
@@ -45,6 +47,7 @@
public class Vocabulary
Github user KellenSunderland commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/15#discussion_r64131297
--- Diff: src/main/java/org/apache/joshua/decoder/Decoder.java ---
@@ -786,7 +783,7 @@ private void initializeTranslationGrammars() throws
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/11
Removed a few unneeded allocations
This is the last commit from us targeting short lived object allocations.
I've separated this from the other commits because this line might
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/9
More work on structuring translation output
These commits focus on two areas:
- One is structured translation output, and this should be our last PR for
this topic
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/pull/6#issuecomment-215274462
Closing this PR temporarily as we want to tweak some commit messages.
---
If your project is set up for it, you can reply to this email and have your
Github user KellenSunderland closed the pull request at:
https://github.com/apache/incubator-joshua/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user KellenSunderland opened a pull request:
https://github.com/apache/incubator-joshua/pull/6
More work on structuring translation output
These commits focus on two areas:
* One is structured translation output, and this should be our last PR for
this topic
Github user KellenSunderland commented on the pull request:
https://github.com/apache/incubator-joshua/pull/2#issuecomment-215097582
Thanks for the merge Matt. I'll take a look at the commit you mention and
rebase the next PR on top of it.
---
If your project is set up for it, you
50 matches
Mail list logo
