Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/70
This PR should be closed @cocoxu can you please close off? Thank you
---
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/71
Or port to master?
---
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/71
Close this one off @tteofili ?
---
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/76
Once complete I'll squash all commits and merge into master branch. Release
procedure is coming together over on
https://cwiki.apache.org/confluence/display/JOSHUA/Joshua+Release+Manag
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/76
Release
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-323
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/75
JOSHUA-322 extract-1best script references non-existent execution paths
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-322
You can merge this pull request into a Git
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/74
JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-321
You can merge this pull request into a
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/73
A further comment, I just closed off
https://issues.apache.org/jira/browse/JOSHUA-319, this is because I am able to
run end to end pipelines without a hitch now. The only barrier is
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/73
The most recent commit I submitted here also addresses
[JOSHUA-317](https://issues.apache.org/jira/browse/JOSHUA-317) and
[JOSHUA-318](https://issues.apache.org/jira/browse/JOSHUA-318) as
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/73
BTW I am using Python 3.5 here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/73
JOSHUA-316 run_bundler.py returning JOB FAILED (return code 1) TypeError:
memoryview: a bytes-like object is required, not 'str'
This issue addresses https://issues.apache.org/j
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/67
ack ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/67
JOSHUA-299 Move regression tests to proper unit tests
Hi folks, this is one stage closer to us addressing
https://issues.apache.org/jira/browse/JOSHUA-299
Of note here, I manually
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/commit/ff410c297a149400db3cb553b11a930ad01dc7ed#commitcomment-18745888
The Javadoc was manual this time. I was just trying to stabalize master.
From now on I'll remember line wra
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Boom goes the dynamite
On Aug 17, 2016 3:33 AM, "Matt Post" wrote:
> Awesome, that merged really cleanly. There is now a pushed 7 branch that
> we can b
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Sounds like an excellent roadmap. I would hate to see things get too out of
sync so I will be conscious of that. Excellent work folks.
---
If your project is set up for it, you can reply
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
@mjpost so is the proposal to include this in 6.1? Or 7 only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/32
Can someone please merge in to master? Thanks @john-hewitt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/32
@john-hewitt thanks for the PR :)
If you could address the suggested improvements it would be greatly
appreciated.
---
If your project is set up for it, you can reply to this email and
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566150
--- Diff: src/main/java/org/apache/joshua/decoder/Decoder.java ---
@@ -496,7 +496,7 @@ public Decoder initialize(String configFile
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566062
--- Diff: scripts/support/make-release.sh ---
@@ -40,7 +40,7 @@ echo "Bundling up joshua-$version"
[[ ! -d release ]] && mkd
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566047
--- Diff: CHANGELOG ---
@@ -139,7 +139,7 @@ They include:
- Significantly improved and expanded documentation (both user and
developer
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566005
--- Diff: .gitignore ---
@@ -42,6 +42,7 @@ doxygen_*.tmp
.cachepipe
joshua-decoder.org
+joshua.apache.org
--- End diff
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
This is dynamite. I'll pull later and check it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/8
> @lewismc, do you mind closing this PR? I don't have write access and
can't, and this has been fixed elsewhere.
No problems. Thanks @mjpost
---
If your proj
Github user lewismc closed the pull request at:
https://github.com/apache/incubator-joshua/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12
Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can
Mavenize it and get it in to Maven Central so we can use it as a dependency in
pom.xml
---
If your project is
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985
ack
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-80223
yes @thammegowda the process is welcome and appreciated Sir. on a side note
hove you tried th Docker containersTZ?
---
If your project is set up for it, you
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-38661
> I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files
will override the jar? So I can do fast development in Eclipse?
Yes all
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-35694
Its more than overdue as well for me to say @thammegowda thank you. The
Logging effort is absolutely paradise. I looked at a lot of code during
reformat and
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-35386
OK @mjpost thanks
@thammegowda for starters, more or less every file that you write at
Apache, and that you wish to build community around should probably
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-04155
Make an entry in logging file?
Parameterized logging as implemented by @thammegowda is magnitudes more
efficient than traditional string + Excepton logging
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387
@thammegowda please revert logging patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050
What kind of 'tests' are we talking about here? The only tests which I know
of are invoked by running ```mvn clean test```. These execute very quick
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222003720
Excellent
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222002633
There will be a number of scripts which we need to update with the paths to
the generated jar files. This is all part of the new build.
---
If your project
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221933542
Hi @mjpost thanks for response
```
Do you want me to be the one to merge master into JOSHUA-252? Then we can
test and merge back into master. I think
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221793740
Cool @thammegowda
#15 merged into JOSHUA-252
Work still to be done
* plan on how we are going to compile and package GIZA++, KenLM
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221779115
Cool @thammegowda
#14 is merged.
Work still to be done
#13 merged
work still to be done
* merge #15 into JOSHUA-252
* plan
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221777380
#14 is merged.
Work still to be done
* merge #13 into JOSHUA-252 branch
* merge #15 into JOSHUA-252
* plan on how we are going to compile and
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221776975
hi @thammegowda thanks for reply
* #13 should be able to merge with this branch (have conflicts now, but i
can resolve them)
Please rebase the
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221775479
@thammegowda @mjpost OK the Maven build is now 'stable'.
We need to list which changes have been made to master branch since this
work began.
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753694
I'll have the Javadoc for this PR finished tonight. The build will then be
'stable'.
At that stage we can rebase @thammegowda 's m
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219620953
You can build it locally by simply using the following scope
```
edu.berkeley.nlp
jberkeleyaligner
X
system
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219587186
Yep I'll add all of this to the wiki space. In the meantime you can do
mvn eclipse:eclipse
Easy as that
On Monday, May 16, 2016,
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219586971
Nice, I've been working on the eats for the last hour or so, so I'll update
feature branch once this is done.
@matt did you merge this PR in
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219359416
The next step here is for me to stabilize the test suite. This will involve
putting the test resources in to src/test/resources and then removing the top
level
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219358227
Hi Folks, this is now a feature branch and can be found at
https://github.com/apache/incubator-joshua/tree/JOSHUA-252
I have set up a build for the branch
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219341230
No way, I actually found the file online
http://www.programcreek.com/java-api-examples/index.php?source_dir=relax-decode-master/third-party/joshua-1.3/src
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219341169
ACK @mjpost I knew this. I am tempted to merely skip the ones for which
classes no longer exist. I'm going to try and stabilize the build tonight.
-
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219339642
@mjpost do you know where I can find the class ArpaFile.java ? It is
referenced within
[src/test/java/org/apache/joshua/decoder/ff/lm/ArpaFileTest.java|https
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219339426
I agree as well
It's pretty huge as I said so we need lots of eyes on it.
Current compilation issues as as follows
```
[INFO] 100 e
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219336222
ACK
Safe flight Kellen.
On Sun, May 15, 2016 at 7:25 PM, Kellen Sunderland wrote:
> Hey Lewis. I'm flying today but can take a
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321
The PR is not finished yet. There are a number of issues as highlighted
above which need attention.
---
If your project is set up for it, you can reply to
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/12
JOSHUA-252 Make it possible to use Maven to build Joshua
Hi Folks,
This PR is a beast. I think a Google Hangout would be best to talk through
what is going on.
Basically it
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/8#issuecomment-215571337
I also noted this issue over on
https://github.com/joshua-decoder/joshua_translation_engine/issues/15
---
If your project is set up for it, you can reply to
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/8
JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-258
You can merge this pull request into a Git repository by
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/7
JOSHUA-257 Add license headers to all Python scripts
This issues addresses https://issues.apache.org/jira/browse/JOSHUA-257
You can merge this pull request into a Git repository by running
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/5
JOSHUA-256 Note that Joshua builds and runs with >= Java 1.8
This PR addresses https://issues.apache.org/jira/browse/JOSHUA-256
You can merge this pull request into a Git repository
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/4
JOSHUA-255 License headers for all bash scripts
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-255
You can merge this pull request into a Git repository by running
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/3
JOSHUA-254 Update README with correct branding
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-254
You can merge this pull request into a Git repository by running
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/1#issuecomment-205484099
Cool thanks for clarifying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/1#issuecomment-205475425
@mjpost "...I just pulled this in ",
pulled it in to where? Thanks
---
If your project is set up for it, you can reply to this email and
64 matches
Mail list logo
