Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/70
This PR should be closed @cocoxu can you please close off? Thank you
---
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/71
Or port to master?
---
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/71
Close this one off @tteofili ?
---
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/74
JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-321
You can merge this pull request
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/73
A further comment, I just closed off
https://issues.apache.org/jira/browse/JOSHUA-319, this is because I am able to
run end to end pipelines without a hitch now. The only barrier
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/73
The most recent commit I submitted here also addresses
[JOSHUA-317](https://issues.apache.org/jira/browse/JOSHUA-317) and
[JOSHUA-318](https://issues.apache.org/jira/browse/JOSHUA-318
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/73
BTW I am using Python 3.5 here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/73
JOSHUA-316 run_bundler.py returning JOB FAILED (return code 1) TypeError:
memoryview: a bytes-like object is required, not 'str'
This issue addresses https://issues.apache.org/jira/browse
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/67
ack ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Boom goes the dynamite
On Aug 17, 2016 3:33 AM, "Matt Post" <notificati...@github.com> wrote:
> Awesome, that merged really cleanly. There is no
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
@mjpost so is the proposal to include this in 6.1? Or 7 only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566062
--- Diff: scripts/support/make-release.sh ---
@@ -40,7 +40,7 @@ echo "Bundling up joshua-$version"
[[ ! -d release ]] && mkd
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566047
--- Diff: CHANGELOG ---
@@ -139,7 +139,7 @@ They include:
- Significantly improved and expanded documentation (both user and
developer
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/32#discussion_r72566005
--- Diff: .gitignore ---
@@ -42,6 +42,7 @@ doxygen_*.tmp
.cachepipe
joshua-decoder.org
+joshua.apache.org
--- End diff
Github user lewismc commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
This is dynamite. I'll pull later and check it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/8
> @lewismc, do you mind closing this PR? I don't have write access and
can't, and this has been fixed elsewhere.
No problems. Thanks @mjpost
---
If your project is set
Github user lewismc closed the pull request at:
https://github.com/apache/incubator-joshua/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12
Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can
Mavenize it and get it in to Maven Central so we can use it as a dependency in
pom.xml
---
If your project
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985
ack
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-38661
> I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files
will override the jar? So I can do fast development in Eclipse?
Yes all
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-04155
Make an entry in logging file?
Parameterized logging as implemented by @thammegowda is magnitudes more
efficient than traditional string + Excepton logging
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387
@thammegowda please revert logging patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050
What kind of 'tests' are we talking about here? The only tests which I know
of are invoked by running ```mvn clean test```. These execute very quickly
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222002633
There will be a number of scripts which we need to update with the paths to
the generated jar files. This is all part of the new build.
---
If your project
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221793740
Cool @thammegowda
#15 merged into JOSHUA-252
Work still to be done
* plan on how we are going to compile and package GIZA++, KenLM
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219586971
Nice, I've been working on the eats for the last hour or so, so I'll update
feature branch once this is done.
@matt did you merge this PR into feature
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219336222
ACK
Safe flight Kellen.
On Sun, May 15, 2016 at 7:25 PM, Kellen Sunderland <notificati...@github.com
> wrote:
> Hey Lewis. I
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321
The PR is not finished yet. There are a number of issues as highlighted
above which need attention.
---
If your project is set up for it, you can reply
Github user lewismc commented on the pull request:
https://github.com/apache/incubator-joshua/pull/8#issuecomment-215571337
I also noted this issue over on
https://github.com/joshua-decoder/joshua_translation_engine/issues/15
---
If your project is set up for it, you can reply
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/8
JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-258
You can merge this pull request into a Git repository
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/5
JOSHUA-256 Note that Joshua builds and runs with >= Java 1.8
This PR addresses https://issues.apache.org/jira/browse/JOSHUA-256
You can merge this pull request into a Git reposit
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/4
JOSHUA-255 License headers for all bash scripts
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-255
You can merge this pull request into a Git repository by running
GitHub user lewismc opened a pull request:
https://github.com/apache/incubator-joshua/pull/3
JOSHUA-254 Update README with correct branding
This issue addresses https://issues.apache.org/jira/browse/JOSHUA-254
You can merge this pull request into a Git repository by running
33 matches
Mail list logo
