Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/79
Thanks for catching this, Kellen. I'll pull this in as soon as travis
completes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/65
I did some timing tests on commit 3ba83f84e8258a784fcef509fc9b158d44f15c66,
and didn't see any change.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjpost closed the pull request at:
https://github.com/apache/incubator-joshua/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/58
Ah, right. Note that the test works from the command line:
cd $JOSHUA/joshua-core
cat src/test/resources/bn-en/hiero/input.bn |
$JOSHUA/bin/joshua-decoder -c src/test
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/58
My guess is that grammar weights need reversing, but then I wonder why we
haven't had to do that for other tests. I'll check this out later in the
morning.
---
If your project is set up
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/54
Progress on JOSHUA-299.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/52
Okay, this is merged in, obviously. But merging these back into 7 is
turning into a pain. Since development is stopping on master, lets just do the
rest of these on the 7 branch directly
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
No big deal, but if you update this pull request to be against the "7"
branch instead of master, it will be marked as resolved.
---
If your project is set up for it, you
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/49
Pushed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/42
Yes, please merge master into 7!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/42
So am I correct that this is ready to merge into master?
And @maxthomas, you think you can merge this into 7?
---
If your project is set up for it, you can reply to this email
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/47
A better option here would be to upgrade the [Berkeley
Aligner](https://github.com/joshua-decoder/berkeleyaligner/tree/master/src/edu/berkeley/nlp)
(Joshua's version) to Maven
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/48
Holy smokes, thanks for tracking this down. So if I understand correctly,
this only occurs under the following circumstances:
- decoding with multiple KenLM language models
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/42
So, @maxthomas â what do you think about either of the following:
- You (a) remerge master into this, and then (b) merge master into 7
- Skip (a) and just rework this against
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/d4fdbfd88bab99e244d3ed1fc9cff4ba5e6d124c#commitcomment-18760447
I think maybe no, since all the feature functions are loaded using
reflection. This could be a method available only
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/d4fdbfd88bab99e244d3ed1fc9cff4ba5e6d124c#commitcomment-18742703
The whole static global feature index is a mess. You've gotten rid of the
dense feature indices on the 7 branch. What
GitHub user mjpost opened a pull request:
https://github.com/apache/incubator-joshua/pull/44
Moved test case files
Moved test cases files from resources/ to src/test/resources. Also fixed
bug in LmOovFeatureTest.
You can merge this pull request into a Git repository by running
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/43
Followup: this appears to have something to do with a failed global state
cleanup from a prior test run. Fixed (temporary at least) at commit
d4fdbfd88bab99e244d3ed1fc9cff4ba5e6d124c
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/43
More information:
- On OS X, remove $JOSHUA/lib/libken.dylib, run "mvn test" â FAILURE
- Same, but run the individual test from Eclipse â PASSES
- Same, but run
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/43
Strange: the LmOovFeatureTest is failing again when KenLM is not available,
but now it's on a Mac OS X instance, and not on the Linux one. I'm tempted to
disable this test because its
GitHub user mjpost opened a pull request:
https://github.com/apache/incubator-joshua/pull/43
Phrase-based decoder rewrite
The phrase-based decoder used to add nonterminals to every phrase-based
rule, treating all such rules as left-branching ones. This was a hassle because
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/42
All right; maybe hold off and let me finish and merge in one other
large-ish commit, and then I'll take a look at this. It's possible it will be
easier than I anticipate.
---
If your
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/42
This actually looks really great, but I'm worried about the complexity of
merging this with the 7, which moves every file and changed a bunch with
refactoring the feature function interface
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/41
This looks great. I put it on a new branch off 7 so that we can Travis-CI
it (on the idea that 7 is its own master). Once we get all the regression tests
removed and merged in from master
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/40
I actually think this might have been auto-inserted by Eclipse somehow
(resolving to the wrong version of a library). So, good find, and thanks for
submitting.
---
If your project is set
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/3e2e053db9cafcdc5b4885a0f6fa5e54a63bc468#commitcomment-18672288
No
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Awesome, that merged really cleanly. There is now a pushed 7 branch that we
can begin work on for release 7.
[Travis-CI](https://travis-ci.org/apache/incubator-joshua/builds/152931806
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Yeah, that was one of our main concerns, too. Which is why we want to get
this into master as soon as possible. There are some nasty merges ahead of us,
but the unit tests should help pull
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
We wanted to include this in 6.1, but felt that a responsible manager would
say that it is non-critical and that we should instead base our future release
on it.
We rebuilt
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/37
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/0663a9c7f704e1fc911d1792910ca9337840553b#commitcomment-18511694
@KellenSunderland do you have a minute to look at this? I thought this had
passed CI tests, but Travis [is now telling
GitHub user mjpost opened a pull request:
https://github.com/apache/incubator-joshua/pull/36
Demo
Made some improvements to the Joshua demo under demo/.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjpost/incubator-joshua demo
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/33
This passes for me, and $JOSHUA/lib is the currently correct place. I'm
fine to move it if there is a more conventional location. Would $JOSHUA/target
make more sense, or something else
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/29
Looks great to me, thanks for the contrib!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/3fb809c444c7855255b51080c368071bc508be1f#commitcomment-17995203
I don't have any experience that would drive this decision, but I agree we
should decide on one. Currently, eclipse
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/748cf32f956d3fd5772f62e023d0cc8d70a7dcad#commitcomment-17994955
No problem, it didn't get triggered until I had a small case where I
actually asked for the alignments on output
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/748cf32f956d3fd5772f62e023d0cc8d70a7dcad#commitcomment-17994847
Sure â UNKNOWN_OWNER is a String, so the constructor that gets called is
[this
one](https://github.com/apache
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/25
Okay, this checks out, producing virtually the same scores in two settings:
(1) re-decoding a test set with an existing model (built with the
non-state-minimizing LM), but swapping
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/26
Great, this checks out for me. Since it contains the class LM fix, too,
though, I'll wait to merge until those tests pass.
---
If your project is set up for it, you can reply to this email
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/25
This passes my regression tests. I am now testing it on an actual tuning /
testing run for en-fi.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
Thanks, @logogin. I have only glanced at this, but it seems like a good
idea. I hope to be able to take a look tonight, and expect all will be well. Do
you want more discussion, or should I
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17933088
In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java:
In src/main/java/org/apache/joshua/decoder
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/24
This looks cool to me. Is this a recent pattern or something? I just
noticed a similar approach on the
[deeplearning4j](https://github.com/deeplearning4j/deeplearning4j) repo.
---
If your
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
I am in fact, thanks, @logogin. I'll try to post next week :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
I am happy to have just learned about "mvn test" :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mjpost commented on the issue:
https://github.com/apache/incubator-joshua/pull/22
Okay, I merged this. Notes:
- To get it working, I had to rerun "mvn eclipse:eclipse"
- I also had to rebuild the JUnit test configuration. I think this might
have to
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12
Unless there are any objections, I'd like to merge this branch back into
master. There are a few small issues, but none that can't be addressed with
documentation. I'd love to do
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/19#issuecomment-52934
Thanks! You should have commit access soon. I think @lewismc knows how to
do this?
---
If your project is set up for it, you can reply to this email and have
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-37297
Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean
that eclipse compiled files will override the jar? So I can do fast development
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-04726
Yes, I hope I was clear that this is all great work. We just have to figure
out how to get log4j to read the config file, which it's currently not doing
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-3
Just to be clear, not sure it needs to be reverted. We just need to find a
way to make sure the config file gets read and that logging gets set to INFO
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222120221
I went into joshua/decoder/chart_parser/ComputeNodeResult; adding and
removing the following lines makes a huge difference in speed. So it looks like
logging
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222118458
On a hunch, I went through and removed all the calls LOG.*() in Decoder,
DecoderThread, JoshuaDecoder, Translation, Chart, DotChart, and
ComputeNodeResult
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222032586
Okay, I just pushed up the changes after merging in master and making some
other changes to that the tests will run (with manual calls). The code on
master runs
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222016587
Also, multithreading is broken. I randomly (not always) get the following
error when decoding with more than 1 thread:
```
Exception in thread
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222013844
Okay, cool. It doesn't seem to look for that file automatically, though; if
I remove the -Dlog4j.configuration, it doesn't find the file you pointed to. So
I am
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011444
Okay, the answer is that our slfj4 is using log4j12 as the backend. I had
to add
-Dlog4j.configuration=$JOSHUA/logging.properties
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222008424
Can someone tell me how to turn off logging in slf4j? I have tried passing
-Dorg.slf4j.Logger.defaultLogLevel=info
but this does not seem
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222003148
Yep, working through those. Making good progress on the build. Once I can
verify that the test cases pass under the new build (so I can know I've done
the merge
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-222000585
Nevermind, found Thamme's [old
instructions](https://github.com/apache/incubator-joshua/pull/14#issue-155139645).
---
If your project is set up for it, you can
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221969513
Okay, cool, I got this merged and compiling. First, THANK YOU for all of
this amazing work! This feels like a real milestone and it was fun to work
through
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-221928486
There have been changes on master (JOSHUA-271 and JOSHUA-272), will try to
get to this soon, probably not till tomorrow.
Do you want me to be the one
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f2f82c38af9aebd28f9d27f685a2e99767a2e575#commitcomment-17620761
In src/joshua/decoder/hypergraph/KBestExtractor.java:
In src/joshua/decoder/hypergraph/KBestExtractor.java on line 93
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f2f82c38af9aebd28f9d27f685a2e99767a2e575#commitcomment-17620750
In src/joshua/decoder/Translations.java:
In src/joshua/decoder/Translations.java on line 49:
That's a very good
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f2f82c38af9aebd28f9d27f685a2e99767a2e575#commitcomment-17620554
In src/joshua/decoder/Decoder.java:
In src/joshua/decoder/Decoder.java on line 39:
No, not sure who added
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f2f82c38af9aebd28f9d27f685a2e99767a2e575#commitcomment-17620548
In src/joshua/decoder/Decoder.java:
In src/joshua/decoder/Decoder.java on line 193:
This is a bug, needs
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618558
In src/joshua/decoder/ff/tm/Rule.java:
In src/joshua/decoder/ff/tm/Rule.java on line 201:
Yes, definitely
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/16#issuecomment-221659544
Awesome, thanks for the PR! Give me a few days to look it over and I'll get
back to you.
---
If your project is set up for it, you can reply to this email
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/12#issuecomment-219586976
I didn't see your JOSHUA-252 branch. I just created a "maven" branch that
pulls PRs 4 and 5 into this one. However, I don't see these on github /
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/14#issuecomment-219586064
Okay, I have merged this into a JOSHUA-264 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/13#issuecomment-219566852
I can't compile this â Are you using Ivy here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/9#issuecomment-215626822
Okay, this is merged. This is nice work. A few notes:
- Can you tell me how to run the unit tests? @KellenSunderland @fhieber
- The phrase-based
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/9#issuecomment-215596770
Can you describe how to run the unit tests? Are you folks using Eclipse?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/8#issuecomment-215592405
As noted there, this was moved to $JOSHUA/scripts/preparation/tokenize.pl
(detokenize.pl), for the 6.1 release (part of an attempt to impose some
organization
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/6#issuecomment-215286087
Okay, going to hold off until I hear from you...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/6#issuecomment-215274644
Should I wait then to pull this in and fix the test cases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/2#issuecomment-214900222
Cool, I pulled this in. I had to make one small fix to make source-side
annotations work â replacing [] in the input string has to happen in
Token.java
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/8243195611a17e0ef067ec7dbf6c4a57612d041b#commitcomment-17242452
In src/joshua/decoder/StructuredTranslation.java:
In src/joshua/decoder/StructuredTranslation.java on line 47:
I
Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/pull/1#issuecomment-205633596
For reference, I ran this across my timing suite, running start to finish,
single-threaded, iincluding model loading time). For two packed models:
Phrase
79 matches
Mail list logo
