[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764426#comment-13764426
]
Neha Narkhede commented on KAFKA-1003:
--
testing the command line script
[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1003:
-
Attachment: KAFKA-1003-v1.patch
ConsumerFetcherManager should pass clientId as
[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1003:
-
Attachment: (was: KAFKA-1003-v1.patch)
ConsumerFetcherManager should pass clientId as
Jun Rao created KAFKA-1052:
--
Summary: integrate add-partitions command into topicCommand
Key: KAFKA-1052
URL: https://issues.apache.org/jira/browse/KAFKA-1052
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1051:
---
Attachment: kafka-1051.patch
Attach a patch for review. Somehow, couldn't publish a reviewboard because of
[
https://issues.apache.org/jira/browse/KAFKA-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764540#comment-13764540
]
Jun Rao commented on KAFKA-970:
---
This affects the following jars.
[
https://issues.apache.org/jira/browse/KAFKA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764503#comment-13764503
]
Jun Rao commented on KAFKA-1051:
Will leave this jira un-closed for a few days in case
[
https://issues.apache.org/jira/browse/KAFKA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1051:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Since all merge conflicts are easy to
[
https://issues.apache.org/jira/browse/KAFKA-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764544#comment-13764544
]
Jun Rao commented on KAFKA-1046:
Chris,
I merged everything in 0.8 before your change to
This is cool !!! I can't wait to use it.
Some comments:
(1) In [0], Setup - hyperlinks on steps 1 and 2 loop to the same webpage.
(2) I don't have much idea about the right place where the .reviewboardrc
file should be, but it would be a good idea to commit it in the codebase
like [1]. Also,
I wrote a wrapper script that will update the jira as well as the
reviewboard. So the proposed new patch review process will be -
1. Create JIRA
2. Make code changes and commit to local branch
3. Use patch review
Thanks for the review. I created a JIRA to track this -
https://issues.apache.org/jira/browse/KAFKA-1053. Will be great if you can
add your comments there.
Thanks,
Neha
On Wed, Sep 11, 2013 at 11:28 AM, Tejas Patil tejas.patil...@gmail.comwrote:
This is cool !!! I can't wait to use it.
Some
[
https://issues.apache.org/jira/browse/KAFKA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764676#comment-13764676
]
Neha Narkhede commented on KAFKA-1051:
--
This is a big change. Any chance you can give
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
---
(Updated Sept. 11, 2013, 7:53 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14094/
---
Review request for kafka.
Bugs: KAFKA-1053
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764683#comment-13764683
]
Tejas Patil commented on KAFKA-1053:
(1) In [0], Setup - hyperlinks on steps 1 and 2
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764714#comment-13764714
]
Neha Narkhede commented on KAFKA-1053:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: KAFKA-1053-v1.patch
Kafka patch review tool
---
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: (was: KAFKA-1053-v2.patch)
Kafka patch review tool
---
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: KAFKA-1053-v1.patch
Kafka patch review tool
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
---
(Updated Sept. 11, 2013, 7:56 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: (was: KAFKA-1053-v1.patch)
Kafka patch review tool
---
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764712#comment-13764712
]
Neha Narkhede commented on KAFKA-1053:
--
Updated reviewboard
Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: (was: KAFKA-1053-v1.patch)
Kafka patch review tool
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
---
(Updated Sept. 11, 2013, 8:18 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Comment: was deleted
(was: Updated reviewboard)
Kafka patch review tool
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: KAFKA-1053-v1.patch
Kafka patch review tool
---
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: KAFKA-1053-v2.patch
Kafka patch review tool
---
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1053:
-
Attachment: KAFKA-1053-v1.patch
Kafka patch review tool
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
---
(Updated Sept. 11, 2013, 8:44 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764743#comment-13764743
]
Neha Narkhede commented on KAFKA-1053:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764741#comment-13764741
]
Neha Narkhede commented on KAFKA-1053:
--
Thanks for the quick review Tejas
1. I
Neha Narkhede created KAFKA-1053:
Summary: Kafka patch review tool
Key: KAFKA-1053
URL: https://issues.apache.org/jira/browse/KAFKA-1053
Project: Kafka
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764787#comment-13764787
]
Diederik van Liere commented on KAFKA-797:
--
According to
[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1003:
-
Attachment: README.txt
ConsumerFetcherManager should pass clientId as metricsPrefix to
[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764427#comment-13764427
]
Neha Narkhede commented on KAFKA-1003:
--
Command line interface client for JIRA
This
[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1003:
-
Comment: was deleted
(was: Command line interface client for JIRA
This is a command line
[
https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1003:
-
Attachment: (was: README.txt)
ConsumerFetcherManager should pass clientId as
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
---
Review request for kafka.
Bugs: KAFKA-1053
Jun Rao created KAFKA-1051:
--
Summary: merge from 0.8 da4512174b6f7c395ffe053a86d2c6bb19d2538a
to trunk
Key: KAFKA-1051
URL: https://issues.apache.org/jira/browse/KAFKA-1051
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1051:
---
Status: Patch Available (was: Open)
merge from 0.8 da4512174b6f7c395ffe053a86d2c6bb19d2538a to trunk
Hooray! Thanks Neha.
Guozhang
On Wed, Sep 11, 2013 at 10:50 AM, Neha Narkhede neha.narkh...@gmail.comwrote:
I wrote a wrapper script that will update the jira as well as the
reviewboard. So the proposed new patch review process will be -
1. Create JIRA
2. Make code changes and commit to
A Design Question that needs verification:
1. Created a topic T with 'n' partitions.
2. Created a consumer group process with 'n + 1' threads subscribing from
topic 'T' with a groupID 'y'
3. Added another consumer group process with 'n + 1' threads subscribing
from same topic 'T' with same
I think you are hitting this -
https://cwiki.apache.org/confluence/display/KAFKA/FAQ#FAQ-Whysomeoftheconsumersinaconsumergroupneverreceiveanymessage%3F
Let us know if we can improve the documentation to make it clearer.
Thanks,
Neha
On Wed, Sep 11, 2013 at 5:28 PM, prashant amar
Hi,
I'm proposing a new patch review process that will save time on code
reviews and make the patch review process easier, with a one time setup
cost.
I wrote a tool that will do 2 things -
1. Create a patch and upload it to an existing JIRA
2. Create/update reviewboard with the same patch and
Also noticed another issue
Specified below is the current configuration
Topic1 - n Partitions - 2 Consumer Groups (gr1 and gr2)
Topic2 - n Partitions - 2 Consumer Groups (gr1 and gr2)
Notice that I have used the same naming convention on the consumer group
set i.e. 'gr1' and 'gr2' are consumer
I think this is awesome!
Two quick things:
1. I think once we have vetted review board and this tool it would be good
to consolidate the committer workflow documentation. Currently we have a
git workflow, a review board workflow and a review tool workflow. I
actually do not have the ability to
[
https://issues.apache.org/jira/browse/KAFKA-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765141#comment-13765141
]
Jun Rao commented on KAFKA-1051:
There's a problem in generating a reviewboard with this
This means the broker somehow closed the socket connection. Anything in the
broker log around the same time?
Thanks,
Jun
On Wed, Sep 11, 2013 at 6:07 PM, prashant amar amasin...@gmail.com wrote:
Also noticed another issue
Specified below is the current configuration
Topic1 - n Partitions
From the broker log:
INFO Reconnect due to socket error: (kafka.consumer.SimpleConsumer)
java.nio.channels.ClosedChannelException
at kafka.network.BlockingChannel.send(BlockingChannel.scala:89)
at kafka.consumer.SimpleConsumer.liftedTree1$1(SimpleConsumer.scala:72)
at
I usually get this exception when I define 2 partitions ..
Current configuration :
Single Topic - 4 partitions
1 Consumers Group - 10 Threads
On Wed, Sep 11, 2013 at 10:24 PM, prashant amar amasin...@gmail.com wrote:
From the broker log:
INFO Reconnect due to socket error:
51 matches
Mail list logo