[jira] [Created] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1089: - Summary: Migration tool system tests soft-fail on 0.8 and trunk Key: KAFKA-1089 URL: https://issues.apache.org/jira/browse/KAFKA-1089 Project: Kafka Issue Type: Bu

[jira] [Updated] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1089: -- Attachment: KAFKA-1089-v1.patch > Migration tool system tests soft-fail on 0.8 and trunk >

[jira] [Updated] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1089: -- Status: Patch Available (was: Open) > Migration tool system tests soft-fail on 0.8 and trunk > ---

Conditional leader and ISR update fails forever

2013-10-16 Thread Sam Meder
I'm not quite sure how we get into this state, but we've seen this a few times now. Basically, one of our brokers (broker 1 in this case) gets into a state where ISR updates fail forever: [2013-10-16 06:19:12,448] ERROR Conditional update of path /brokers/topics/search-gateway-wal/partitions/5/

Re: Conditional leader and ISR update fails forever

2013-10-16 Thread Jun Rao
The value of the state path for a partition in ZK can be updated by both the controller (for choosing the new leader and potentially shrinking Isr) and the leader replica (for expanding/shrinking Isr). After the controller modified the state path, we don't want the old leader to modify Isr anymore.

[jira] [Commented] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796862#comment-13796862 ] Jun Rao commented on KAFKA-1089: Thanks for the patch. +1. > Migration tool system tests

[jira] [Created] (KAFKA-1090) testPipelinedRequestOrdering has transient failures

2013-10-16 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1090: -- Summary: testPipelinedRequestOrdering has transient failures Key: KAFKA-1090 URL: https://issues.apache.org/jira/browse/KAFKA-1090 Project: Kafka Issue Type: Bug

Review Request 14675: Patch for KAFKA-1090

2013-10-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14675/ --- Review request for kafka. Bugs: KAFKA-1090 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1090) testPipelinedRequestOrdering has transient failures

2013-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1090: --- Attachment: KAFKA-1090.patch > testPipelinedRequestOrdering has transient failures >

[jira] [Commented] (KAFKA-1090) testPipelinedRequestOrdering has transient failures

2013-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796988#comment-13796988 ] Jun Rao commented on KAFKA-1090: Created reviewboard https://reviews.apache.org/r/14675/

[jira] [Updated] (KAFKA-1090) testPipelinedRequestOrdering has transient failures

2013-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1090: --- Status: Patch Available (was: Open) > testPipelinedRequestOrdering has transient failures >

[jira] [Commented] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797000#comment-13797000 ] Joel Koshy commented on KAFKA-1089: --- Thanks for the review - committed to 0.8. I'll doub

[jira] [Created] (KAFKA-1091) full topic list can be read from metadata cache in the broker instead of ZK

2013-10-16 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1091: -- Summary: full topic list can be read from metadata cache in the broker instead of ZK Key: KAFKA-1091 URL: https://issues.apache.org/jira/browse/KAFKA-1091 Project: Kafka

Review Request 14676: Patch for KAFKA-1091

2013-10-16 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/ --- Review request for kafka. Bugs: KAFKA-1091 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1091) full topic list can be read from metadata cache in the broker instead of ZK

2013-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1091: --- Attachment: KAFKA-1091.patch > full topic list can be read from metadata cache in the broker instead of ZK >

[jira] [Commented] (KAFKA-1091) full topic list can be read from metadata cache in the broker instead of ZK

2013-10-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797020#comment-13797020 ] Jun Rao commented on KAFKA-1091: Created reviewboard https://reviews.apache.org/r/14676/

[jira] [Updated] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1089: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to both 0.8 and trunk. >

[jira] [Closed] (KAFKA-1089) Migration tool system tests soft-fail on 0.8 and trunk

2013-10-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1089. - > Migration tool system tests soft-fail on 0.8 and trunk > --

Re: Review Request 14676: Patch for KAFKA-1091

2013-10-16 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/#review27072 --- Ship it! Ship It! - Swapnil Ghike On Oct. 16, 2013, 5:19 p.m., J

Re: Review Request 14676: Patch for KAFKA-1091

2013-10-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/#review27074 --- Ship it! Ship It! - Guozhang Wang On Oct. 16, 2013, 5:19 p.m., J

Re: Review Request 14675: Patch for KAFKA-1090

2013-10-16 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14675/#review27075 --- core/src/test/scala/unit/kafka/network/SocketServerTest.scala

Re: Review Request 14676: Patch for KAFKA-1091

2013-10-16 Thread joel koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/#review27080 --- Ship it! Ship It! - joel koshy On Oct. 16, 2013, 5:19 p.m., Jun

Re: Review Request 14676: Patch for KAFKA-1091

2013-10-16 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14676/#review27085 --- Ship it! Ship It! - Neha Narkhede On Oct. 16, 2013, 5:19 p.m., J

Re: Review Request 14675: Patch for KAFKA-1090

2013-10-16 Thread joel koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14675/#review27086 --- core/src/test/scala/unit/kafka/network/SocketServerTest.scala

Re: Review Request 14638: Patch for KAFKA-1086

2013-10-16 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14638/ --- (Updated Oct. 16, 2013, 11:29 p.m.) Review request for kafka. Bugs: KAFKA-108

[jira] [Updated] (KAFKA-1086) Improve GetOffsetShell to find metadata automatically

2013-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1086: - Attachment: KAFKA-1086_2013-10-16_16:29:06.patch > Improve GetOffsetShell to find metadata automa

Re: Review Request 14638: Patch for KAFKA-1086

2013-10-16 Thread Neha Narkhede
> On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 63 > > > > > > Can use CommandLineUtils.checkRequiredArgs Fixed this. Thanks for pointing this out! > On

[jira] [Commented] (KAFKA-1086) Improve GetOffsetShell to find metadata automatically

2013-10-16 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797425#comment-13797425 ] Neha Narkhede commented on KAFKA-1086: -- Updated reviewboard https://reviews.apache.or