Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

> On Jan. 7, 2014, 11:42 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/common/OptimisticLockFailureException.scala, line > > 23 > > > > > > Is this change intended? This is a diff btw v6 and v7, but is no

[jira] [Resolved] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1074. Resolution: Fixed Thanks for the review. Committed to trunk. File a followup jira KAFKA-1201 to address un

[jira] [Created] (KAFKA-1201) offset in LogCleaner.awaitCleaned is not enforced

Jun Rao created KAFKA-1201: -- Summary: offset in LogCleaner.awaitCleaned is not enforced Key: KAFKA-1201 URL: https://issues.apache.org/jira/browse/KAFKA-1201 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-1200) inconsistent log levels when consumed offset is reset

Jason Rosenberg created KAFKA-1200: -- Summary: inconsistent log levels when consumed offset is reset Key: KAFKA-1200 URL: https://issues.apache.org/jira/browse/KAFKA-1200 Project: Kafka Issue

[jira] [Commented] (KAFKA-1025) Producer.send should provide recoverability info on failiure

[ https://issues.apache.org/jira/browse/KAFKA-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865056#comment-13865056 ] Jason Rosenberg commented on KAFKA-1025: any hope for getting this issue some atte

Re: Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/#review31336 --- core/src/main/scala/kafka/utils/Utils.scala

[jira] [Commented] (KAFKA-1180) WhiteList topic filter gets a NullPointerException on complex Regex

[ https://issues.apache.org/jira/browse/KAFKA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864964#comment-13864964 ] Joe Stein commented on KAFKA-1180: -- Trunk patch = https://issues.apache.org/jira/secure/

[jira] [Commented] (KAFKA-1180) WhiteList topic filter gets a NullPointerException on complex Regex

[ https://issues.apache.org/jira/browse/KAFKA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864961#comment-13864961 ] Joe Stein commented on KAFKA-1180: -- Created reviewboard https://reviews.apache.org/r/1671

[jira] [Updated] (KAFKA-1180) WhiteList topic filter gets a NullPointerException on complex Regex

[ https://issues.apache.org/jira/browse/KAFKA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1180: - Attachment: KAFKA-1180.patch > WhiteList topic filter gets a NullPointerException on complex Regex >

Review Request 16718: Patch for KAFKA-1180

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- Review request for kafka. Bugs: KAFKA-1180 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1180) WhiteList topic filter gets a NullPointerException on complex Regex

[ https://issues.apache.org/jira/browse/KAFKA-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1180: - The KAFKA-1180_2013-12-22_01:24:57.patch is for the 0.8 branch > WhiteList topic filter gets a NullPointerEx

[jira] [Commented] (KAFKA-1190) create a draw performance graph script

[ https://issues.apache.org/jira/browse/KAFKA-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864935#comment-13864935 ] Joel Koshy commented on KAFKA-1190: --- This is useful but do we want to check-in very spec

[jira] [Updated] (KAFKA-1190) create a draw performance graph script

[ https://issues.apache.org/jira/browse/KAFKA-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1190: - Status: Patch Available (was: Open) > create a draw performance graph script > -

[jira] [Updated] (KAFKA-1190) create a draw performance graph script

[ https://issues.apache.org/jira/browse/KAFKA-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1190: - Attachment: KAFKA-1190.patch > create a draw performance graph script > -

[jira] [Commented] (KAFKA-1190) create a draw performance graph script

[ https://issues.apache.org/jira/browse/KAFKA-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864918#comment-13864918 ] Joe Stein commented on KAFKA-1190: -- Created reviewboard https://reviews.apache.org/r/1671

Review Request 16714: Patch for KAFKA-1190

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16714/ --- Review request for kafka. Bugs: KAFKA-1190 https://issues.apache.org/jira/b

Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/#review31322 --- Ship it! Other than the question below, I think this patch looks go

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864627#comment-13864627 ] Christopher Freeman commented on KAFKA-1171: In the patch, the scalatest depen

Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15674/ --- (Updated Jan. 7, 2014, 6:51 p.m.) Review request for kafka. Summary (updated)

[jira] [Updated] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1074: --- Attachment: KAFKA-1074_2014-01-07_10:55:08.patch > Reassign partitions should delete the old replicas from di

[jira] [Commented] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864538#comment-13864538 ] Jun Rao commented on KAFKA-1074: Updated reviewboard https://reviews.apache.org/r/15674/

Re: Review Request 15674: move LogCleanerManager to a separate file and improve unit test

> On Jan. 6, 2014, 9:18 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/log/LogCleaner.scala, line 161 > > > > > > the method description says it should block until the cleaner has > > processed upto the give

Re: Review Request 16360: Address Jun's comments v3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review31299 --- In general, does the alternate approach of sending all commands to e