[jira] [Commented] (KAFKA-188) Support multiple data directories

2014-11-07 Thread chenshangan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201821#comment-14201821 ] chenshangan commented on KAFKA-188: --- assign a new partition to the dir with the fewest

[jira] [Comment Edited] (KAFKA-188) Support multiple data directories

2014-11-07 Thread chenshangan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201821#comment-14201821 ] chenshangan edited comment on KAFKA-188 at 11/7/14 9:16 AM:

[jira] [Commented] (KAFKA-1754) KOYA - Kafka on YARN

2014-11-07 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201824#comment-14201824 ] Steve Loughran commented on KAFKA-1754: --- Thomas, yes, keytabs c as addressed in

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-07 Thread Dmytro Kostiuchenko
On Nov. 7, 2014, 5 a.m., Gwen Shapira wrote: core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala, line 144 https://reviews.apache.org/r/27634/diff/3/?file=751668#file751668line144 String.valueOf(false) should evaluate to false, right? Why do we need

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

2014-11-07 Thread Jing Dong (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201913#comment-14201913 ] Jing Dong commented on KAFKA-493: - [~smeder] Do you have the hprof command you used? I can

Review Request 27722: Patch for KAFKA-1749

2014-11-07 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27722/ --- Review request for kafka. Bugs: KAFKA-1749

[jira] [Commented] (KAFKA-1749) Brokers continually throw exceptions when there are hundreds of topic being fetched by mirrormaker

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201983#comment-14201983 ] Manikumar Reddy commented on KAFKA-1749: Created reviewboard

[jira] [Issue Comment Deleted] (KAFKA-1749) Brokers continually throw exceptions when there are hundreds of topic being fetched by mirrormaker

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1749: --- Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/27722/diff/

Review Request 27723: Patch for KAFKA-1739

2014-11-07 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27723/ --- Review request for kafka. Bugs: KAFKA-1739

[jira] [Updated] (KAFKA-1739) Remove testComplexCompressDecompress in MessageCompressionTest

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1739: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Remove

[jira] [Updated] (KAFKA-1739) Remove testComplexCompressDecompress in MessageCompressionTest

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1739: --- Attachment: KAFKA-1739.patch Remove testComplexCompressDecompress in MessageCompressionTest

[jira] [Commented] (KAFKA-1739) Remove testComplexCompressDecompress in MessageCompressionTest

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201985#comment-14201985 ] Manikumar Reddy commented on KAFKA-1739: Created reviewboard

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-07 Thread Dmytro Kostiuchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27634/ --- (Updated Nov. 7, 2014, 1:28 p.m.) Review request for kafka. Bugs: KAFKA-1667

[jira] [Updated] (KAFKA-1667) topic-level configuration not validated

2014-11-07 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Kostiuchenko updated KAFKA-1667: --- Attachment: KAFKA-1667_2014-11-07_14:28:14.patch topic-level configuration not

[jira] [Commented] (KAFKA-1667) topic-level configuration not validated

2014-11-07 Thread Dmytro Kostiuchenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202026#comment-14202026 ] Dmytro Kostiuchenko commented on KAFKA-1667: Updated reviewboard

[jira] [Commented] (KAFKA-1738) Partitions for topic not created after restart from forced shutdown

2014-11-07 Thread schandr (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202173#comment-14202173 ] schandr commented on KAFKA-1738: The patch works and thanks for the help!!!. Will this be

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

2014-11-07 Thread Sam Meder (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202228#comment-14202228 ] Sam Meder commented on KAFKA-493: - Sorry, don't have that anymore - it's been too long

[jira] [Commented] (KAFKA-1733) Producer.send will block indeterminately when broker is unavailable.

2014-11-07 Thread Solon Gordon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202276#comment-14202276 ] Solon Gordon commented on KAFKA-1733: - Any chance of getting this into a bugfix

[jira] [Commented] (KAFKA-1745) Each new thread creates a PIPE and KQUEUE as open files during producer.send() and does not get cleared when the thread that creates them is cleared.

2014-11-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202291#comment-14202291 ] Ewen Cheslack-Postava commented on KAFKA-1745: -- [~Vishal M] I looked into

[jira] [Commented] (KAFKA-493) High CPU usage on inactive server

2014-11-07 Thread Jing Dong (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202310#comment-14202310 ] Jing Dong commented on KAFKA-493: - [~smeder] Thanks for the response - do you remember

[jira] [Comment Edited] (KAFKA-493) High CPU usage on inactive server

2014-11-07 Thread Jing Dong (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202310#comment-14202310 ] Jing Dong edited comment on KAFKA-493 at 11/7/14 5:29 PM: --

[jira] [Commented] (KAFKA-188) Support multiple data directories

2014-11-07 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202355#comment-14202355 ] Jay Kreps commented on KAFKA-188: - [~chenshangan...@163.com] see my comment earlier on this

Review Request 27735: Patch for KAFKA-1173

2014-11-07 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/ --- Review request for kafka. Bugs: KAFKA-1173

[jira] [Updated] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-11-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1173: - Attachment: KAFKA-1173.patch Using Vagrant to get up and running with Apache

[jira] [Commented] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-11-07 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202395#comment-14202395 ] Ewen Cheslack-Postava commented on KAFKA-1173: -- Created reviewboard

[jira] [Commented] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-11-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202418#comment-14202418 ] Guozhang Wang commented on KAFKA-1742: -- Thanks for the patch, looks good to me.

[jira] [Updated] (KAFKA-1738) Partitions for topic not created after restart from forced shutdown

2014-11-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1738: --- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the review. Double committed to

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2014-11-07 Thread Jon Riegel (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202488#comment-14202488 ] Jon Riegel commented on KAFKA-1460: --- We experienced this issue with a production

Build failed in Jenkins: Kafka-trunk #325

2014-11-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/325/changes Changes: [junrao] kafka-1738; Partitions for topic not created after restart from forced shutdown; patched by Jun Rao; reviewed by Neha Narkhede -- [...truncated 413 lines...]

Re: Review Request 27723: Patch for KAFKA-1739

2014-11-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27723/#review60359 --- Ship it! - Guozhang Wang On Nov. 7, 2014, 12:26 p.m., Manikumar

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60364 --- core/src/main/scala/kafka/consumer/ConsumerConnector.scala

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60375 --- core/src/main/scala/kafka/consumer/ConsumerConnector.scala

[jira] [Created] (KAFKA-1759) transient unit test failure in PartitionAssignorTest

2014-11-07 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1759: -- Summary: transient unit test failure in PartitionAssignorTest Key: KAFKA-1759 URL: https://issues.apache.org/jira/browse/KAFKA-1759 Project: Kafka Issue Type: Bug

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

2014-11-07 Thread Guozhang Wang
On Nov. 7, 2014, 3 a.m., Joel Koshy wrote: clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java, line 152 https://reviews.apache.org/r/27391/diff/2/?file=753752#file753752line152 This confused me a bit, and I think it is because initCommonFields is

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

2014-11-07 Thread Guozhang Wang
On Nov. 7, 2014, 3 a.m., Joel Koshy wrote: core/src/main/scala/kafka/common/OffsetMetadataAndError.scala, line 22 https://reviews.apache.org/r/27391/diff/2/?file=753755#file753755line22 Can we mark this @Deprecated as well? We should probably make the primary

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2014-11-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203063#comment-14203063 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2014-11-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2014-11-07_16:54:33.patch Improve semantics of timestamp in

Re: Review Request 27391: Fix KAFKA-1634: Add the global retentionTime (in milis) and disable the per-offset timestamp

2014-11-07 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated Nov. 8, 2014, 12:54 a.m.) Review request for kafka. Bugs:

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27534/#review60460 --- system_test/utils/kafka_system_test_utils.py

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/ --- (Updated Nov. 8, 2014, 6:20 a.m.) Review request for kafka. Bugs: KAFKA-1743

[jira] [Commented] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203262#comment-14203262 ] Manikumar Reddy commented on KAFKA-1743: Updated reviewboard

[jira] [Updated] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

2014-11-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1743: --- Attachment: KAFKA-1743_2014-11-08_11:49:31.patch ConsumerConnector.commitOffsets in 0.8.2 is

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-07 Thread Manikumar Reddy O
On Nov. 7, 2014, 7:35 p.m., Gwen Shapira wrote: core/src/main/scala/kafka/consumer/ConsumerConnector.scala, line 73 https://reviews.apache.org/r/27684/diff/1/?file=751760#file751760line73 I'd add a comment on why we have two interfaces here, since its none-obvious and someone may