[jira] [Created] (KAFKA-1765) slf4j binding conflict in slf4j-log4j12 and kafka-assembly

2014-11-10 Thread shizhu, wang (JIRA)
shizhu, wang created KAFKA-1765: --- Summary: slf4j binding conflict in slf4j-log4j12 and kafka-assembly Key: KAFKA-1765 URL: https://issues.apache.org/jira/browse/KAFKA-1765 Project: Kafka Issue

Re: Review Request 27735: Patch for KAFKA-1173

2014-11-10 Thread Joe Stein
> On Nov. 11, 2014, 4:40 a.m., Joe Stein wrote: > > Vagrantfile, line 30 > > > > > > we should use the enviornment variable AWS_ACCESS_KEY and > > AWS_SECRET_KEY which vagrant aws provider will read instead > > https:

[jira] [Commented] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-11-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205952#comment-14205952 ] Joe Stein commented on KAFKA-1173: -- This looks really great, so far only minor things (st

Re: Review Request 27735: Patch for KAFKA-1173

2014-11-10 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/#review60747 --- Vagrantfile

Re: Review Request 27735: Patch for KAFKA-1173

2014-11-10 Thread Joe Stein
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/#review60746 --- Vagrantfile

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205937#comment-14205937 ] Jun Rao commented on KAFKA-1481: [~vladimir.tretyakov], we could probably just add a new M

Question about ZookeeperConsumerConnector

2014-11-10 Thread Becket Qin
Hi, We encountered a production issue recently that Mirror Maker could not properly shutdown because ZookeeperConsumerConnector is blocked on shutdown(). After looking into the code, we found 2 issues that caused this problem. 1. After consumer iterator receives the shutdownCommand, It puts the s

[jira] [Created] (KAFKA-1764) ZookeeperConsumerConnector could put multiple shutdownCommand to the same data chunk queue.

2014-11-10 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-1764: --- Summary: ZookeeperConsumerConnector could put multiple shutdownCommand to the same data chunk queue. Key: KAFKA-1764 URL: https://issues.apache.org/jira/browse/KAFKA-1764

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-10 Thread Mayuresh Gharat
> On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote: > > system_test/utils/kafka_system_test_utils.py, line 2403 > > > > > > This causes many system tests (approx 98) to fail > > Ewen Cheslack-Postava wrote: > Ca

[jira] [Commented] (KAFKA-1753) add --decommission-broker option

2014-11-10 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205848#comment-14205848 ] Neha Narkhede commented on KAFKA-1753: -- [~Dmitry Pekar] It will help to know how you

[jira] [Updated] (KAFKA-1763) validate_index_log in system tests runs remotely but uses local paths

2014-11-10 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1763: - Attachment: KAFKA-1763.patch > validate_index_log in system tests runs remotely bu

[jira] [Updated] (KAFKA-1763) validate_index_log in system tests runs remotely but uses local paths

2014-11-10 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1763: - Status: Patch Available (was: Open) > validate_index_log in system tests runs rem

[jira] [Commented] (KAFKA-1763) validate_index_log in system tests runs remotely but uses local paths

2014-11-10 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205714#comment-14205714 ] Ewen Cheslack-Postava commented on KAFKA-1763: -- Created reviewboard https://r

Review Request 27851: Patch for KAFKA-1763

2014-11-10 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27851/ --- Review request for kafka. Bugs: KAFKA-1763 https://issues.apache.org/jira/b

Re: two questions regarding 0.8.2 producer code

2014-11-10 Thread Steven Wu
Jay, thanks a lot for the quick response. For #2, I do see some isSendable() check in Sender.java and NetworkClient.java that is eventually mapped to InFlightRequests#canSendMore() check. it wasn't immediately clear to me how is that translated to transmissions.hasSend() check. anyway, I will dig

[jira] [Updated] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-11-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1173: - Assignee: Ewen Cheslack-Postava (was: Joe Stein) > Using Vagrant to get up and running with Apache Kafka

[jira] [Assigned] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-11-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reassigned KAFKA-1173: Assignee: Joe Stein > Using Vagrant to get up and running with Apache Kafka > -

Kafka consumer transactional support

2014-11-10 Thread Falabella, Anthony
I've tried to search a bit for what the current status is for Kafka supporting consumer transactions. These links look to be the best indication of where things stand with that: http://search-hadoop.com/m/4TaT4xeqNq1 https://cwiki.apache.org/confluence/display/KAFKA/Transactional+Messaging+in+Ka

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2014-11-10 Thread Noah Yetter (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205580#comment-14205580 ] Noah Yetter commented on KAFKA-1460: For what it's worth there's nothing in the docume

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2014-11-10 Thread Jon Riegel (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205531#comment-14205531 ] Jon Riegel commented on KAFKA-1460: --- Separating kafka and zookeeper onto different insta

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-10 Thread Gwen Shapira
> On Nov. 7, 2014, 5 a.m., Gwen Shapira wrote: > > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala, > > line 144 > > > > > > String.valueOf(false) should evaluate to "false", right? Why do w

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-11-10 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205497#comment-14205497 ] Sriharsha Chintalapani commented on KAFKA-1070: --- [~nehanarkhede] will implem

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-10 Thread Ewen Cheslack-Postava
> On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote: > > system_test/utils/kafka_system_test_utils.py, line 2403 > > > > > > This causes many system tests (approx 98) to fail > > Ewen Cheslack-Postava wrote: > Ca

[jira] [Created] (KAFKA-1763) validate_index_log in system tests runs remotely but uses local paths

2014-11-10 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-1763: Summary: validate_index_log in system tests runs remotely but uses local paths Key: KAFKA-1763 URL: https://issues.apache.org/jira/browse/KAFKA-1763 P

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-11-10 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205491#comment-14205491 ] Neha Narkhede commented on KAFKA-1070: -- [~sriharsha] Would you mind rebasing your pat

Re: two questions regarding 0.8.2 producer code

2014-11-10 Thread Jay Kreps
1. No, the send does a poll/select on all the connections that will block for a specified time waiting for data to read or write on any connection. 2. The api of the selector only allows you to send a request to a ready connection. The definition of ready is that it doesn't have another request in

Re: Review Request 27634: Patch for KAFKA-1667

2014-11-10 Thread Gwen Shapira
> On Nov. 7, 2014, 5 a.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/utils/Utils.scala, lines 514-522 > > > > > > I think I'm not seeing why we need this. > > Shouldn't Scala's JavaConversion class handle

[jira] [Commented] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205478#comment-14205478 ] Guozhang Wang commented on KAFKA-1762: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1762: - Attachment: KAFKA-1762.patch > Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker >

[jira] [Updated] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1762: - Status: Patch Available (was: Open) > Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in Mirro

Review Request 27834: Fix KAFKA-1762: add comment on risks using a larger value of max.inflight.requests than 1, in KAFKA-1650 we will add another comment about its risk of data loss

2014-11-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27834/ --- Review request for kafka. Bugs: KAFKA-1762 https://issues.apache.org/jira/b

two questions regarding 0.8.2 producer code

2014-11-10 Thread Steven Wu
I am checking out the source code of 0.8.2 producer code. I have two questions and hope to get some clarifications. 1) Sender thread/Runnable has this run loop. what if the in-memory queue is mostly empty (i.e. producer has very few msgs to send out)? will this become a simple tight loop that just

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2014-11-10 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205277#comment-14205277 ] Stevo Slavic commented on KAFKA-1761: - Changed in [commit|https://github.com/apache/k

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2014-11-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205247#comment-14205247 ] Jun Rao commented on KAFKA-1761: It seems that server.properties is already back to 1 for

[jira] [Updated] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1762: - Description: The new Producer client introduces a config for the max # of inFlight messages. When

[jira] [Commented] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205245#comment-14205245 ] Guozhang Wang commented on KAFKA-1762: -- Updated the title / description. > Enforce M

[jira] [Updated] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1762: - Description: The new Producer client introduces a config for the max # of inFlight messages. When

[jira] [Updated] (KAFKA-1762) Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1762: - Summary: Enforce MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION to 1 in MirrorMaker (was: Set MAX_IN_FLIGH

Re: Review Request 25995: Patch for KAFKA-1650

2014-11-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review60659 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

[jira] [Commented] (KAFKA-1762) Set MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION default to 1

2014-11-10 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205233#comment-14205233 ] Jay Kreps commented on KAFKA-1762: -- Can you elaborate on how this happens? Also are you p

[jira] [Created] (KAFKA-1762) Set MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION default to 1

2014-11-10 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1762: Summary: Set MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION default to 1 Key: KAFKA-1762 URL: https://issues.apache.org/jira/browse/KAFKA-1762 Project: Kafka Issue Ty

Re: Review Request 27684: Patch for KAFKA-1743

2014-11-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27684/#review60652 --- Thanks for the patch. Some comments below. core/src/main/scala/kaf

[jira] [Updated] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-11-10 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1742: Attachment: KAFKA-1742.patch Updated patch with Joel's suggestion to {code}filter{ case (topicAndPar

[jira] [Updated] (KAFKA-1756) never allow the replica fetch size to be less than the max message size

2014-11-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1756: - Fix Version/s: (was: 0.8.2) 0.8.3 > never allow the replica fetch size to be less t

[jira] [Commented] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205193#comment-14205193 ] Guozhang Wang commented on KAFKA-1742: -- Actually, just realized that we do not have a

[jira] [Commented] (KAFKA-1756) never allow the replica fetch size to be less than the max message size

2014-11-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205189#comment-14205189 ] Jun Rao commented on KAFKA-1756: Gwen, Yes, we can do that. However, it seems currently o

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205175#comment-14205175 ] BalajiSeshadri commented on KAFKA-1476: --- [~nehanarkhede] Please find review comments

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205171#comment-14205171 ] BalajiSeshadri commented on KAFKA-1476: --- Updated reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1476: -- Attachment: KAFKA-1476_2014-11-10_12:06:35.patch > Get a list of consumer groups > -

Re: Review Request 27693: Patch for KAFKA-1476

2014-11-10 Thread Balaji Seshadri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27693/ --- (Updated Nov. 10, 2014, 7:06 p.m.) Review request for kafka. Bugs: KAFKA-1476

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1476: -- Attachment: KAFKA-1476_2014-11-10_12:04:01.patch > Get a list of consumer groups > -

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205166#comment-14205166 ] BalajiSeshadri commented on KAFKA-1476: --- Updated reviewboard https://reviews.apache.

Re: Review Request 27693: Patch for KAFKA-1476

2014-11-10 Thread Balaji Seshadri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27693/ --- (Updated Nov. 10, 2014, 7:04 p.m.) Review request for kafka. Bugs: KAFKA-1476

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1476: -- Attachment: KAFKA-1476_2014-11-10_11:58:26.patch > Get a list of consumer groups > -

Re: Review Request 27693: Patch for KAFKA-1476

2014-11-10 Thread Balaji Seshadri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27693/ --- (Updated Nov. 10, 2014, 6:58 p.m.) Review request for kafka. Bugs: KAFKA-1476

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205160#comment-14205160 ] BalajiSeshadri commented on KAFKA-1476: --- Updated reviewboard https://reviews.apache.

[jira] [Commented] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-11-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205156#comment-14205156 ] Jun Rao commented on KAFKA-1282: Nicu, Thanks for the patch. Do you think it's easy to ad

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-10 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205103#comment-14205103 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi again, added new patches (for co

[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-10 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Tretyakov updated KAFKA-1481: -- Attachment: KAFKA-1481_2014-11-10_20-39-41_doc.patch KAFKA-1481_2014-11-1

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205093#comment-14205093 ] BalajiSeshadri commented on KAFKA-328: -- [~nehanarkhede] Please find changes in review

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205087#comment-14205087 ] BalajiSeshadri commented on KAFKA-328: -- Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-328: - Attachment: KAFKA-328_2014-11-10_11:05:58.patch > Write unit test for kafka server startup and shut

Re: Review Request 27818: Patch for KAFKA-328

2014-11-10 Thread Balaji Seshadri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27818/ --- (Updated Nov. 10, 2014, 6:05 p.m.) Review request for kafka. Bugs: KAFKA-328

[jira] [Commented] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205077#comment-14205077 ] BalajiSeshadri commented on KAFKA-328: -- Created reviewboard https://reviews.apache.org

Re: Review Request 27534: Patch for KAFKA-1746

2014-11-10 Thread Mayuresh Gharat
> On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote: > > system_test/utils/kafka_system_test_utils.py, line 2403 > > > > > > This causes many system tests (approx 98) to fail > > Ewen Cheslack-Postava wrote: > Ca

[jira] [Updated] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-11-10 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-328: - Attachment: KAFKA-328.patch > Write unit test for kafka server startup and shutdown API >

Review Request 27818: Patch for KAFKA-328

2014-11-10 Thread Balaji Seshadri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27818/ --- Review request for kafka. Bugs: KAFKA-328 https://issues.apache.org/jira/br

Re: New Java producer question

2014-11-10 Thread Joe Stein
Ah Ha!!! Yes, that is it. Thanks! On Mon, Nov 10, 2014 at 8:49 AM, Guozhang Wang wrote: > Joe, > > Are you looking for this? > > > /** retries */ > public static final String RETRIES_CONFIG = "retries"; > > Guozhang > > On Mon, Nov 10, 2014 at 8:11 AM, Joe Stein wrote: > > > In the new Java

Re: New Java producer question

2014-11-10 Thread Guozhang Wang
Joe, Are you looking for this? /** retries */ public static final String RETRIES_CONFIG = "retries"; Guozhang On Mon, Nov 10, 2014 at 8:11 AM, Joe Stein wrote: > In the new Java producer I see that you can set RETRY_BACKOFF_MS_CONFIG > > https://github.com/apache/kafka/blob/0.8.2/clients

New Java producer question

2014-11-10 Thread Joe Stein
In the new Java producer I see that you can set RETRY_BACKOFF_MS_CONFIG https://github.com/apache/kafka/blob/0.8.2/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L112 which is used https://github.com/apache/kafka/blob/0.8.2/clients/src/main/java/org/apache/kafka/clients/

[jira] [Commented] (KAFKA-1737) Document required ZkSerializer for ZkClient used with AdminUtils

2014-11-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204924#comment-14204924 ] Guozhang Wang commented on KAFKA-1737: -- Originally when I discussed with [~sslavic] I

Re: Support for topics+streams at class WildcardStreamsHandler

2014-11-10 Thread Guozhang Wang
Hi Alan, The reason we do not have per-topic parallelism spec in wildcard is two folds: 1) we use a per-topic hash-based partition algorithm, and hence having each topic with the same num. of streams may give us better load balance, 2) with the topicFilter we will not know exactly which topics to

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2014-11-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204840#comment-14204840 ] Joe Stein commented on KAFKA-1761: -- [~sslavic] There are a handful of cases (e.g. https:

[jira] [Created] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2014-11-10 Thread Stevo Slavic (JIRA)
Stevo Slavic created KAFKA-1761: --- Summary: num.partitionsdocumented default is 1 while actual default is 2 Key: KAFKA-1761 URL: https://issues.apache.org/jira/browse/KAFKA-1761 Project: Kafka

[jira] [Commented] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-11-10 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204807#comment-14204807 ] Joe Stein commented on KAFKA-1173: -- I should have a chance to give the script a spin up/d

[jira] [Commented] (KAFKA-1753) add --decommission-broker option

2014-11-10 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204782#comment-14204782 ] Dmitry Pekar commented on KAFKA-1753: - [~gwenshap] [~nehanarkhede] [~charmalloc] I was

[jira] [Commented] (KAFKA-1752) add --replace-broker option

2014-11-10 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204774#comment-14204774 ] Dmitry Pekar commented on KAFKA-1752: - [~gwenshap] [~nehanarkhede] This CLI already ha

[jira] [Comment Edited] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-11-10 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204467#comment-14204467 ] Vladimir Tretyakov edited comment on KAFKA-1481 at 11/10/14 10:07 AM: --